From: Kalle Valo <kvalo@codeaurora.org>
To: Kangjie Lu <kjlu@umn.edu>
Cc: kjlu@umn.edu, pakki001@umn.edu,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: wireless: fix missing checks for ioremap
Date: Fri, 26 Apr 2019 11:48:24 +0000 (UTC) [thread overview]
Message-ID: <20190426114824.B271C602F5@smtp.codeaurora.org> (raw)
In-Reply-To: <20190311075440.1513-1-kjlu@umn.edu>
Kangjie Lu <kjlu@umn.edu> wrote:
> ioremap could fail and returns NULL. The fix actively checks
> its return value and handles potential failures.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
The prefix should be "ray_cs: ":
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
Also I don't see the point of setting the ret variable as it's ignored in the failed label:
failed:
ray_release(link);
return -ENODEV;
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/10846851/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-04-26 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 7:54 [PATCH] net: wireless: fix missing checks for ioremap Kangjie Lu
2019-03-23 3:58 ` Kangjie Lu
2019-04-26 11:48 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426114824.B271C602F5@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.