From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 2/2] gpio: sch: Add interrupt support Date: Fri, 26 Apr 2019 16:06:15 +0300 Message-ID: <20190426130615.GT9224@smile.fi.intel.com> References: <20190424081802.GV2654@lahna.fi.intel.com> <5a28f22c-22f7-760a-d076-68ff19800d44@siemens.com> <20190424084259.GW2654@lahna.fi.intel.com> <7e328b7e-f4f0-851a-4152-a9ffd058201c@siemens.com> <20190424094506.GA2654@lahna.fi.intel.com> <292e6eff-82cc-6e4d-925b-77a60399e2e0@siemens.com> <20190424100130.GB2654@lahna.fi.intel.com> <1200464b-f969-ebc2-ae82-1f8ca98aaca1@siemens.com> <20190424103306.GC2654@lahna.fi.intel.com> <9377620b-d74a-04d9-a51e-8590400b1c0f@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <9377620b-d74a-04d9-a51e-8590400b1c0f@siemens.com> Sender: linux-kernel-owner@vger.kernel.org To: Jan Kiszka Cc: Mika Westerberg , Linus Walleij , Bartosz Golaszewski , Linux Kernel Mailing List , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" List-Id: linux-acpi@vger.kernel.org On Wed, Apr 24, 2019 at 12:39:35PM +0200, Jan Kiszka wrote: > On 24.04.19 12:33, Mika Westerberg wrote: > > On Wed, Apr 24, 2019 at 12:19:02PM +0200, Jan Kiszka wrote: > > > And even if that were possible, we would be back to the square of existing > > > devices without those definitions. If this were a recent chipset, I would > > > say, "go, fix future firmware versions". But this one is legacy. > > > > Is it fixing some real issue with these legacy platforms? I mean without > > the patch some GPE event is not handled properly? It was not clear to me > > from the commit message. > > > > Without that patch, you are forced to poll for event changes in your > application, timer-driven. There are application that cannot process these > GPIOs because they lack such logic (mraa with node-red-node-intel-gpio is a > public example). Just a side note: MRAA is a hack itself. It abuses almost all interfaces Linux kernel provides. -- With Best Regards, Andy Shevchenko