From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] iommu/dmar: Use struct_size() helper Date: Fri, 26 Apr 2019 16:44:57 +0200 Message-ID: <20190426144457.GH24576@8bytes.org> References: <20190418184624.GA17025@embeddedor> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190418184624.GA17025@embeddedor> Sender: linux-kernel-owner@vger.kernel.org To: "Gustavo A. R. Silva" Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On Thu, Apr 18, 2019 at 01:46:24PM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace code of the following form: > > size = sizeof(*info) + level * sizeof(info->path[0]); > > with: > > size = struct_size(info, path, level); > > Signed-off-by: Gustavo A. R. Silva Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB81C43219 for ; Fri, 26 Apr 2019 14:47:01 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32BBF2077B for ; Fri, 26 Apr 2019 14:47:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32BBF2077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E03C027ED; Fri, 26 Apr 2019 14:47:00 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 24BE527DF for ; Fri, 26 Apr 2019 14:45:05 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id B1BA982E for ; Fri, 26 Apr 2019 14:45:04 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 2CDFBD91; Fri, 26 Apr 2019 16:45:02 +0200 (CEST) Date: Fri, 26 Apr 2019 16:44:57 +0200 From: Joerg Roedel To: "Gustavo A. R. Silva" Subject: Re: [PATCH] iommu/dmar: Use struct_size() helper Message-ID: <20190426144457.GH24576@8bytes.org> References: <20190418184624.GA17025@embeddedor> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190418184624.GA17025@embeddedor> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190426144457.IT-rYAPTng_zytoJiQDZpmVZHNGoQ1gd1u-F1Lyn4Ns@z> On Thu, Apr 18, 2019 at 01:46:24PM -0500, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, replace code of the following form: > > size = sizeof(*info) + level * sizeof(info->path[0]); > > with: > > size = struct_size(info, path, level); > > Signed-off-by: Gustavo A. R. Silva Applied, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu