From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] Remove old no iommu direct mapping code Date: Fri, 26 Apr 2019 17:02:42 +0200 Message-ID: <20190426150242.GL24576@8bytes.org> References: <20190423200335.3888-1-tmurphy@arista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190423200335.3888-1-tmurphy@arista.com> Sender: linux-kernel-owner@vger.kernel.org To: Tom Murphy Cc: iommu@lists.linux-foundation.org, murphyt7@tcd.ie, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On Tue, Apr 23, 2019 at 09:03:34PM +0100, Tom Murphy wrote: > These checks were intended to handle devices not mapped by the IOMMU. > Since the AMD IOMMU driver uses per-device dma_ops these functions can > no longer be called by direct mapped devices. So these checks aren't > needed anymore. > > Signed-off-by: Tom Murphy > --- > drivers/iommu/amd_iommu.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) This has already been done by Christoph, see https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/commit/?id=7a5dbf3ab2f04905cf8468c66fcdbfb643068bcb Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3828C43218 for ; Fri, 26 Apr 2019 15:04:28 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9856206E0 for ; Fri, 26 Apr 2019 15:04:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9856206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 7DA6C27F0; Fri, 26 Apr 2019 15:04:28 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id F418727E6 for ; Fri, 26 Apr 2019 15:02:45 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9566282A for ; Fri, 26 Apr 2019 15:02:45 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id E1FA7D91; Fri, 26 Apr 2019 17:02:43 +0200 (CEST) Date: Fri, 26 Apr 2019 17:02:42 +0200 From: Joerg Roedel To: Tom Murphy Subject: Re: [PATCH] Remove old no iommu direct mapping code Message-ID: <20190426150242.GL24576@8bytes.org> References: <20190423200335.3888-1-tmurphy@arista.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190423200335.3888-1-tmurphy@arista.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, murphyt7@tcd.ie X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Message-ID: <20190426150242.LCfdyR0WTKqxs4Y3X7e3RC0OqTlXpzV43egsc74VXTc@z> On Tue, Apr 23, 2019 at 09:03:34PM +0100, Tom Murphy wrote: > These checks were intended to handle devices not mapped by the IOMMU. > Since the AMD IOMMU driver uses per-device dma_ops these functions can > no longer be called by direct mapped devices. So these checks aren't > needed anymore. > > Signed-off-by: Tom Murphy > --- > drivers/iommu/amd_iommu.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) This has already been done by Christoph, see https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/commit/?id=7a5dbf3ab2f04905cf8468c66fcdbfb643068bcb Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu