From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch Date: Fri, 26 Apr 2019 15:49:06 -0500 Message-ID: <20190426204906.GB15074@bogus> References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Chunfeng Yun Cc: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Biju Das , Linus Walleij List-Id: linux-mediatek@lists.infradead.org On Fri, Apr 26, 2019 at 02:47:14PM +0800, Chunfeng Yun wrote: > Now the USB Role Switch is supported, so add properties about it > > Signed-off-by: Chunfeng Yun > --- > v4: no changes > v3: no changes > > v2 changes: > 1. fix typo > 2. refer new binding about connector property > --- > .../devicetree/bindings/usb/mediatek,mtu3.txt | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > index 3382b5cb471d..6e004c4a89af 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > @@ -27,7 +27,9 @@ Optional properties: > - ranges : allows valid 1:1 translation between child's address space and > parent's address space > - extcon : external connector for vbus and idpin changes detection, needed > - when supports dual-role mode. > + when supports dual-role mode; it's consiedered valid for compatibility > + reasons, and not allowed for new bindings, use the property > + usb-role-switch instead. > - vbus-supply : reference to the VBUS regulator, needed when supports > dual-role mode. > - pinctrl-names : a pinctrl state named "default" is optional, and need be > @@ -36,7 +38,8 @@ Optional properties: > is not set. > - pinctrl-0 : pin control group > See: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > - > + - usb-role-switch : use USB Role Switch to support dual-role switch, but > + not extcon Coordinate with the Renesas and HiSilicon folks implementing the same thing and put this in a common spot. However, I think this should not even be needed as knowing the controller capabilities (based on the compatible) and knowing the type of connector should be enough information to tell you if dual role is supported or not. > - maximum-speed : valid arguments are "super-speed", "high-speed" and > "full-speed"; refer to usb/generic.txt > - enable-manual-drd : supports manual dual-role switch via debugfs; usually > @@ -61,6 +64,9 @@ The xhci should be added as subnode to mtu3 as shown in the following example > if host mode is enabled. The DT binding details of xhci can be found in: > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > +The port would be added as subnode if use usb-role-switch property > + see graph.txt > + > Example: > ssusb: usb@11271000 { > compatible = "mediatek,mt8173-mtu3"; > -- > 2.21.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch From: Rob Herring Message-Id: <20190426204906.GB15074@bogus> Date: Fri, 26 Apr 2019 15:49:06 -0500 To: Chunfeng Yun Cc: Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Andy Shevchenko , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Biju Das , Linus Walleij List-ID: T24gRnJpLCBBcHIgMjYsIDIwMTkgYXQgMDI6NDc6MTRQTSArMDgwMCwgQ2h1bmZlbmcgWXVuIHdy b3RlOgo+IE5vdyB0aGUgVVNCIFJvbGUgU3dpdGNoIGlzIHN1cHBvcnRlZCwgc28gYWRkIHByb3Bl cnRpZXMgYWJvdXQgaXQKPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHVuZmVuZyBZdW4gPGNodW5mZW5n Lnl1bkBtZWRpYXRlay5jb20+Cj4gLS0tCj4gdjQ6IG5vIGNoYW5nZXMKPiB2Mzogbm8gY2hhbmdl cwo+IAo+IHYyIGNoYW5nZXM6Cj4gICAxLiBmaXggdHlwbwo+ICAgMi4gcmVmZXIgbmV3IGJpbmRp bmcgYWJvdXQgY29ubmVjdG9yIHByb3BlcnR5Cj4gLS0tCj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRp bmdzL3VzYi9tZWRpYXRlayxtdHUzLnR4dCAgICAgICAgICB8IDEwICsrKysrKysrLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdHUz LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvbWVkaWF0ZWssbXR1 My50eHQKPiBpbmRleCAzMzgyYjVjYjQ3MWQuLjZlMDA0YzRhODlhZiAxMDA2NDQKPiAtLS0gYS9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL21lZGlhdGVrLG10dTMudHh0Cj4g KysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdHUz LnR4dAo+IEBAIC0yNyw3ICsyNyw5IEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6Cj4gICAtIHJhbmdl cyA6IGFsbG93cyB2YWxpZCAxOjEgdHJhbnNsYXRpb24gYmV0d2VlbiBjaGlsZCdzIGFkZHJlc3Mg c3BhY2UgYW5kCj4gIAlwYXJlbnQncyBhZGRyZXNzIHNwYWNlCj4gICAtIGV4dGNvbiA6IGV4dGVy bmFsIGNvbm5lY3RvciBmb3IgdmJ1cyBhbmQgaWRwaW4gY2hhbmdlcyBkZXRlY3Rpb24sIG5lZWRl ZAo+IC0Jd2hlbiBzdXBwb3J0cyBkdWFsLXJvbGUgbW9kZS4KPiArCXdoZW4gc3VwcG9ydHMgZHVh bC1yb2xlIG1vZGU7IGl0J3MgY29uc2llZGVyZWQgdmFsaWQgZm9yIGNvbXBhdGliaWxpdHkKPiAr CXJlYXNvbnMsIGFuZCBub3QgYWxsb3dlZCBmb3IgbmV3IGJpbmRpbmdzLCB1c2UgdGhlIHByb3Bl cnR5Cj4gKwl1c2Itcm9sZS1zd2l0Y2ggaW5zdGVhZC4KPiAgIC0gdmJ1cy1zdXBwbHkgOiByZWZl cmVuY2UgdG8gdGhlIFZCVVMgcmVndWxhdG9yLCBuZWVkZWQgd2hlbiBzdXBwb3J0cwo+ICAJZHVh bC1yb2xlIG1vZGUuCj4gICAtIHBpbmN0cmwtbmFtZXMgOiBhIHBpbmN0cmwgc3RhdGUgbmFtZWQg ImRlZmF1bHQiIGlzIG9wdGlvbmFsLCBhbmQgbmVlZCBiZQo+IEBAIC0zNiw3ICszOCw4IEBAIE9w dGlvbmFsIHByb3BlcnRpZXM6Cj4gIAlpcyBub3Qgc2V0Lgo+ICAgLSBwaW5jdHJsLTAgOiBwaW4g Y29udHJvbCBncm91cAo+ICAJU2VlOiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv cGluY3RybC9waW5jdHJsLWJpbmRpbmdzLnR4dAo+IC0KPiArIC0gdXNiLXJvbGUtc3dpdGNoIDog dXNlIFVTQiBSb2xlIFN3aXRjaCB0byBzdXBwb3J0IGR1YWwtcm9sZSBzd2l0Y2gsIGJ1dAo+ICsJ bm90IGV4dGNvbgoKQ29vcmRpbmF0ZSB3aXRoIHRoZSBSZW5lc2FzIGFuZCBIaVNpbGljb24gZm9s a3MgaW1wbGVtZW50aW5nIHRoZSBzYW1lIAp0aGluZyBhbmQgcHV0IHRoaXMgaW4gYSBjb21tb24g c3BvdC4gSG93ZXZlciwgSSB0aGluayB0aGlzIHNob3VsZCBub3QgCmV2ZW4gYmUgbmVlZGVkIGFz IGtub3dpbmcgdGhlIGNvbnRyb2xsZXIgY2FwYWJpbGl0aWVzIChiYXNlZCBvbiB0aGUgCmNvbXBh dGlibGUpIGFuZCBrbm93aW5nIHRoZSB0eXBlIG9mIGNvbm5lY3RvciBzaG91bGQgYmUgZW5vdWdo IAppbmZvcm1hdGlvbiB0byB0ZWxsIHlvdSBpZiBkdWFsIHJvbGUgaXMgc3VwcG9ydGVkIG9yIG5v dC4KCj4gICAtIG1heGltdW0tc3BlZWQgOiB2YWxpZCBhcmd1bWVudHMgYXJlICJzdXBlci1zcGVl ZCIsICJoaWdoLXNwZWVkIiBhbmQKPiAgCSJmdWxsLXNwZWVkIjsgcmVmZXIgdG8gdXNiL2dlbmVy aWMudHh0Cj4gICAtIGVuYWJsZS1tYW51YWwtZHJkIDogc3VwcG9ydHMgbWFudWFsIGR1YWwtcm9s ZSBzd2l0Y2ggdmlhIGRlYnVnZnM7IHVzdWFsbHkKPiBAQCAtNjEsNiArNjQsOSBAQCBUaGUgeGhj aSBzaG91bGQgYmUgYWRkZWQgYXMgc3Vibm9kZSB0byBtdHUzIGFzIHNob3duIGluIHRoZSBmb2xs b3dpbmcgZXhhbXBsZQo+ICBpZiBob3N0IG1vZGUgaXMgZW5hYmxlZC4gVGhlIERUIGJpbmRpbmcg ZGV0YWlscyBvZiB4aGNpIGNhbiBiZSBmb3VuZCBpbjoKPiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL3VzYi9tZWRpYXRlayxtdGsteGhjaS50eHQKPiAgCj4gK1RoZSBwb3J0IHdv dWxkIGJlIGFkZGVkIGFzIHN1Ym5vZGUgaWYgdXNlIHVzYi1yb2xlLXN3aXRjaCBwcm9wZXJ0eQo+ ICsJc2VlIGdyYXBoLnR4dAo+ICsKPiAgRXhhbXBsZToKPiAgc3N1c2I6IHVzYkAxMTI3MTAwMCB7 Cj4gIAljb21wYXRpYmxlID0gIm1lZGlhdGVrLG10ODE3My1tdHUzIjsKPiAtLSAKPiAyLjIxLjAK Pgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84158C43219 for ; Fri, 26 Apr 2019 20:49:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5503D20869 for ; Fri, 26 Apr 2019 20:49:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBZ98Hx1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5503D20869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LOh65C+xskemMZUCYPteWqp/nstagDvabBgxELVWR7U=; b=PBZ98Hx1tU4Vn/ VOsqFuLgAecbP2RZ0jmh7LO5KL/sMnuGIR58gPw3uAbAxRVmUevj3Y+nM/gXLIbddE1uosuuMYHCU oMZERY2v6F6XKJ/itxI3xrbNzmqwFvYjuSWNDfXYgvBTTPwnf8MzaEQImh26DcKJ+CAKD8iwLfVBZ EJ7sYTOgB5cG6RnRerqEUWsYFY+I6zEUuEFeURNVruK7EG83l3icskNLUqzaQkzPGLEPNg+ftE7Rg SjGBrATwIYn795DvNEtapoJ8PUSXFBimUXhb+jHQ2PlyXjdhAypY3VXkVcVhVZB7fPAFlyW9to6nt Qbx+2Q1JfHmKbNUPllLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK7mR-0005d3-TR; Fri, 26 Apr 2019 20:49:11 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK7mO-0005cb-Rm; Fri, 26 Apr 2019 20:49:10 +0000 Received: by mail-ot1-f67.google.com with SMTP id m10so3822511otp.2; Fri, 26 Apr 2019 13:49:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yT/XON//WSgEMOVSZqw0Vzpd9+7PVH4HBAL475bgyVk=; b=JeQ0K5rrp87gin4e5ZsSW/eC5n9/UaDTMXqNC+BlEg87Gfno8JKeH1F+8ApH9eTc8g dUqVR+fhqhjQ/eo2xo3aeMM/PDthSmrOAq4suQlho2Mric/DvanvUSZD5f14uNHRI30c BzAc3A3K10NZOkT/q0tv80SSa9PvbFbElazRQcVa7M+dWV25TLfmZzX2nl2wTEaYqpr0 PbgrAubjwG+cesohbxT/yb1CqFWVgvZD/VJhLoozysxBbp/k6xO7fIWhG9+qZ0ZfFDnj ASQ35NBL73qtmjwPgemqxnnB8FjbyQekcBkvsbpVd+B/weYvQLtngOgyJqromwdv6R19 XIAA== X-Gm-Message-State: APjAAAW641SOoEIsZwENSBVawBpQtHSpJBv7wIDuFjYZWeUQB2u1X4iJ osRK5DItRk8TDKADWO9Ujw== X-Google-Smtp-Source: APXvYqzdJ/lqbNb65m2fPe6L55tRE2fIx1i7+lvYj2VUlr2QLQ5aXA5+va67yIwicppYidXubf3CLw== X-Received: by 2002:a9d:1b70:: with SMTP id l103mr4240966otl.165.1556311747844; Fri, 26 Apr 2019 13:49:07 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l23sm2648517otr.81.2019.04.26.13.49.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 13:49:07 -0700 (PDT) Date: Fri, 26 Apr 2019 15:49:06 -0500 From: Rob Herring To: Chunfeng Yun Subject: Re: [PATCH v4 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch Message-ID: <20190426204906.GB15074@bogus> References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_134908_895634_94CCFAB1 X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Hans de Goede , Greg Kroah-Hartman , Linus Walleij , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Badhri Jagan Sridharan , Andy Shevchenko , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 26, 2019 at 02:47:14PM +0800, Chunfeng Yun wrote: > Now the USB Role Switch is supported, so add properties about it > > Signed-off-by: Chunfeng Yun > --- > v4: no changes > v3: no changes > > v2 changes: > 1. fix typo > 2. refer new binding about connector property > --- > .../devicetree/bindings/usb/mediatek,mtu3.txt | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > index 3382b5cb471d..6e004c4a89af 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > @@ -27,7 +27,9 @@ Optional properties: > - ranges : allows valid 1:1 translation between child's address space and > parent's address space > - extcon : external connector for vbus and idpin changes detection, needed > - when supports dual-role mode. > + when supports dual-role mode; it's consiedered valid for compatibility > + reasons, and not allowed for new bindings, use the property > + usb-role-switch instead. > - vbus-supply : reference to the VBUS regulator, needed when supports > dual-role mode. > - pinctrl-names : a pinctrl state named "default" is optional, and need be > @@ -36,7 +38,8 @@ Optional properties: > is not set. > - pinctrl-0 : pin control group > See: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > - > + - usb-role-switch : use USB Role Switch to support dual-role switch, but > + not extcon Coordinate with the Renesas and HiSilicon folks implementing the same thing and put this in a common spot. However, I think this should not even be needed as knowing the controller capabilities (based on the compatible) and knowing the type of connector should be enough information to tell you if dual role is supported or not. > - maximum-speed : valid arguments are "super-speed", "high-speed" and > "full-speed"; refer to usb/generic.txt > - enable-manual-drd : supports manual dual-role switch via debugfs; usually > @@ -61,6 +64,9 @@ The xhci should be added as subnode to mtu3 as shown in the following example > if host mode is enabled. The DT binding details of xhci can be found in: > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > +The port would be added as subnode if use usb-role-switch property > + see graph.txt > + > Example: > ssusb: usb@11271000 { > compatible = "mediatek,mt8173-mtu3"; > -- > 2.21.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel