From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, agross@kernel.org,
david.brown@linaro.org, lee.jones@linaro.org,
dmitry.torokhov@gmail.com, jikos@kernel.org,
benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: Add Lenovo Miix 630
Date: Fri, 26 Apr 2019 21:42:45 -0700 [thread overview]
Message-ID: <20190427044245.GD3137@builder> (raw)
In-Reply-To: <20190415161115.16466-1-jeffrey.l.hugo@gmail.com>
On Mon 15 Apr 09:11 PDT 2019, Jeffrey Hugo wrote:
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi b/arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi
[..]
> + thermal-zones {
> + battery-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <1000>;
> +
> + thermal-sensors = <&tsens0 0>;
I guess you inherited the battery and skin thermal nodes from my MTP
dts. Unfortunately after talking to Amit I think I got these wrong, and
they should be &pmi8998_adc 0 and 5 instead.
Can you confirm this?
> +
> + trips {
> + battery_crit: trip0 {
> + temperature = <60000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
Regards,
Bjorn
next prev parent reply other threads:[~2019-04-27 4:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 16:09 [PATCH v3 0/3] Basic DT support for Lenovo Miix 630 Jeffrey Hugo
2019-04-15 16:09 ` Jeffrey Hugo
2019-04-15 16:10 ` [PATCH v3 1/3] dt-bindings: input: add Elan 400 combo keyboard/touchpad over i2c Jeffrey Hugo
2019-04-18 9:35 ` Benjamin Tissoires
2019-04-26 22:49 ` Rob Herring
2019-04-29 15:15 ` Jeffrey Hugo
2019-04-15 16:11 ` [PATCH v3 2/3] HID: quirks: Fix keyboard + touchpad on Lenovo Miix 630 for DT Jeffrey Hugo
2019-04-18 9:34 ` Benjamin Tissoires
2019-04-18 9:51 ` Hans de Goede
2019-04-18 14:43 ` Jeffrey Hugo
2019-04-15 16:11 ` [PATCH v3 3/3] arm64: dts: qcom: Add Lenovo Miix 630 Jeffrey Hugo
2019-04-27 4:42 ` Bjorn Andersson [this message]
2019-04-29 15:16 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427044245.GD3137@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeffrey.l.hugo@gmail.com \
--cc=jikos@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.