From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Jeffrey Hugo <jhugo@codeaurora.org>,
Andy Gross <agross@kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
gpio <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v1] arm64: dts: qcom: msm8998: Add i2c5 pins
Date: Fri, 26 Apr 2019 21:51:51 -0700 [thread overview]
Message-ID: <20190427045151.GE3137@builder> (raw)
In-Reply-To: <ed5b1b55-285a-1c6d-c562-a965119000a5@free.fr>
On Thu 25 Apr 09:06 PDT 2019, Marc Gonzalez wrote:
> Downstream source:
> https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8998-pinctrl.dtsi?h=LE.UM.1.3.r3.25#n165
>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
> arch/arm64/boot/dts/qcom/msm8998-pins.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> index 6db70acd38ee..d0a95c70d1e7 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi
> @@ -2,6 +2,13 @@
> /* Copyright (c) 2018, The Linux Foundation. All rights reserved. */
>
> &tlmm {
> + i2c5_default: i2c5_default {
You need to reference this node for it to make a difference. Also the
drive-strength and bias are board specific, so please move this to your
board dts (and reference the node).
Regards,
Bjorn
> + pins = "gpio87", "gpio88";
> + function = "blsp_i2c5";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> sdc2_clk_on: sdc2_clk_on {
> config {
> pins = "sdc2_clk";
> --
> 2.17.1
next prev parent reply other threads:[~2019-04-27 4:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 16:06 [PATCH v1] arm64: dts: qcom: msm8998: Add i2c5 pins Marc Gonzalez
2019-04-27 4:51 ` Bjorn Andersson [this message]
2019-04-29 8:38 ` Marc Gonzalez
2019-05-02 15:12 ` Bjorn Andersson
2019-06-26 16:20 ` Marc Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427045151.GE3137@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.