From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E71DC43219 for ; Sat, 27 Apr 2019 13:30:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69EC2208CB for ; Sat, 27 Apr 2019 13:30:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lU+uEiGJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VE/IsNN+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69EC2208CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xIgEB8GJL+XjGqwPK4sGDjlmUiIxdd68KM61Tu2e24k=; b=lU+uEiGJsbUNBz 9fGBv+0qmODXn0csoD6tJrCHGAa9I3bgm6TeQ80m6SdrQ9pIoouEMNQEJUAlwWAUocN3Ep7E/f/+s 99crR2siLl9LJwFoP2Rsy9cRocsuSlr3WV4F7KEKYbH3P2VbvRB0VqQXgSwQ1xj/vQFsVfL97vpiu 7FUpRcqk3fAUAcD8xaOoTm78wZieE3K2V/P8MOo3sw1suuS2oj8JmxmS5Js7iRuo+uhYGV5SnhXNQ Jj7yBrFl9GRInIBUg7D1YMmTwOoUy9tvodd7jjk2PVyPloJGgWUezUTWbReizmlgOrqZfchGtDIh6 hOFAFw7obpALDfpbuhdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKNPr-00085f-Kv; Sat, 27 Apr 2019 13:30:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKNPp-000855-5Q for linux-amlogic@lists.infradead.org; Sat, 27 Apr 2019 13:30:54 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A4682087F; Sat, 27 Apr 2019 13:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556371852; bh=Lh9s0O0+A8sPU7fyQWvhROtRxYQ2VDabkJlyUvL7sek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VE/IsNN+OoggOL0lqnbBMENjYjQMHUlg6MzRjzd1wN8UG2ch8tWXwwllPaD6PTYFn mCF1UqTTSxvOfCSi55yzLfekiXXAcF44HsZlZXG4txLN8xZgDjNdx2St37NOCVhQjx TD6zDEh5JrUi3h2KNNgGkeyXD0aOAtKHV/ga5/ng= Date: Sat, 27 Apr 2019 15:30:50 +0200 From: Greg KH To: "Enrico Weigelt, metux IT consult" Subject: Re: [PATCH 05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk() Message-ID: <20190427133050.GB11368@kroah.com> References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-6-git-send-email-info@metux.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1556369542-13247-6-git-send-email-info@metux.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190427_063053_225974_70FF17A2 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, lorenzo.pieralisi@arm.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, andrew@aj.id.au, khilman@baylibre.com, sudeep.holla@arm.com, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, vz@mleia.com, linux@prisktech.co.nz, sparclinux@vger.kernel.org, macro@linux-mips.org, slemieux.tyco@gmail.com, matthias.bgg@gmail.com, jacmet@sunsite.dk, linux-amlogic@lists.infradead.org, andriy.shevchenko@linux.intel.com, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, Apr 27, 2019 at 02:51:46PM +0200, Enrico Weigelt, metux IT consult wrote: > Fix the checkpatch warning: > > WARNING: printk() should include KERN_ facility level > #934: FILE: dz.c:934: > + printk("%s%s\n", dz_name, dz_version); > > Signed-off-by: Enrico Weigelt > --- > drivers/tty/serial/dz.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/dz.c b/drivers/tty/serial/dz.c > index 559d076..e2670c4 100644 > --- a/drivers/tty/serial/dz.c > +++ b/drivers/tty/serial/dz.c > @@ -931,7 +931,7 @@ static int __init dz_init(void) > if (IOASIC) > return -ENXIO; > > - printk("%s%s\n", dz_name, dz_version); > + pr_info("%s%s\n", dz_name, dz_version); Just drop this line, it's not needed and generally just noise. thanks, greg k-h _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Sat, 27 Apr 2019 13:30:50 +0000 Subject: Re: [PATCH 05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk() Message-Id: <20190427133050.GB11368@kroah.com> List-Id: References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-6-git-send-email-info@metux.net> In-Reply-To: <1556369542-13247-6-git-send-email-info@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Enrico Weigelt, metux IT consult" Cc: linux-kernel@vger.kernel.org, andrew@aj.id.au, andriy.shevchenko@linux.intel.com, macro@linux-mips.org, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org On Sat, Apr 27, 2019 at 02:51:46PM +0200, Enrico Weigelt, metux IT consult wrote: > Fix the checkpatch warning: > > WARNING: printk() should include KERN_ facility level > #934: FILE: dz.c:934: > + printk("%s%s\n", dz_name, dz_version); > > Signed-off-by: Enrico Weigelt > --- > drivers/tty/serial/dz.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/dz.c b/drivers/tty/serial/dz.c > index 559d076..e2670c4 100644 > --- a/drivers/tty/serial/dz.c > +++ b/drivers/tty/serial/dz.c > @@ -931,7 +931,7 @@ static int __init dz_init(void) > if (IOASIC) > return -ENXIO; > > - printk("%s%s\n", dz_name, dz_version); > + pr_info("%s%s\n", dz_name, dz_version); Just drop this line, it's not needed and generally just noise. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C2D6C43219 for ; Sat, 27 Apr 2019 13:30:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DFAA208CB for ; Sat, 27 Apr 2019 13:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556371858; bh=Lh9s0O0+A8sPU7fyQWvhROtRxYQ2VDabkJlyUvL7sek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wTXQvm+DIyjU/kHhDx1b53SO6QRo1SXE+YsUW3fCdLq12flRY2ThlG6/obL2MGcjs QUj/tlqqNXLz0OGhPN1kKq4qCp9ipVL6+wW8d+DrpnZG42WmSsj1zp6AfiRZZzF3kk v8OKz9GZ5oOsIja7DIfWL0YDK+miaEaD3l3F7dgU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbfD0Nax (ORCPT ); Sat, 27 Apr 2019 09:30:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:36582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbfD0Nax (ORCPT ); Sat, 27 Apr 2019 09:30:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A4682087F; Sat, 27 Apr 2019 13:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556371852; bh=Lh9s0O0+A8sPU7fyQWvhROtRxYQ2VDabkJlyUvL7sek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VE/IsNN+OoggOL0lqnbBMENjYjQMHUlg6MzRjzd1wN8UG2ch8tWXwwllPaD6PTYFn mCF1UqTTSxvOfCSi55yzLfekiXXAcF44HsZlZXG4txLN8xZgDjNdx2St37NOCVhQjx TD6zDEh5JrUi3h2KNNgGkeyXD0aOAtKHV/ga5/ng= Date: Sat, 27 Apr 2019 15:30:50 +0200 From: Greg KH To: "Enrico Weigelt, metux IT consult" Cc: linux-kernel@vger.kernel.org, andrew@aj.id.au, andriy.shevchenko@linux.intel.com, macro@linux-mips.org, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: Re: [PATCH 05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk() Message-ID: <20190427133050.GB11368@kroah.com> References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-6-git-send-email-info@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556369542-13247-6-git-send-email-info@metux.net> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, Apr 27, 2019 at 02:51:46PM +0200, Enrico Weigelt, metux IT consult wrote: > Fix the checkpatch warning: > > WARNING: printk() should include KERN_ facility level > #934: FILE: dz.c:934: > + printk("%s%s\n", dz_name, dz_version); > > Signed-off-by: Enrico Weigelt > --- > drivers/tty/serial/dz.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/dz.c b/drivers/tty/serial/dz.c > index 559d076..e2670c4 100644 > --- a/drivers/tty/serial/dz.c > +++ b/drivers/tty/serial/dz.c > @@ -931,7 +931,7 @@ static int __init dz_init(void) > if (IOASIC) > return -ENXIO; > > - printk("%s%s\n", dz_name, dz_version); > + pr_info("%s%s\n", dz_name, dz_version); Just drop this line, it's not needed and generally just noise. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B6C7C43219 for ; Sat, 27 Apr 2019 14:30:51 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CB20208CA for ; Sat, 27 Apr 2019 14:30:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VE/IsNN+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CB20208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44rtd46PfRzDqTP for ; Sun, 28 Apr 2019 00:30:48 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="VE/IsNN+"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44rsJ00LbwzDqcl for ; Sat, 27 Apr 2019 23:30:55 +1000 (AEST) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A4682087F; Sat, 27 Apr 2019 13:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556371852; bh=Lh9s0O0+A8sPU7fyQWvhROtRxYQ2VDabkJlyUvL7sek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VE/IsNN+OoggOL0lqnbBMENjYjQMHUlg6MzRjzd1wN8UG2ch8tWXwwllPaD6PTYFn mCF1UqTTSxvOfCSi55yzLfekiXXAcF44HsZlZXG4txLN8xZgDjNdx2St37NOCVhQjx TD6zDEh5JrUi3h2KNNgGkeyXD0aOAtKHV/ga5/ng= Date: Sat, 27 Apr 2019 15:30:50 +0200 From: Greg KH To: "Enrico Weigelt, metux IT consult" Subject: Re: [PATCH 05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk() Message-ID: <20190427133050.GB11368@kroah.com> References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-6-git-send-email-info@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556369542-13247-6-git-send-email-info@metux.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, lorenzo.pieralisi@arm.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, andrew@aj.id.au, khilman@baylibre.com, sudeep.holla@arm.com, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, vz@mleia.com, linux@prisktech.co.nz, sparclinux@vger.kernel.org, macro@linux-mips.org, slemieux.tyco@gmail.com, matthias.bgg@gmail.com, jacmet@sunsite.dk, linux-amlogic@lists.infradead.org, andriy.shevchenko@linux.intel.com, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Apr 27, 2019 at 02:51:46PM +0200, Enrico Weigelt, metux IT consult wrote: > Fix the checkpatch warning: > > WARNING: printk() should include KERN_ facility level > #934: FILE: dz.c:934: > + printk("%s%s\n", dz_name, dz_version); > > Signed-off-by: Enrico Weigelt > --- > drivers/tty/serial/dz.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/dz.c b/drivers/tty/serial/dz.c > index 559d076..e2670c4 100644 > --- a/drivers/tty/serial/dz.c > +++ b/drivers/tty/serial/dz.c > @@ -931,7 +931,7 @@ static int __init dz_init(void) > if (IOASIC) > return -ENXIO; > > - printk("%s%s\n", dz_name, dz_version); > + pr_info("%s%s\n", dz_name, dz_version); Just drop this line, it's not needed and generally just noise. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Sat, 27 Apr 2019 13:30:50 +0000 Subject: Re: [PATCH 05/41] drivers: tty: serial: dz: use pr_info() instead of incomplete printk() Message-Id: <20190427133050.GB11368@kroah.com> List-Id: References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-6-git-send-email-info@metux.net> In-Reply-To: <1556369542-13247-6-git-send-email-info@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Enrico Weigelt, metux IT consult" Cc: linux-ia64@vger.kernel.org, lorenzo.pieralisi@arm.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, andrew@aj.id.au, khilman@baylibre.com, sudeep.holla@arm.com, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, vz@mleia.com, linux@prisktech.co.nz, sparclinux@vger.kernel.org, macro@linux-mips.org, slemieux.tyco@gmail.com, matthias.bgg@gmail.com, jacmet@sunsite.dk, linux-amlogic@lists.infradead.org, andriy.shevchenko@linux.intel.com, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net On Sat, Apr 27, 2019 at 02:51:46PM +0200, Enrico Weigelt, metux IT consult wrote: > Fix the checkpatch warning: > > WARNING: printk() should include KERN_ facility level > #934: FILE: dz.c:934: > + printk("%s%s\n", dz_name, dz_version); > > Signed-off-by: Enrico Weigelt > --- > drivers/tty/serial/dz.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/dz.c b/drivers/tty/serial/dz.c > index 559d076..e2670c4 100644 > --- a/drivers/tty/serial/dz.c > +++ b/drivers/tty/serial/dz.c > @@ -931,7 +931,7 @@ static int __init dz_init(void) > if (IOASIC) > return -ENXIO; > > - printk("%s%s\n", dz_name, dz_version); > + pr_info("%s%s\n", dz_name, dz_version); Just drop this line, it's not needed and generally just noise. thanks, greg k-h