From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Gomez <dagmcr@gmail.com>
Cc: Stefan Popa <stefan.popa@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
linux-kernel@vger.kernel.org (open list),
javier@dowhile0.org
Subject: Re: [PATCH v2] iio: adxl372: declare missing of table
Date: Sat, 27 Apr 2019 13:57:52 +0100 [thread overview]
Message-ID: <20190427135752.29d41c8b@archlinux> (raw)
In-Reply-To: <1556055697-14723-1-git-send-email-dagmcr@gmail.com>
On Tue, 23 Apr 2019 23:41:37 +0200
Daniel Gomez <dagmcr@gmail.com> wrote:
> Add missing <of_device_id> table for SPI driver relying on SPI
> device match since compatible is in a DT binding or in a DTS.
>
> Before this patch:
> modinfo drivers/iio/accel/adxl372_spi.ko | grep alias
>
> After this patch:
> modinfo drivers/iio/accel/adxl372_spi.ko | grep alias
> alias: spi:adxl372
> alias: of:N*T*Cadi,adxl372C*
> alias: of:N*T*Cadi,adxl372
>
> Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/accel/adxl372_spi.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/iio/accel/adxl372_spi.c b/drivers/iio/accel/adxl372_spi.c
> index e14e655..3ef7e3a 100644
> --- a/drivers/iio/accel/adxl372_spi.c
> +++ b/drivers/iio/accel/adxl372_spi.c
> @@ -7,6 +7,8 @@
>
> #include <linux/module.h>
> #include <linux/regmap.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> #include <linux/spi/spi.h>
>
> #include "adxl372.h"
> @@ -37,9 +39,16 @@ static const struct spi_device_id adxl372_spi_id[] = {
> };
> MODULE_DEVICE_TABLE(spi, adxl372_spi_id);
>
> +static const struct of_device_id adxl372_of_match[] = {
> + { .compatible = "adi,adxl372" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, adxl372_of_match);
> +
> static struct spi_driver adxl372_spi_driver = {
> .driver = {
> .name = "adxl372_spi",
> + .of_match_table = adxl372_of_match,
> },
> .probe = adxl372_spi_probe,
> .id_table = adxl372_spi_id,
prev parent reply other threads:[~2019-04-27 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 21:41 [PATCH v2] iio: adxl372: declare missing of table Daniel Gomez
2019-04-27 12:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427135752.29d41c8b@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=dagmcr@gmail.com \
--cc=javier@dowhile0.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.