All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: alsa-devel@alsa-project.org
Cc: Petr Nosek <petr.nosek@gmail.com>
Subject: [PATCH] ALSA: hda/realtek: Enable internal speaker of ASUS UX362FA with ALC294
Date: Sat, 27 Apr 2019 19:54:41 +0200	[thread overview]
Message-ID: <20190427175441.GA21587@lenoch> (raw)
In-Reply-To: <CAAqJ6B_FQK=nPHsxwOq4c0YsoBrxaX7gD0QC0L1T0cUVwcAmTw@mail.gmail.com>

The ASUS UX362FA with ALC294 cannot detect the outputs through the
internal speaker until ALC294_FIXUP_ASUS_SPK quirk applied.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=203443
Suggested-by: Petr Nosek <petr.nosek@gmail.com>
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 Hi Petr,

 I tried to verify information in your patch, but all links you provided
 are unpleasant to read and you also didn't provide bootlog, so I had to
 trust you that your machine comes with ALC294...
 Also, does it fix internal speaker only or also headphones? We need to
 get commit log right. Once verified, let's send v2 of this patch with
 your Tested-by tag and posibly Cc: stable. Thank you.

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 070749b50eff..490b42e3e3dc 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6896,6 +6896,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x12f0, "ASUS X541UV", ALC256_FIXUP_ASUS_MIC),
 	SND_PCI_QUIRK(0x1043, 0x12e0, "ASUS X541SA", ALC256_FIXUP_ASUS_MIC),
 	SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", ALC256_FIXUP_ASUS_MIC),
+	SND_PCI_QUIRK(0x1043, 0x13e1, "ASUS UX362FA", ALC294_FIXUP_ASUS_SPK),
 	SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_ASUS_ZENBOOK),
 	SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
 	SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
-- 
2.20.1

  reply	other threads:[~2019-04-27 17:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-27 15:07 no sound in laptop ASUS UX362FA - repair Petr Nosek
2019-04-27 17:54 ` Ladislav Michl [this message]
     [not found]   ` <CAAqJ6B9oWkpiXypV7UN-wqh9=YdAD-c-376GkcrHyXVsqqeBtw@mail.gmail.com>
2019-04-28  7:33     ` [PATCH] ALSA: hda/realtek: Enable internal speaker of ASUS UX362FA with ALC294 Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190427175441.GA21587@lenoch \
    --to=ladis@linux-mips.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=petr.nosek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.