From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Jacek Anaszewski
<jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org,
linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Thinkpad ACPI led -- it keeps blinking
Date: Sun, 28 Apr 2019 00:32:08 +0200 [thread overview]
Message-ID: <20190427223207.GA3585@amd> (raw)
In-Reply-To: <2578a614-beb9-1c9d-9f74-208a8a7ab64f-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 912 bytes --]
Hi!
This fixes one problem:
Pavel
Signed-off-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
index e3da7c0..d795d8f 100644
--- a/drivers/leds/led-core.c
+++ b/drivers/leds/led-core.c
@@ -164,8 +164,14 @@ static void led_blink_setup(struct led_classdev *led_cdev,
unsigned long *delay_on,
unsigned long *delay_off)
{
+ while (work_pending(&led_cdev->set_brightness_work)) {
+ printk("Waiting for brightness set to finish\n");
+ schedule();
+ }
+
if (!test_bit(LED_BLINK_ONESHOT, &led_cdev->work_flags) &&
led_cdev->blink_set &&
+ /* This can sleep */
!led_cdev->blink_set(led_cdev, delay_on, delay_off))
return;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
[-- Attachment #3: Type: text/plain, Size: 201 bytes --]
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
next prev parent reply other threads:[~2019-04-27 22:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 12:35 Thinkpad ACPI led -- it keeps blinking Pavel Machek
2019-04-26 18:22 ` Jacek Anaszewski
2019-04-26 21:42 ` Pavel Machek
2019-04-27 16:55 ` Jacek Anaszewski
[not found] ` <84fac57d-1121-a1da-fb45-16a2521bdef9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-27 19:34 ` Pavel Machek
2019-04-27 20:35 ` Jacek Anaszewski
[not found] ` <2578a614-beb9-1c9d-9f74-208a8a7ab64f-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-27 21:45 ` Pavel Machek
2019-04-27 22:16 ` Pavel Machek
2019-04-27 22:32 ` Pavel Machek [this message]
2019-04-28 12:02 ` Jacek Anaszewski
[not found] ` <d2373c8b-5c66-c875-16c7-0c5a93470793-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-04-29 12:52 ` Pavel Machek
2019-04-29 15:21 ` [PATCH] leds: tpacpi: cleanup for Thinkpad ACPI led Pavel Machek
2019-05-06 15:20 ` Andy Shevchenko
2019-04-29 15:22 ` [PATCH] leds: avoid races with workqueue Pavel Machek
2019-05-01 16:41 ` Jacek Anaszewski
[not found] ` <36e1fdd7-a220-4b0d-d558-829f522b0841-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-05-01 18:36 ` Pavel Machek
2019-05-02 18:29 ` Jacek Anaszewski
[not found] ` <9337b5fb-0ff8-9925-29e6-a781884af861-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-05-02 19:13 ` Pavel Machek
2019-05-02 19:28 ` Jacek Anaszewski
[not found] ` <62a99fe8-5c61-c681-3f9d-54e0a27a63d2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-05-02 20:06 ` Pavel Machek
2019-05-02 21:02 ` Jacek Anaszewski
[not found] ` <564697f8-ad02-6933-56e8-b3b19053d63d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-05-02 22:16 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427223207.GA3585@amd \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org \
--cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.