From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] sound: USB: line6: use dynamic buffers Date: Sun, 28 Apr 2019 19:07:45 +0200 Message-ID: <20190428170745.GA19070@kroah.com> References: <20190428160411.GA12815@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Takashi Iwai Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Sun, Apr 28, 2019 at 06:42:10PM +0200, Takashi Iwai wrote: > On Sun, 28 Apr 2019 18:04:11 +0200, > Greg Kroah-Hartman wrote: > > > > --- a/sound/usb/line6/toneport.c > > +++ b/sound/usb/line6/toneport.c > > @@ -365,16 +365,21 @@ static bool toneport_has_source_select(s > > /* > > Setup Toneport device. > > */ > > -static void toneport_setup(struct usb_line6_toneport *toneport) > > +static int toneport_setup(struct usb_line6_toneport *toneport) > > { > > - u32 ticks; > > + u32 *ticks; > > struct usb_line6 *line6 = &toneport->line6; > > struct usb_device *usbdev = line6->usbdev; > > > > + ticks = kmalloc(sizeof(*ticks), GFP_KERNEL); > > + if (!ticks) > > + return -ENOMEM; > > + > > /* sync time on device with host: */ > > /* note: 32-bit timestamps overflow in year 2106 */ > > - ticks = (u32)ktime_get_real_seconds(); > > - line6_write_data(line6, 0x80c6, &ticks, 4); > > + *ticks = (u32)ktime_get_real_seconds(); > > + line6_write_data(line6, 0x80c6, ticks, 4); > > + kfree(ticks); > > > > /* enable device: */ > > toneport_send_cmd(usbdev, 0x0301, 0x0000); > > This function misses the "return 0" at the end, so I fixed it up > manually and applied now. Ugh, sorry about that. Odd I didn't get a build error, my fault. thanks for the quick response. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: sound: USB: line6: use dynamic buffers From: Greg Kroah-Hartman Message-Id: <20190428170745.GA19070@kroah.com> Date: Sun, 28 Apr 2019 19:07:45 +0200 To: Takashi Iwai Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gU3VuLCBBcHIgMjgsIDIwMTkgYXQgMDY6NDI6MTBQTSArMDIwMCwgVGFrYXNoaSBJd2FpIHdy b3RlOgo+IE9uIFN1biwgMjggQXByIDIwMTkgMTg6MDQ6MTEgKzAyMDAsCj4gR3JlZyBLcm9haC1I YXJ0bWFuIHdyb3RlOgo+ID4gCj4gPiAtLS0gYS9zb3VuZC91c2IvbGluZTYvdG9uZXBvcnQuYwo+ ID4gKysrIGIvc291bmQvdXNiL2xpbmU2L3RvbmVwb3J0LmMKPiA+IEBAIC0zNjUsMTYgKzM2NSwy MSBAQCBzdGF0aWMgYm9vbCB0b25lcG9ydF9oYXNfc291cmNlX3NlbGVjdChzCj4gPiAgLyoKPiA+ ICAJU2V0dXAgVG9uZXBvcnQgZGV2aWNlLgo+ID4gICovCj4gPiAtc3RhdGljIHZvaWQgdG9uZXBv cnRfc2V0dXAoc3RydWN0IHVzYl9saW5lNl90b25lcG9ydCAqdG9uZXBvcnQpCj4gPiArc3RhdGlj IGludCB0b25lcG9ydF9zZXR1cChzdHJ1Y3QgdXNiX2xpbmU2X3RvbmVwb3J0ICp0b25lcG9ydCkK PiA+ICB7Cj4gPiAtCXUzMiB0aWNrczsKPiA+ICsJdTMyICp0aWNrczsKPiA+ICAJc3RydWN0IHVz Yl9saW5lNiAqbGluZTYgPSAmdG9uZXBvcnQtPmxpbmU2Owo+ID4gIAlzdHJ1Y3QgdXNiX2Rldmlj ZSAqdXNiZGV2ID0gbGluZTYtPnVzYmRldjsKPiA+ICAKPiA+ICsJdGlja3MgPSBrbWFsbG9jKHNp emVvZigqdGlja3MpLCBHRlBfS0VSTkVMKTsKPiA+ICsJaWYgKCF0aWNrcykKPiA+ICsJCXJldHVy biAtRU5PTUVNOwo+ID4gKwo+ID4gIAkvKiBzeW5jIHRpbWUgb24gZGV2aWNlIHdpdGggaG9zdDog Ki8KPiA+ICAJLyogbm90ZTogMzItYml0IHRpbWVzdGFtcHMgb3ZlcmZsb3cgaW4geWVhciAyMTA2 ICovCj4gPiAtCXRpY2tzID0gKHUzMilrdGltZV9nZXRfcmVhbF9zZWNvbmRzKCk7Cj4gPiAtCWxp bmU2X3dyaXRlX2RhdGEobGluZTYsIDB4ODBjNiwgJnRpY2tzLCA0KTsKPiA+ICsJKnRpY2tzID0g KHUzMilrdGltZV9nZXRfcmVhbF9zZWNvbmRzKCk7Cj4gPiArCWxpbmU2X3dyaXRlX2RhdGEobGlu ZTYsIDB4ODBjNiwgdGlja3MsIDQpOwo+ID4gKwlrZnJlZSh0aWNrcyk7Cj4gPiAgCj4gPiAgCS8q IGVuYWJsZSBkZXZpY2U6ICovCj4gPiAgCXRvbmVwb3J0X3NlbmRfY21kKHVzYmRldiwgMHgwMzAx LCAweDAwMDApOwo+IAo+IFRoaXMgZnVuY3Rpb24gbWlzc2VzIHRoZSAicmV0dXJuIDAiIGF0IHRo ZSBlbmQsIHNvIEkgZml4ZWQgaXQgdXAKPiBtYW51YWxseSBhbmQgYXBwbGllZCBub3cuCgpVZ2gs IHNvcnJ5IGFib3V0IHRoYXQuICBPZGQgSSBkaWRuJ3QgZ2V0IGEgYnVpbGQgZXJyb3IsIG15IGZh dWx0LgoKdGhhbmtzIGZvciB0aGUgcXVpY2sgcmVzcG9uc2UuCgpncmVnIGstaAo=