All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH REPOST] random: Add a spinlock_t to struct batched_entropy
Date: Sun, 28 Apr 2019 14:29:28 -0400	[thread overview]
Message-ID: <20190428182928.GD24089@mit.edu> (raw)
In-Reply-To: <20190426103438.g5i5cexlatlgpije@linutronix.de>

On Fri, Apr 26, 2019 at 12:34:38PM +0200, Sebastian Andrzej Siewior wrote:
> The per-CPU variable batched_entropy_uXX is protected by get_cpu_var().
> This is just a preempt_disable() which protects against concurrent
> access from process context on the local CPU. It does not protect
> against users on the same CPU from another context. It is possible that
> a preemptible context reads slot 0 and then an interrupt occurs and the
> same value is read again from hard or soft IRQ context.

This patch is already on the random.git tree.  (It wasn't in
linux-next because I had forgotten that linux-next pulls from the dev
branch, as opposed to the master branch.)

Cheers,

					- Ted

  reply	other threads:[~2019-04-28 18:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 10:34 [PATCH REPOST] random: Add a spinlock_t to struct batched_entropy Sebastian Andrzej Siewior
2019-04-28 18:29 ` Theodore Ts'o [this message]
2019-04-30  9:02   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190428182928.GD24089@mit.edu \
    --to=tytso@mit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.