From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Amritha Nambiar <amritha.nambiar@intel.com>,
Willem de Bruijn <willemb@google.com>,
Kees Cook <keescook@chromium.org>,
Matthew Wilcox <willy@infradead.org>,
"Tobin C . Harding" <tobin@kernel.org>,
Will Deacon <will.deacon@arm.com>,
Miklos Szeredi <mszeredi@redhat.com>,
Vineet Gupta <vineet.gupta1@synopsys.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Yury Norov <ynorov@marvell.com>,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH 1/6] lib/string: add strnchrnul()
Date: Sun, 28 Apr 2019 22:22:50 +0300 [thread overview]
Message-ID: <20190428192250.GY9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190428182612.GA3150@yury-thinkpad>
On Sun, Apr 28, 2019 at 11:26:12AM -0700, Yury Norov wrote:
> On Sun, Apr 28, 2019 at 07:04:00PM +0300, Andy Shevchenko wrote:
> > On Sat, Apr 27, 2019 at 08:29:31PM -0700, Yury Norov wrote:
> > > New function works like strchrnul() with a length limited strings.
> >
> > The prototype better to be consistent with strchrnul() and memchr(), i.e.
> > the size parameter to go last.
>
> But if so it would be inconsistent with strnchr(). I'm OK to do the change,
> but I'm not sure if this version better than that.
Forgot to check it. In this case, yes, strnchr() + size.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-04-28 19:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 3:29 [PATCH 0/4] lib: rework bitmap_parse Yury Norov
2019-04-28 3:29 ` [PATCH 1/6] lib/string: add strnchrnul() Yury Norov
2019-04-28 16:04 ` Andy Shevchenko
2019-04-28 18:26 ` Yury Norov
2019-04-28 19:22 ` Andy Shevchenko [this message]
2019-04-28 18:58 ` Rasmus Villemoes
2019-04-28 3:29 ` [PATCH 2/6] bitops: more BITS_TO_* macros Yury Norov
2019-04-28 16:06 ` Andy Shevchenko
2019-04-28 3:29 ` [PATCH 3/6] lib/bitmap: make bitmap_parse_user a wrapper on bitmap_parse Yury Norov
2019-04-28 3:29 ` [PATCH 4/6] lib: rework bitmap_parse() Yury Norov
2019-04-28 16:57 ` Andy Shevchenko
2019-05-01 0:37 ` Yury Norov
2019-04-28 3:29 ` [PATCH 5/6] lib: add test for bitmap_parse() Yury Norov
2019-04-28 3:29 ` [PATCH 6/6] cpumask: don't calculate length of the input string Yury Norov
2019-04-28 15:40 ` [PATCH 0/4] lib: rework bitmap_parse Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190428192250.GY9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=acme@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amritha.nambiar@intel.com \
--cc=axboe@kernel.dk \
--cc=chris@chris-wilson.co.uk \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mszeredi@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=steffen.klassert@secunet.com \
--cc=tobin@kernel.org \
--cc=vineet.gupta1@synopsys.com \
--cc=will.deacon@arm.com \
--cc=willemb@google.com \
--cc=willy@infradead.org \
--cc=ynorov@marvell.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.