All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
	linux-ext4@vger.kernel.org,
	Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Subject: Re: [PATCH] debugfs: fix encoding handling in dx_hash command
Date: Sun, 28 Apr 2019 20:20:55 -0400	[thread overview]
Message-ID: <20190429002055.GE3789@mit.edu> (raw)
In-Reply-To: <85o94xs6tr.fsf@collabora.com>

On Tue, Apr 23, 2019 at 12:07:12AM -0400, Gabriel Krisman Bertazi wrote:
> Eric Biggers <ebiggers@kernel.org> writes:
> 
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Fix the following bugs:
> >
> > 1. 'encoding' and 'hash_flags' are not initialized, causing a segfault.
> >
> > 2. 'hash_flags' incorrectly uses a __bitwise type.
> >
> > 3. The optstring doesn't contain "c" or "e", so the -c and -e options
> >    aren't recognized.
> >
> > 4. The code that handles the -e option always returns.
> >
> 
> Ugly. Thanks for finding it.
> 
> Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>

Thanks, applied.

						- Ted

      reply	other threads:[~2019-04-29  0:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-22 21:01 [PATCH] debugfs: fix encoding handling in dx_hash command Eric Biggers
2019-04-23  4:07 ` Gabriel Krisman Bertazi
2019-04-29  0:20   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190429002055.GE3789@mit.edu \
    --to=tytso@mit.edu \
    --cc=ebiggers@kernel.org \
    --cc=krisman@collabora.co.uk \
    --cc=krisman@collabora.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.