From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm/i915/icl: Add Multi-segmented gamma support Date: Mon, 29 Apr 2019 14:49:52 +0300 Message-ID: <20190429114952.GA24299@intel.com> References: <20190426180151.30036-1-shashank.sharma@intel.com> <20190426180151.30036-3-shashank.sharma@intel.com> <20190426182903.GV24299@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 321C3892F0 for ; Mon, 29 Apr 2019 11:49:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Sharma, Shashank" Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBcHIgMjksIDIwMTkgYXQgMDU6MDA6MjFQTSArMDUzMCwgU2hhcm1hLCBTaGFzaGFu ayB3cm90ZToKPiAKPiBPbiA0LzI2LzIwMTkgMTE6NTkgUE0sIFZpbGxlIFN5cmrDpGzDpCB3cm90 ZToKPiA+IE9uIEZyaSwgQXByIDI2LCAyMDE5IGF0IDExOjMxOjUxUE0gKzA1MzAsIFNoYXNoYW5r IFNoYXJtYSB3cm90ZToKPiA+PiBJQ0wgaW50cm9kdWNlcyBhIG5ldyBnYW1tYSBjb3JyZWN0aW9u IG1vZGUgaW4gZGlzcGxheSBlbmdpbmUsIGNhbGxlZAo+ID4+IG11bHRpLXNlZ21lbnRlZC1nYW1t YSBtb2RlLiBUaGlzIG1vZGUgYWxsb3dzIHVzZXJzIHRvIHByb2dyYW0gdGhlCj4gPj4gZGFya2Vy IHJlZ2lvbiBvZiB0aGUgZ2FtbWEgY3VydmUgd2l0aCBzdWVwcmZpbmUgcHJlY2lzaW9uLiBBbgo+ ID4+IGV4YW1wbGUgdXNlIGNhc2UgZm9yIHRoaXMgaXMgSERSIGN1cnZlcyAobGlrZSBQUSBTVC0y MDg0KS4KPiA+Pgo+ID4+IElmIHdlIHBsb3QgYSBnYW1tYSBjb3JyZWN0aW9uIGN1cnZlIGZyb20g dmFsdWUgcmFuZ2UgYmV0d2VlbiAwLjAgdG8gMS4wLAo+ID4+IElDTCdzIG11bHRpLXNlZ21lbnQg aGFzIDMgZGlmZmVyZW50IHNlY3Rpb25zOgo+ID4+IC0gc3VwZXJmaW5lIHNlZ21lbnQ6IDkgdmFs dWVzLCByYW5nZXMgYmV0d2VlbiAwIC0gMS8oMTI4ICogMjU2KQo+ID4+IC0gZmluZSBzZWdtZW50 OiAyNTcgdmFsdWVzLCByYW5nZXMgYmV0d2VlbiAwIC0gMS8oMTI4KQo+ID4+IC0gY29yYXNlIHNl Z21lbnQ6IDI1NyB2YWx1ZXMsIHJhbmdlcyBiZXR3ZWVuIDAgLSAxCj4gPj4KPiA+PiBUaGlzIHBh dGNoOgo+ID4+IC0gQ2hhbmdlcyBnYW1tYSBMVVRzIHNpemUgZm9yIElDTC9HRU4xMSB0byAyNjIx NDQgZW50cmllcyAoOCAqIDEyOCAqIDI1NiksCj4gPj4gICAgc28gdGhhdCB1c2Vyc3BhY2UgY2Fu IHByb2dyYW0gd2l0aCBoaWdoZXN0IHByZWNpc2lvbiBzdXBwb3J0ZWQuCj4gPj4gLSBDaGFuZ2Vz IGRlZmF1bHQgZ2FtbWEgbW9kZSAobm9uLWxlZ2FjeSkgdG8gbXVsdGktc2VnbWVudGVkLWdhbW1h IG1vZGUuCj4gPj4gLSBBZGRzIGZ1bmN0aW9ucyB0byBwcm9ncmFtL2RldGVjdCBtdWx0aS1zZWdt ZW50IGdhbW1hLgo+ID4+Cj4gPj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4gPj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmto b3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0 ZXJAZmZ3bGwuY2g+Cj4gPj4KPiA+PiBTdWdnZXN0ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPj4gU2lnbmVkLW9mZi1ieTogU2hhc2hhbmsg U2hhcm1hIDxzaGFzaGFuay5zaGFybWFAaW50ZWwuY29tPgo+ID4+IFNpZ25lZC1vZmYtYnk6IFVt YSBTaGFua2FyIDx1bWEuc2hhbmthckBpbnRlbC5jb20+Cj4gPj4gLS0tCj4gPj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jICAgIHwgICAzICstCj4gPj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9jb2xvci5jIHwgMTU1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKyst Cj4gPj4gICAyIGZpbGVzIGNoYW5nZWQsIDE1NiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jCj4gPj4gaW5kZXggZmZhMmVlNzBhMDNk Li44MzY5ODk1MTc2MGIgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9wY2kuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiA+PiBA QCAtNzQ5LDcgKzc0OSw4IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaW50ZWxfZGV2aWNlX2luZm8g aW50ZWxfY2Fubm9ubGFrZV9pbmZvID0gewo+ID4+ICAgCUdFTigxMSksIFwKPiA+PiAgIAkuZGRi X3NpemUgPSAyMDQ4LCBcCj4gPj4gICAJLmhhc19sb2dpY2FsX3JpbmdfZWxzcSA9IDEsIFwKPiA+ PiAtCS5jb2xvciA9IHsgLmRlZ2FtbWFfbHV0X3NpemUgPSAzMywgLmdhbW1hX2x1dF9zaXplID0g MTAyNCB9Cj4gPj4gKwkuY29sb3IgPSB7IC5kZWdhbW1hX2x1dF9zaXplID0gMzMsIC5nYW1tYV9s dXRfc2l6ZSA9IDI2MjE0NCB9Cj4gPj4gKwo+ID4+ICAgCj4gPj4gICBzdGF0aWMgY29uc3Qgc3Ry dWN0IGludGVsX2RldmljZV9pbmZvIGludGVsX2ljZWxha2VfMTFfaW5mbyA9IHsKPiA+PiAgIAlH RU4xMV9GRUFUVVJFUywKPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfY29sb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiA+PiBpbmRl eCBjYTM0MWE5ZTQ3ZTYuLmQxZmI3OWE1ZDc2NCAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfY29sb3IuYwo+ID4+IEBAIC00MSw2ICs0MSw3IEBACj4gPj4gICAjZGVmaW5lIENUTV9D T0VGRl9BQlMoY29lZmYpCQkoKGNvZWZmKSAmIChDVE1fQ09FRkZfU0lHTiAtIDEpKQo+ID4+ICAg Cj4gPj4gICAjZGVmaW5lIExFR0FDWV9MVVRfTEVOR1RICQkyNTYKPiA+PiArI2RlZmluZSBJQ0xf TVVMVElTRUdfTFVUX0xFTkdUSAkJKDI1NiAqIDEyOCAqIDgpCj4gPj4gICAvKgo+ID4+ICAgICog RXh0cmFjdCB0aGUgQ1NDIGNvZWZmaWNpZW50IGZyb20gYSBDVE0gY29lZmZpY2llbnQgKGluIFUz Mi4zMiBmaXhlZCBwb2ludAo+ID4+ICAgICogZm9ybWF0KS4gVGhpcyBtYWNybyB0YWtlcyB0aGUg Y29lZmZpY2llbnQgd2Ugd2FudCB0cmFuc2Zvcm1lZCBhbmQgdGhlCj4gPj4gQEAgLTU4LDYgKzU5 LDEyIEBACj4gPj4gICAKPiA+PiAgICNkZWZpbmUgSUxLX0NTQ19QT1NUT0ZGX0xJTUlURURfUkFO R0UgKDE2ICogKDEgPDwgMTIpIC8gMjU1KQo+ID4+ICAgCj4gPj4gK2VudW0gaWNsX21zX2dhbW1h X3NlZ21lbnRzIHsKPiA+PiArCUlDTF9NU19HQU1NQV9TRUdfU1VQRVJGSU5FLAo+ID4+ICsJSUNM X01TX0dBTU1BX1NFR19GSU5FLAo+ID4+ICsJSUNMX01TX0dBTU1BX1NFR19DT0FSU0UsCj4gPj4g K307Cj4gPj4gKwo+ID4+ICAgc3RhdGljIGNvbnN0IHUxNiBpbGtfY3NjX29mZl96ZXJvWzNdID0g e307Cj4gPj4gICAKPiA+PiAgIHN0YXRpYyBjb25zdCB1MTYgaWxrX2NzY19jb2VmZl9pZGVudGl0 eVs5XSA9IHsKPiA+PiBAQCAtNzY3LDYgKzc3NCwxNDkgQEAgc3RhdGljIHZvaWQgZ2xrX2xvYWRf bHV0cyhjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+PiAgIAl9 Cj4gPj4gICB9Cj4gPj4gICAKPiA+PiArLyogaWxrKyAiMTIuNCIgaW50ZXJwb2xhdGVkIGZvcm1h dCAoaGlnaCAxMCBiaXRzKSAqLwo+ID4+ICtzdGF0aWMgdTMyIGlsa19sdXRfMTJwNF9sZHcoY29u c3Qgc3RydWN0IGRybV9jb2xvcl9sdXQgKmNvbG9yKQo+ID4+ICt7Cj4gPj4gKwlyZXR1cm4gKGNv bG9yLT5yZWQgPj4gNikgPDwgMjAgfCAoY29sb3ItPmdyZWVuID4+IDYpIDw8IDEwIHwKPiA+PiAr CQkoY29sb3ItPmJsdWUgPj4gNik7Cj4gPj4gK30KPiA+PiArCj4gPj4gKy8qIGlsaysgIjEyLjQi IGludGVycG9sYXRlZCBmb3JtYXQgKGxvdyA2IGJpdHMpICovCj4gPj4gK3N0YXRpYyB1MzIgaWxr X2x1dF8xMnA0X3Vkdyhjb25zdCBzdHJ1Y3QgZHJtX2NvbG9yX2x1dCAqY29sb3IpCj4gPj4gK3sK PiA+PiArCXJldHVybiAoY29sb3ItPnJlZCAmIDB4M2YpIDw8IDI0IHwgKGNvbG9yLT5ncmVlbiAm IDB4M2YpIDw8IDE0IHwKPiA+PiArCQkoY29sb3ItPmJsdWUgJiAweDNmKTsKPiA+PiArfQo+ID4+ ICsKPiA+PiArc3RhdGljIHZvaWQKPiA+PiAraWNsX3Byb2dyYW1fZ2FtbWFfZ2NtYXgoY29uc3Qg c3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gPj4gK3sKPiA+PiArCXN0cnVj dCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMp Owo+ID4+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRj LT5iYXNlLmRldik7Cj4gPj4gKwllbnVtIHBpcGUgcGlwZSA9IGNydGMtPnBpcGU7Cj4gPj4gKwo+ ID4+ICsJLyoKPiA+PiArCSAqIFByb2dyYW0gdGhlIG1heCByZWdpc3RlciB0byBjbGFtcCB2YWx1 ZXMgPiAxLjAuCj4gPj4gKwkgKiBUb0RvOiBFeHRlbmQgdGhlIEFCSSB0byBiZSBhYmxlIHRvIHBy b2dyYW0gdmFsdWVzCj4gPj4gKwkgKiBmcm9tIDEuMAo+ID4+ICsJICovCj4gPj4gKwlJOTE1X1dS SVRFKFBSRUNfUEFMX0dDX01BWChwaXBlLCAwKSwgKDEgPDwgMTYpKTsKPiA+PiArCUk5MTVfV1JJ VEUoUFJFQ19QQUxfR0NfTUFYKHBpcGUsIDEpLCAoMSA8PCAxNikpOwo+ID4+ICsJSTkxNV9XUklU RShQUkVDX1BBTF9HQ19NQVgocGlwZSwgMiksICgxIDw8IDE2KSk7Cj4gPiBUaGlzIG9uZSBJIHRo aW5rIHdlIHdhbnQgdG8gcHJvZ3JhbSBiYXNlZCBvbiB0aGUgcHJvdmlkZSBMVVQuIEl0J3MgdGhl Cj4gPiBsYXN0IGVudHJ5IHRoYXQgc3RpbGwgZ2V0cyB1c2VkIGluIGludGVycG9sYXRpb24gZm9y IDwxLjAgdmFsdWVzLgo+ID4gT3IgYXQgbGVhc3QgdGhhdCdzIHRoZSB3YXkgaXQgd29ya3Mgd2l0 aCB0aGUgMTJwNCBtb2RlIElJUkMuIEkgZG9uJ3QKPiA+IGFjdHVhbGx5IHJlbWVtYmVyIGhvdyBp dCBnb2VzIHdpdGggdGhlIG11bHRpIHNlZ21lbnQgbW9kZS4KPiBJIGFtIGEgYml0IHNrZXB0aWNh bCBpZiBpdHMgYSBnb29kIGlkZWEgdG8gcHJvZ3JhbSBmcm9tIHRoZSBMVVQsIGFzIHlvdSAKPiBr bm93LCB0aGUgZHJtX2NvbG9yX2x1dCBlbGVtZW50cyBhcmUgMTZiaXQgcGVyIGNoYW5uZWwsIGFu ZCBpbiBvcmRlciB0byAKPiBwcm9ncmFtIDEuMCB3ZSBuZWVkIDE3IGJpdHMuIFNvIGV2ZW4gaWYg dXNlcnNwYWNlIHdhbnRzLCBpdCBjYW50IHNldCB0aGUgCj4gdmFsdWUgb2YgMS4wIGFzIG9mIG5v dy4gQWxzbywgd291bGRuJ3QgaXQgd291bGQgYmUgZ29vZCBmb3IgdGhlIAo+IGludGVycG9sYXRp b24gdG8gaGF2ZSB0aGUgYWNjdXJhdGUgbWF4IHZhbHVlICgxLjApIG9mIHRoZSBjdXJ2ZSA/CgpJ ZiB1c2Vyc3BhY2UgZG9lc24ndCB3YW50IHRoZSBtYXggdG8gYmUgMS4wIHRoZW4gd2Ugd2lsbCBk byB0aGUgd3JvbmcKdGhpbmcgaGVyZS4gQnV0IEkgc3VwcG9zZSB0aGF0IHdvdWxkbid0IGJlIGEg dmVyeSBjb21tb24gdGhpbmcgdG8gZG8uClRoZSBiZXR0ZXIgYXJndWVtbnQgZm9yIGRvaW5nIHdo YXQgSSBzdWdnZXN0IGlzIHRoYXQgd2UgYWxyZWFkeSBkbyBpdApsaWtlIHRoYXQgb24gdGhlIG90 aGVyIHBsYXRmb3JtcyB3aXRoIGludGVycG9sYXRlZCBnYW1tYSAoZ2VuNC92bHYvY2h2KS4KCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4