From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AD1C004C9 for ; Mon, 29 Apr 2019 13:19:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 759C72084B for ; Mon, 29 Apr 2019 13:19:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WFlgR+7L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 759C72084B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g6dS6RqIh1WoYHHgwH/Asvskf8Hh91w9MYC66r7yosM=; b=WFlgR+7LY0KM6A EU7zCgQsB0k8IwDQs6WRgApYHiLOe30KbAUll2gU1tSSf/vENR4K4H/UbSCYc9M26am+uycH3nb5z F8ziUeKakLaAJCh40ywZcBAjzd4opvidn8yj+hScpUuUtNcnikOdgVY7VRlKY7Y5Rfse4O1dw94uq No6Ar5LAntGCGY7DRHE800ewYrMpE7FJ0Ve8qyK+GWL5JsoE7dmev2kjHmnWU/DW3ykqRxsx+qz9S p7f7c/aeF5ZJrcT9DhcAfe2lEojwDW5HNeDBUBE2/xB+xf3PGIuIcyj4gKoypy9hOjmR11nogs2v6 1vay0YmigvbpwiMuQ/7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hL6C6-0007eW-A9; Mon, 29 Apr 2019 13:19:42 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hL6C3-0007eA-9G for linux-amlogic@lists.infradead.org; Mon, 29 Apr 2019 13:19:40 +0000 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Apr 2019 06:19:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,409,1549958400"; d="scan'208";a="146675438" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga003.jf.intel.com with ESMTP; 29 Apr 2019 06:19:32 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hL6Bu-0008Ek-Oe; Mon, 29 Apr 2019 16:19:30 +0300 Date: Mon, 29 Apr 2019 16:19:30 +0300 From: Andy Shevchenko To: "Enrico Weigelt, metux IT consult" Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation Message-ID: <20190429131930.GE9224@smile.fi.intel.com> References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-38-git-send-email-info@metux.net> <20190428152103.GP9224@smile.fi.intel.com> <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190429_061939_370446_8D222875 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sparclinux@vger.kernel.org, lorenzo.pieralisi@arm.com, linux-ia64@vger.kernel.org, linux-serial@vger.kernel.org, andrew@aj.id.au, gregkh@linuxfoundation.org, sudeep.holla@arm.com, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, vz@mleia.com, linux@prisktech.co.nz, linuxppc-dev@lists.ozlabs.org, khilman@baylibre.com, macro@linux-mips.org, slemieux.tyco@gmail.com, matthias.bgg@gmail.com, jacmet@sunsite.dk, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, "Enrico Weigelt, metux IT consult" , davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE 0x100 > > > > And why this is in the header file and not in corresponding C one? > > hmm, no particular reason, maybe just an old habit to put definitions > into .h files ;-) > > I can move it to 8250_of.c if you like me to. Please, do. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Mon, 29 Apr 2019 13:19:30 +0000 Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation Message-Id: <20190429131930.GE9224@smile.fi.intel.com> List-Id: References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-38-git-send-email-info@metux.net> <20190428152103.GP9224@smile.fi.intel.com> <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> In-Reply-To: <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Enrico Weigelt, metux IT consult" Cc: "Enrico Weigelt, metux IT consult" , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, andrew@aj.id.au, macro@linux-mips.org, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE 0x100 > > > > And why this is in the header file and not in corresponding C one? > > hmm, no particular reason, maybe just an old habit to put definitions > into .h files ;-) > > I can move it to 8250_of.c if you like me to. Please, do. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7984CC43219 for ; Mon, 29 Apr 2019 13:19:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4ACDA2054F for ; Mon, 29 Apr 2019 13:19:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728210AbfD2NTj (ORCPT ); Mon, 29 Apr 2019 09:19:39 -0400 Received: from mga11.intel.com ([192.55.52.93]:25681 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbfD2NTj (ORCPT ); Mon, 29 Apr 2019 09:19:39 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Apr 2019 06:19:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,409,1549958400"; d="scan'208";a="146675438" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga003.jf.intel.com with ESMTP; 29 Apr 2019 06:19:32 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hL6Bu-0008Ek-Oe; Mon, 29 Apr 2019 16:19:30 +0300 Date: Mon, 29 Apr 2019 16:19:30 +0300 From: Andy Shevchenko To: "Enrico Weigelt, metux IT consult" Cc: "Enrico Weigelt, metux IT consult" , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, andrew@aj.id.au, macro@linux-mips.org, vz@mleia.com, slemieux.tyco@gmail.com, khilman@baylibre.com, liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, davem@davemloft.net, jacmet@sunsite.dk, linux@prisktech.co.nz, matthias.bgg@gmail.com, linux-mips@vger.kernel.org, linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation Message-ID: <20190429131930.GE9224@smile.fi.intel.com> References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-38-git-send-email-info@metux.net> <20190428152103.GP9224@smile.fi.intel.com> <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE 0x100 > > > > And why this is in the header file and not in corresponding C one? > > hmm, no particular reason, maybe just an old habit to put definitions > into .h files ;-) > > I can move it to 8250_of.c if you like me to. Please, do. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A67AC43219 for ; Mon, 29 Apr 2019 13:22:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D943320652 for ; Mon, 29 Apr 2019 13:22:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D943320652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44t51r3mfdzDq83 for ; Mon, 29 Apr 2019 23:22:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44t4y63fSczDqQl for ; Mon, 29 Apr 2019 23:19:41 +1000 (AEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Apr 2019 06:19:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,409,1549958400"; d="scan'208";a="146675438" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga003.jf.intel.com with ESMTP; 29 Apr 2019 06:19:32 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hL6Bu-0008Ek-Oe; Mon, 29 Apr 2019 16:19:30 +0300 Date: Mon, 29 Apr 2019 16:19:30 +0300 From: Andy Shevchenko To: "Enrico Weigelt, metux IT consult" Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation Message-ID: <20190429131930.GE9224@smile.fi.intel.com> References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-38-git-send-email-info@metux.net> <20190428152103.GP9224@smile.fi.intel.com> <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sparclinux@vger.kernel.org, lorenzo.pieralisi@arm.com, linux-ia64@vger.kernel.org, linux-serial@vger.kernel.org, andrew@aj.id.au, gregkh@linuxfoundation.org, sudeep.holla@arm.com, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, vz@mleia.com, linux@prisktech.co.nz, linuxppc-dev@lists.ozlabs.org, khilman@baylibre.com, macro@linux-mips.org, slemieux.tyco@gmail.com, matthias.bgg@gmail.com, jacmet@sunsite.dk, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, "Enrico Weigelt, metux IT consult" , davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE 0x100 > > > > And why this is in the header file and not in corresponding C one? > > hmm, no particular reason, maybe just an old habit to put definitions > into .h files ;-) > > I can move it to 8250_of.c if you like me to. Please, do. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Mon, 29 Apr 2019 13:19:30 +0000 Subject: Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation Message-Id: <20190429131930.GE9224@smile.fi.intel.com> List-Id: References: <1556369542-13247-1-git-send-email-info@metux.net> <1556369542-13247-38-git-send-email-info@metux.net> <20190428152103.GP9224@smile.fi.intel.com> <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> In-Reply-To: <431b36fe-3071-fcfd-b04e-b4b293e79a80@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Enrico Weigelt, metux IT consult" Cc: sparclinux@vger.kernel.org, lorenzo.pieralisi@arm.com, linux-ia64@vger.kernel.org, linux-serial@vger.kernel.org, andrew@aj.id.au, gregkh@linuxfoundation.org, sudeep.holla@arm.com, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, vz@mleia.com, linux@prisktech.co.nz, linuxppc-dev@lists.ozlabs.org, khilman@baylibre.com, macro@linux-mips.org, slemieux.tyco@gmail.com, matthias.bgg@gmail.com, jacmet@sunsite.dk, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, "Enrico Weigelt, metux IT consult" , davem@davemloft.net On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE 0x100 > > > > And why this is in the header file and not in corresponding C one? > > hmm, no particular reason, maybe just an old habit to put definitions > into .h files ;-) > > I can move it to 8250_of.c if you like me to. Please, do. -- With Best Regards, Andy Shevchenko