From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usbip: vhci_hcd: Mark expected switch fall-through From: "Gustavo A. R. Silva" Message-Id: <20190429143957.GA6725@embeddedor> Date: Mon, 29 Apr 2019 09:39:57 -0500 To: Valentina Manea , Shuah Khan , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Kees Cook List-ID: SW4gcHJlcGFyYXRpb24gdG8gZW5hYmxpbmcgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCwgbWFyayBz d2l0Y2gKY2FzZXMgd2hlcmUgd2UgYXJlIGV4cGVjdGluZyB0byBmYWxsIHRocm91Z2guCgpUaGlz IHBhdGNoIGZpeGVzIHRoZSBmb2xsb3dpbmcgd2FybmluZzoKCkluIGZpbGUgaW5jbHVkZWQgZnJv bSBkcml2ZXJzL3VzYi91c2JpcC92aGNpX2hjZC5jOjE1Ogpkcml2ZXJzL3VzYi91c2JpcC92aGNp X2hjZC5jOiBJbiBmdW5jdGlvbiDigJh2aGNpX2h1Yl9jb250cm9s4oCZOgpkcml2ZXJzL3VzYi91 c2JpcC91c2JpcF9jb21tb24uaDo2Mzo2OiB3YXJuaW5nOiB0aGlzIHN0YXRlbWVudCBtYXkgZmFs bCB0aHJvdWdoIFstV2ltcGxpY2l0LWZhbGx0aHJvdWdoPV0KICAgaWYgKGZsYWcgJiB1c2JpcF9k ZWJ1Z19mbGFnKSAgXAogICAgICBeCmRyaXZlcnMvdXNiL3VzYmlwL3VzYmlwX2NvbW1vbi5oOjc3 OjI6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyDigJh1c2JpcF9kYmdfd2l0aF9mbGFn4oCZ CiAgdXNiaXBfZGJnX3dpdGhfZmxhZyh1c2JpcF9kZWJ1Z192aGNpX3JoLCBmbXQgLCAjI2FyZ3Mp CiAgXn5+fn5+fn5+fn5+fn5+fn5+fgpkcml2ZXJzL3VzYi91c2JpcC92aGNpX2hjZC5jOjUwOTo0 OiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8g4oCYdXNiaXBfZGJnX3ZoY2lfcmjigJkKICAg IHVzYmlwX2RiZ192aGNpX3JoKAogICAgXn5+fn5+fn5+fn5+fn5+fn4KZHJpdmVycy91c2IvdXNi aXAvdmhjaV9oY2QuYzo1MTE6Mzogbm90ZTogaGVyZQogICBjYXNlIFVTQl9QT1JUX0ZFQVRfVTJf VElNRU9VVDoKICAgXn5+fgoKV2FybmluZyBsZXZlbCAzIHdhcyB1c2VkOiAtV2ltcGxpY2l0LWZh bGx0aHJvdWdoPTMKClRoaXMgcGF0Y2ggaXMgcGFydCBvZiB0aGUgb25nb2luZyBlZmZvcnRzIHRv IGVuYWJsZQotV2ltcGxpY2l0LWZhbGx0aHJvdWdoLgoKU2lnbmVkLW9mZi1ieTogR3VzdGF2byBB LiBSLiBTaWx2YSA8Z3VzdGF2b0BlbWJlZGRlZG9yLmNvbT4KLS0tCiBkcml2ZXJzL3VzYi91c2Jp cC92aGNpX2hjZC5jIHwgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYg LS1naXQgYS9kcml2ZXJzL3VzYi91c2JpcC92aGNpX2hjZC5jIGIvZHJpdmVycy91c2IvdXNiaXAv dmhjaV9oY2QuYwppbmRleCA2NjdkOWMwZWM5MDUuLjAwMGFiNzIyNTcxNyAxMDA2NDQKLS0tIGEv ZHJpdmVycy91c2IvdXNiaXAvdmhjaV9oY2QuYworKysgYi9kcml2ZXJzL3VzYi91c2JpcC92aGNp X2hjZC5jCkBAIC01MDgsNiArNTA4LDcgQEAgc3RhdGljIGludCB2aGNpX2h1Yl9jb250cm9sKHN0 cnVjdCB1c2JfaGNkICpoY2QsIHUxNiB0eXBlUmVxLCB1MTYgd1ZhbHVlLAogCQljYXNlIFVTQl9Q T1JUX0ZFQVRfVTFfVElNRU9VVDoKIAkJCXVzYmlwX2RiZ192aGNpX3JoKAogCQkJCSIgU2V0UG9y dEZlYXR1cmU6IFVTQl9QT1JUX0ZFQVRfVTFfVElNRU9VVFxuIik7CisJCQkvKiBGYWxsIHRocm91 Z2ggKi8KIAkJY2FzZSBVU0JfUE9SVF9GRUFUX1UyX1RJTUVPVVQ6CiAJCQl1c2JpcF9kYmdfdmhj aV9yaCgKIAkJCQkiIFNldFBvcnRGZWF0dXJlOiBVU0JfUE9SVF9GRUFUX1UyX1RJTUVPVVRcbiIp Owo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 527D4C43219 for ; Mon, 29 Apr 2019 15:26:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D45620656 for ; Mon, 29 Apr 2019 15:26:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728573AbfD2P0T (ORCPT ); Mon, 29 Apr 2019 11:26:19 -0400 Received: from gateway36.websitewelcome.com ([192.185.188.18]:37153 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728214AbfD2P0T (ORCPT ); Mon, 29 Apr 2019 11:26:19 -0400 X-Greylist: delayed 1500 seconds by postgrey-1.27 at vger.kernel.org; Mon, 29 Apr 2019 11:26:18 EDT Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway36.websitewelcome.com (Postfix) with ESMTP id DB194400C4DD9 for ; Mon, 29 Apr 2019 08:58:40 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id L7RohzrtrdnCeL7RohkLp1; Mon, 29 Apr 2019 09:40:00 -0500 X-Authority-Reason: nr=8 Received: from [189.250.54.97] (port=50000 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1hL7Rm-000tKB-Vr; Mon, 29 Apr 2019 09:39:59 -0500 Date: Mon, 29 Apr 2019 09:39:57 -0500 From: "Gustavo A. R. Silva" To: Valentina Manea , Shuah Khan , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Kees Cook Subject: [PATCH] usbip: vhci_hcd: Mark expected switch fall-through Message-ID: <20190429143957.GA6725@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.54.97 X-Source-L: No X-Exim-ID: 1hL7Rm-000tKB-Vr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.54.97]:50000 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190429143957.O8h29LAU32Yr3knLrNytJvubvGte0cOYDAVFnz3B3tI@z> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: In file included from drivers/usb/usbip/vhci_hcd.c:15: drivers/usb/usbip/vhci_hcd.c: In function ‘vhci_hub_control’: drivers/usb/usbip/usbip_common.h:63:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (flag & usbip_debug_flag) \ ^ drivers/usb/usbip/usbip_common.h:77:2: note: in expansion of macro ‘usbip_dbg_with_flag’ usbip_dbg_with_flag(usbip_debug_vhci_rh, fmt , ##args) ^~~~~~~~~~~~~~~~~~~ drivers/usb/usbip/vhci_hcd.c:509:4: note: in expansion of macro ‘usbip_dbg_vhci_rh’ usbip_dbg_vhci_rh( ^~~~~~~~~~~~~~~~~ drivers/usb/usbip/vhci_hcd.c:511:3: note: here case USB_PORT_FEAT_U2_TIMEOUT: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/usbip/vhci_hcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index 667d9c0ec905..000ab7225717 100644 --- a/drivers/usb/usbip/vhci_hcd.c +++ b/drivers/usb/usbip/vhci_hcd.c @@ -508,6 +508,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, case USB_PORT_FEAT_U1_TIMEOUT: usbip_dbg_vhci_rh( " SetPortFeature: USB_PORT_FEAT_U1_TIMEOUT\n"); + /* Fall through */ case USB_PORT_FEAT_U2_TIMEOUT: usbip_dbg_vhci_rh( " SetPortFeature: USB_PORT_FEAT_U2_TIMEOUT\n"); -- 2.21.0