From: Kalle Valo <kvalo@codeaurora.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: linux-wireless@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Miguel Catalan Cid" <miguel.catalan@i2cat.net>
Subject: Re: [PATCH] ath9k: Don't trust TX status TID number when reporting airtime
Date: Mon, 29 Apr 2019 14:52:36 +0000 (UTC) [thread overview]
Message-ID: <20190429145236.D162E60E41@smtp.codeaurora.org> (raw)
In-Reply-To: <20190307183944.11190-1-toke@redhat.com>
Toke Høiland-Jørgensen wrote:
> As already noted a comment in ath_tx_complete_aggr(), the hardware will
> occasionally send a TX status with the wrong tid number. If we trust the
> value, airtime usage will be reported to the wrong AC, which can cause the
> deficit on that AC to become very low, blocking subsequent attempts to
> transmit.
>
> To fix this, account airtime usage to the TID number from the original skb,
> instead of the one in the hardware TX status report.
>
> Reported-by: Miguel Catalan Cid <miguel.catalan@i2cat.net>
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
389b72e58259 ath9k: Don't trust TX status TID number when reporting airtime
--
https://patchwork.kernel.org/patch/10843731/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-04-29 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 18:39 [PATCH] ath9k: Don't trust TX status TID number when reporting airtime Toke Høiland-Jørgensen
2019-04-29 14:52 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429145236.D162E60E41@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miguel.catalan@i2cat.net \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.