From: Sudeep Holla <sudeep.holla@arm.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Srinath Mannam <srinath.mannam@broadcom.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Pramod Kumar <pramod.kumar@broadcom.com>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 3/3] thermal: broadcom: Add Stingray thermal driver
Date: Mon, 29 Apr 2019 16:24:22 +0100 [thread overview]
Message-ID: <20190429152422.GC17516@e107155-lin> (raw)
In-Reply-To: <da76e12f246c3f10bfed28d8b91a3575dc73f243.camel@infradead.org>
On Mon, Apr 29, 2019 at 06:07:12PM +0300, David Woodhouse wrote:
> On Mon, 2018-05-28 at 11:11 +0530, Srinath Mannam wrote:
> > From: Pramod Kumar <pramod.kumar@broadcom.com>
> >
> > This commit adds stingray thermal driver to monitor six
> > thermal zones temperature and trips at critical temperature.
>
> This matches an ACPI "BRCM0500" device but then calls
> devm_thermal_zone_of_sensor_register(), which AFAICT is going to fail
> on an ACPI system because the first thing that does is call
> of_find_node_by_name(NULL, "thermal-zones") which isn't going to find a
> match.
>
Thanks David for bringing this up. I hadn't noticed that this driver is
cheekily trying to do thermal management in ACPI using crafty
acpi_device_id match. ACPI thermal objects/methods must be used in the
firmware to do thermal management.
Pramod, can you remove the ACPI support or I can go ahead and post the
patch to do the same ?
> How does this work in the ACPI case?
It can't and shouldn't work if one can make it happen :)
--
Regards,
Sudeep
next prev parent reply other threads:[~2019-04-29 15:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 5:41 [PATCH 0/3] Stingray thermal driver support Srinath Mannam
2018-05-28 5:41 ` [PATCH 1/3] dt-bindings: thermal: Add binding document for SR thermal Srinath Mannam
2018-05-31 16:48 ` Rob Herring
2018-06-01 8:51 ` Srinath Mannam
2018-06-01 14:29 ` Rob Herring
2018-06-04 6:06 ` Srinath Mannam
2018-06-18 7:53 ` Srinath Mannam
2018-05-28 5:41 ` [PATCH 2/3] arm64: dts: stingray: Add Stingray Thermal DT support Srinath Mannam
2018-05-28 5:41 ` [PATCH 3/3] thermal: broadcom: Add Stingray thermal driver Srinath Mannam
2018-05-29 18:35 ` kbuild test robot
2018-05-29 18:35 ` kbuild test robot
2019-04-29 15:07 ` David Woodhouse
2019-04-29 15:24 ` Sudeep Holla [this message]
2019-04-29 15:28 ` Srinath Mannam
2019-04-29 15:46 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429152422.GC17516@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pramod.kumar@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.