From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] netdevsim: fix fall-through annotation
Date: Mon, 29 Apr 2019 20:40:23 -0400 [thread overview]
Message-ID: <20190429204023.259fe70a@cakuba> (raw)
In-Reply-To: <20190429173807.GA18088@embeddedor>
On Mon, 29 Apr 2019 12:38:07 -0500, Gustavo A. R. Silva wrote:
> Replace "pass through" with a proper "fall through" annotation
> in order to fix the following warning:
>
> drivers/net/netdevsim/bus.c: In function ‘new_device_store’:
> drivers/net/netdevsim/bus.c:170:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
> port_count = 1;
> ~~~~~~~~~~~^~~
> drivers/net/netdevsim/bus.c:172:2: note: here
> case 2:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This fix is part of the ongoing efforts to enable
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
next prev parent reply other threads:[~2019-04-30 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 17:38 [PATCH net-next] netdevsim: fix fall-through annotation Gustavo A. R. Silva
2019-04-30 0:40 ` Jakub Kicinski [this message]
2019-05-01 15:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429204023.259fe70a@cakuba \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.