From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/4] dt-bindings: usb: dwc2: Document quirk to reset PHY upon wakeup Date: Mon, 29 Apr 2019 19:53:57 -0500 Message-ID: <20190430005357.GA13695@bogus> References: <20190416215351.242246-1-dianders@chromium.org> <20190416215351.242246-2-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190416215351.242246-2-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Douglas Anderson Cc: Minas Harutyunyan , Heiko Stuebner , Felipe Balbi , amstan@chromium.org, linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, Randy Li , mka@chromium.org, ryandcase@chromium.org, jwerner@chromium.org, Elaine Zhang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Mark Rutland List-Id: linux-rockchip.vger.kernel.org On Tue, Apr 16, 2019 at 02:53:48PM -0700, Douglas Anderson wrote: > On Rockchip rk3288 there's a hardware quirk where we need to assert > the reset signal to the PHY when we get a remote wakeup on one of the > two ports. Document this quirk in the bindings. > > Signed-off-by: Douglas Anderson > Reviewed-by: Matthias Kaehlcke > --- > > Changes in v2: None > > Documentation/devicetree/bindings/usb/dwc2.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt b/Documentation/devicetree/bindings/usb/dwc2.txt > index 6dc3c4a34483..f70f3aee4bfc 100644 > --- a/Documentation/devicetree/bindings/usb/dwc2.txt > +++ b/Documentation/devicetree/bindings/usb/dwc2.txt > @@ -37,6 +37,8 @@ Refer to phy/phy-bindings.txt for generic phy consumer properties > - g-rx-fifo-size: size of rx fifo size in gadget mode. > - g-np-tx-fifo-size: size of non-periodic tx fifo size in gadget mode. > - g-tx-fifo-size: size of periodic tx fifo per endpoint (except ep0) in gadget mode. > +- snps,reset-phy-on-wake: If present indicates that we need to reset the PHY when > + we detect a wakeup. This is due to a hardware errata. Synopsys or Rockchip errata? Ideally, this should be implied by the controller or phy compatible. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/4] dt-bindings: usb: dwc2: Document quirk to reset PHY upon wakeup From: Rob Herring Message-Id: <20190430005357.GA13695@bogus> Date: Mon, 29 Apr 2019 19:53:57 -0500 To: Douglas Anderson Cc: Minas Harutyunyan , Heiko Stuebner , Felipe Balbi , amstan@chromium.org, linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, Randy Li , mka@chromium.org, ryandcase@chromium.org, jwerner@chromium.org, Elaine Zhang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Mark Rutland List-ID: T24gVHVlLCBBcHIgMTYsIDIwMTkgYXQgMDI6NTM6NDhQTSAtMDcwMCwgRG91Z2xhcyBBbmRlcnNv biB3cm90ZToKPiBPbiBSb2NrY2hpcCByazMyODggdGhlcmUncyBhIGhhcmR3YXJlIHF1aXJrIHdo ZXJlIHdlIG5lZWQgdG8gYXNzZXJ0Cj4gdGhlIHJlc2V0IHNpZ25hbCB0byB0aGUgUEhZIHdoZW4g d2UgZ2V0IGEgcmVtb3RlIHdha2V1cCBvbiBvbmUgb2YgdGhlCj4gdHdvIHBvcnRzLiAgRG9jdW1l bnQgdGhpcyBxdWlyayBpbiB0aGUgYmluZGluZ3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogRG91Z2xh cyBBbmRlcnNvbiA8ZGlhbmRlcnNAY2hyb21pdW0ub3JnPgo+IFJldmlld2VkLWJ5OiBNYXR0aGlh cyBLYWVobGNrZSA8bWthQGNocm9taXVtLm9yZz4KPiAtLS0KPiAKPiBDaGFuZ2VzIGluIHYyOiBO b25lCj4gCj4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvZHdjMi50eHQg fCAyICsrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0 IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9kd2MyLnR4dCBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvZHdjMi50eHQKPiBpbmRleCA2ZGMzYzRh MzQ0ODMuLmY3MGYzYWVlNGJmYyAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvdXNiL2R3YzIudHh0Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL3VzYi9kd2MyLnR4dAo+IEBAIC0zNyw2ICszNyw4IEBAIFJlZmVyIHRvIHBoeS9w aHktYmluZGluZ3MudHh0IGZvciBnZW5lcmljIHBoeSBjb25zdW1lciBwcm9wZXJ0aWVzCj4gIC0g Zy1yeC1maWZvLXNpemU6IHNpemUgb2YgcnggZmlmbyBzaXplIGluIGdhZGdldCBtb2RlLgo+ICAt IGctbnAtdHgtZmlmby1zaXplOiBzaXplIG9mIG5vbi1wZXJpb2RpYyB0eCBmaWZvIHNpemUgaW4g Z2FkZ2V0IG1vZGUuCj4gIC0gZy10eC1maWZvLXNpemU6IHNpemUgb2YgcGVyaW9kaWMgdHggZmlm byBwZXIgZW5kcG9pbnQgKGV4Y2VwdCBlcDApIGluIGdhZGdldCBtb2RlLgo+ICstIHNucHMscmVz ZXQtcGh5LW9uLXdha2U6IElmIHByZXNlbnQgaW5kaWNhdGVzIHRoYXQgd2UgbmVlZCB0byByZXNl dCB0aGUgUEhZIHdoZW4KPiArICAgICAgICAgICAgICAgICAgICAgICAgICB3ZSBkZXRlY3QgYSB3 YWtldXAuICBUaGlzIGlzIGR1ZSB0byBhIGhhcmR3YXJlIGVycmF0YS4KClN5bm9wc3lzIG9yIFJv Y2tjaGlwIGVycmF0YT8KCklkZWFsbHksIHRoaXMgc2hvdWxkIGJlIGltcGxpZWQgYnkgdGhlIGNv bnRyb2xsZXIgb3IgcGh5IGNvbXBhdGlibGUuCgpSb2IK