All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Parri <andrea.parri@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org,
	"Paul E. McKenney" <paulmck@linux.ibm.com>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Jordan Crouse <jcrouse@codeaurora.org>,
	Jens Axboe <axboe@kernel.dk>, Omar Sandoval <osandov@fb.com>,
	"Yan, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
	Ilya Dryomov <idryomov@gmail.com>,
	Dennis Dalessandro <dennis.dalessandro@intel.com>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH 0/5] Fix improper uses of smp_mb__{before,after}_atomic()
Date: Tue, 30 Apr 2019 10:34:09 +0200	[thread overview]
Message-ID: <20190430083409.GD2677@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1556568902-12464-1-git-send-email-andrea.parri@amarulasolutions.com>

On Mon, Apr 29, 2019 at 10:14:56PM +0200, Andrea Parri wrote:
> Hello!
> 
> A relatively common misuse of these barriers is to apply these to
> operations which are not read-modify-write operations, such as
> atomic_set() and atomic_read(); examples were discussed in [1].
> 
> This series attempts to fix those uses by (conservatively) replacing
> the smp_mb__{before,after}_atomic() barriers with full memory barriers.

I don't think blindly doing this replacement makes the code any better;
much of the code you found is just straight up dodgy to begin with.

I think the people should mostly just consider this a bug report.

Also, remember a memory barrier without a coherent comment is most
likely a bug anyway.

  parent reply	other threads:[~2019-04-30  8:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29 20:14 [PATCH 0/5] Fix improper uses of smp_mb__{before,after}_atomic() Andrea Parri
2019-04-29 20:14 ` [PATCH 1/5] drm/msm: " Andrea Parri
2019-05-09 20:19   ` Andrea Parri
2019-05-09 20:19     ` [PATCH 1/5] drm/msm: Fix improper uses of smp_mb__{before, after}_atomic() Andrea Parri
2019-04-29 20:14 ` [PATCH 2/5] bio: fix improper use of smp_mb__before_atomic() Andrea Parri
2019-04-30  8:21   ` Peter Zijlstra
2019-05-09 20:23   ` Andrea Parri
2019-05-10  3:40   ` Ming Lei
2019-04-29 20:14 ` [PATCH 3/5] sbitmap: " Andrea Parri
2019-05-09 20:26   ` Andrea Parri
2019-05-10  3:41   ` Ming Lei
2019-05-10  6:27     ` Andrea Parri
2019-04-29 20:15 ` [PATCH 4/5] ceph: " Andrea Parri
2019-04-30  8:23   ` Peter Zijlstra
2019-04-30  9:08     ` Yan, Zheng
2019-05-09 20:55       ` Andrea Parri
2019-05-13 13:04         ` Yan, Zheng
2019-05-13 22:47           ` Andrea Parri
2019-04-29 20:15 ` [PATCH 5/5] IB/hfi1: Fix improper uses " Andrea Parri
2019-04-29 21:24   ` Ruhl, Michael J
2019-04-29 23:16     ` Andrea Parri
2019-05-09 21:12       ` Andrea Parri
2019-05-14 12:32         ` Dennis Dalessandro
2019-05-14 14:48           ` Andrea Parri
2019-04-30  8:28   ` Peter Zijlstra
2019-04-30  8:34 ` Peter Zijlstra [this message]
2019-04-30 16:44   ` [PATCH 0/5] Fix improper uses of smp_mb__{before,after}_atomic() Andrea Parri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430083409.GD2677@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=airlied@linux.ie \
    --cc=andrea.parri@amarulasolutions.com \
    --cc=axboe@kernel.dk \
    --cc=daniel@ffwll.ch \
    --cc=dennis.dalessandro@intel.com \
    --cc=dledford@redhat.com \
    --cc=idryomov@gmail.com \
    --cc=jcrouse@codeaurora.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    --cc=osandov@fb.com \
    --cc=paulmck@linux.ibm.com \
    --cc=robdclark@gmail.com \
    --cc=sage@redhat.com \
    --cc=sean@poorly.run \
    --cc=zyan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.