From: Paul Mackerras <paulus@ozlabs.org>
To: kvm-ppc@vger.kernel.org
Subject: Re: [PATCH kernel] KVM: PPC: Avoid lockdep debugging in TCE realmode handlers
Date: Tue, 30 Apr 2019 10:02:31 +0000 [thread overview]
Message-ID: <20190430100231.GD32205@blackberry> (raw)
On Fri, Mar 29, 2019 at 04:42:20PM +1100, Alexey Kardashevskiy wrote:
> The kvmppc_tce_to_ua() helper is called from real and virtual modes
> and it works fine as long as CONFIG_DEBUG_LOCKDEP is not enabled.
> However if the lockdep debugging is on, the lockdep will most likely break
> in kvm_memslots() because of srcu_dereference_check() so we need to use
> PPC-own kvm_memslots_raw() which uses realmode safe
> rcu_dereference_raw_notrace().
>
> This creates a realmode copy of kvmppc_tce_to_ua() which replaces
> kvm_memslots() with kvm_memslots_raw().
>
> Since kvmppc_rm_tce_to_ua() becomes static and can only be used inside
> HV KVM, this moves it earlier under CONFIG_KVM_BOOK3S_HV_POSSIBLE.
>
> This moves truly virtual-mode kvmppc_tce_to_ua() to where it belongs and
> drops the prmap parameter which was never used in the virtual mode.
>
> Fixes: d3695aa4f452 ("KVM: PPC: Add support for multiple-TCE hcalls", 2016-02-15)
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Thanks, patch applied to my kvm-ppc-next tree.
Paul.
next reply other threads:[~2019-04-30 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 10:02 Paul Mackerras [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-29 5:42 [PATCH kernel] KVM: PPC: Avoid lockdep debugging in TCE realmode handlers Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430100231.GD32205@blackberry \
--to=paulus@ozlabs.org \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.