From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [PATCHv2] UAS: fix alignment of scatter/gather segments From: Greg Kroah-Hartman Message-Id: <20190430103202.GA24575@kroah.com> Date: Tue, 30 Apr 2019 12:32:02 +0200 To: Oliver Neukum Cc: linux-usb@vger.kernel.org List-ID: T24gVHVlLCBBcHIgMzAsIDIwMTkgYXQgMTI6MjE6NDVQTSArMDIwMCwgT2xpdmVyIE5ldWt1bSB3 cm90ZToKPiBUaGlzIGlzIHRoZSBVQVMgdmVyc2lvbiBvZgo+IAo+IDc0NzY2OGRiYzA2MWIzZTYy YmMxOTgyNzY3YTNhMWY5ODE1ZmNmMGUKPiB1c2Itc3RvcmFnZTogU2V0IHZpcnRfYm91bmRhcnlf bWFzayB0byBhdm9pZCBTRyBvdmVyZmxvd3MKPiAKPiBXZSBhcmUgbm90IGFzIGxpa2VseSB0byBi ZSB2dWxuZXJhYmxlIGFzIHN0b3JhZ2UsIGFzIGl0IGlzIHVubGlrZWxpZXIKPiB0aGF0IFVBUyBp cyBydW4gb3ZlciBhIGNvbnRyb2xsZXIgd2l0aG91dCBuYXRpdmUgc3VwcG9ydCBmb3IgU0csCj4g YnV0IHRoZSBpc3N1ZSBleGlzdHMuCj4gVGhlIGlzc3VlIGhhcyBiZWVuIGV4aXN0aW5nIHNpbmNl IHRoZSBpbmNlcHRpb24gb2YgdGhlIGRyaXZlci4KPiAKPiBGaXhlczogMTE1YmIxZmZhNTRhYyAo IlVTQjogQWRkIFVBUyBkcml2ZXIiKQoKU2hvdWxkbid0IHRoaXMgYmU6CkZpeGVzOiAxMTViYjFm ZmE1NGMgKCJVU0I6IEFkZCBVQVMgZHJpdmVyIikKClRoZSBzaGExIHlvdSBwdXQgaGVyZSBpc24n dCB2YWxpZCA6KAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A44D8C43219 for ; Tue, 30 Apr 2019 10:37:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B6502075E for ; Tue, 30 Apr 2019 10:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556620663; bh=wxAaG3mH40+wQiZqWe8drx8vQDRIwpzlJHTpiINK9ZM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HyLHdkm4rxFfrlgLmxipcR2jdbr2qJ3l19AoGTqYJrKYNmgr3NtQOAtmeGrnR+Yhx H4yNgw/bvgJggv941LUaeEg687UdI8IvVPjy6E0j/z7AcRekVkDIPkIJqbGL6moQkv ilf9t2o6OjvmBbxJrI5LS4VJ+EbI4yF13ukqkDSY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbfD3Khm (ORCPT ); Tue, 30 Apr 2019 06:37:42 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:44343 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726262AbfD3Khm (ORCPT ); Tue, 30 Apr 2019 06:37:42 -0400 X-Greylist: delayed 334 seconds by postgrey-1.27 at vger.kernel.org; Tue, 30 Apr 2019 06:37:42 EDT Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 9FEF473F; Tue, 30 Apr 2019 06:32:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 30 Apr 2019 06:32:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QymceY o1m9ZhJTIT2V9SfUoPvmceC3x/CSg2lUBgMz8=; b=nZPP8ULB9uODS1bXzkNYs9 iBvHIcB6qeacqGYrfO/OoCMPjfmWnAl46hpJ22qdksCYi21mx+yPvryYzNnQQ89q uTuTldJPr/lyjAyquZFUe21UH83cvGUOlAsybOKfaG0gAcT2/cTBUClJYG47qZtd 2gm47aGnBtVQFcaYQRToBprm7K28nTkreIkZUHGW9RgdWz7u2CJwucIsOi403aRX wJkF20Denk2dKu0g25tDqA82rqrjcCHmKB6Pq7FqmYAuNZrhMUmlVOfenCMrLY8u x7AJzk13QX/QMysllSJvg9abYGPkDptsLlm6Wj7bjOBOTnBGVC4MHhRT2Bl9LwaA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieeggdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgmffjsehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgqeenucfkph epkeefrdekiedrkeelrddutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvghes khhrohgrhhdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 6F55F103CC; Tue, 30 Apr 2019 06:32:04 -0400 (EDT) Date: Tue, 30 Apr 2019 12:32:02 +0200 From: Greg KH To: Oliver Neukum Cc: linux-usb@vger.kernel.org Subject: Re: [PATCHv2] UAS: fix alignment of scatter/gather segments Message-ID: <20190430103202.GA24575@kroah.com> References: <20190430102145.7423-1-oneukum@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190430102145.7423-1-oneukum@suse.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190430103202.osazI1ZUVVkjs6MPbkMkPZrHdWH2Z_75FYHn_LtX_hM@z> On Tue, Apr 30, 2019 at 12:21:45PM +0200, Oliver Neukum wrote: > This is the UAS version of > > 747668dbc061b3e62bc1982767a3a1f9815fcf0e > usb-storage: Set virt_boundary_mask to avoid SG overflows > > We are not as likely to be vulnerable as storage, as it is unlikelier > that UAS is run over a controller without native support for SG, > but the issue exists. > The issue has been existing since the inception of the driver. > > Fixes: 115bb1ffa54ac ("USB: Add UAS driver") Shouldn't this be: Fixes: 115bb1ffa54c ("USB: Add UAS driver") The sha1 you put here isn't valid :(