All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] TST_BRK_SUPPORTS_ONLY_TCONF_TBROK() error message
Date: Tue, 30 Apr 2019 16:43:46 +0200	[thread overview]
Message-ID: <20190430144346.GA16914@dell5510> (raw)

Hi Jan,

your commit 0738e3753 ("lib: build check parameters for tst_brk()") added check
for invalid types. I guess we didn't find a way how to print meaningful error
message e.g. "tst_brk(): invalid type, please use TBROK/TCONF/TFAIL" as Xiao
suggested [1]. Because error message on tst_brk(TINFO, "foo") is a bit
confusing:

../../../../include/tst_common.h:69:25: error: size of unnamed array is negative
  do { ((void)sizeof(char[1 - 2 * !!(condition)])); } while (0)

(this is not related to current release effort)

Kind regards,
Petr

[1] https://patchwork.ozlabs.org/comment/2026378/


             reply	other threads:[~2019-04-30 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 14:43 Petr Vorel [this message]
2019-04-30 14:46 ` [LTP] TST_BRK_SUPPORTS_ONLY_TCONF_TBROK() error message Petr Vorel
2019-04-30 14:51 ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430144346.GA16914@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.