From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Jessica Yu <jeyu@kernel.org>
Subject: [PATCH v3] kernel/module: Reschedule while waiting for modules to finish loading
Date: Tue, 30 Apr 2019 18:22:07 -0400 [thread overview]
Message-ID: <20190430222207.3002-1-prarit@redhat.com> (raw)
On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while
loading the s390_trng.ko module.
Add a reschedule point to the loop that waits for modules to complete
loading.
v3: cleanup Fixes line.
Reported-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Fixes: f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Jessica Yu <jeyu@kernel.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
---
kernel/module.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/module.c b/kernel/module.c
index 410eeb7e4f1d..48748cfec991 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod)
finished_loading(mod->name));
if (err)
goto out_unlocked;
+ cond_resched();
goto again;
}
err = -EEXIST;
--
2.18.1
next reply other threads:[~2019-04-30 22:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 22:22 Prarit Bhargava [this message]
2019-05-01 7:49 ` [PATCH v3] kernel/module: Reschedule while waiting for modules to finish loading Jessica Yu
2019-05-01 21:26 ` Prarit Bhargava
2019-05-02 9:48 ` Jessica Yu
2019-05-02 12:41 ` Prarit Bhargava
2019-05-02 17:46 ` Prarit Bhargava
2019-05-10 18:40 ` Barret Rhoden
2019-05-10 18:42 ` [PATCH] modules: fix livelock in add_unformed_module() Barret Rhoden
2019-05-13 11:23 ` Prarit Bhargava
2019-05-13 14:37 ` Barret Rhoden
2019-05-22 17:08 ` Prarit Bhargava
2019-05-28 14:30 ` Prarit Bhargava
2019-05-28 14:47 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430222207.3002-1-prarit@redhat.com \
--to=prarit@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.