From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: mturquette@baylibre.com, sboyd@kernel.org, agross@kernel.org,
marc.w.gonzalez@free.fr, david.brown@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 5/6] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver
Date: Tue, 30 Apr 2019 20:43:14 -0700 [thread overview]
Message-ID: <20190501034314.GE2938@tuxbook-pro> (raw)
In-Reply-To: <1556677642-29428-1-git-send-email-jhugo@codeaurora.org>
On Tue 30 Apr 19:27 PDT 2019, Jeffrey Hugo wrote:
> +static const struct of_device_id mmcc_msm8998_match_table[] = {
> + { .compatible = "qcom,mmcc-msm8998" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, mmcc_msm8998_match_table);
> +
> +static int mmcc_msm8998_probe(struct platform_device *pdev)
> +{
> + struct regmap *regmap;
> +
Don't you want to wait for "xo" here as well?
> + regmap = qcom_cc_map(pdev, &mmcc_msm8998_desc);
> + if (IS_ERR(regmap))
> + return PTR_ERR(regmap);
> +
> + return qcom_cc_really_probe(pdev, &mmcc_msm8998_desc, regmap);
> +}
[..]
> +MODULE_DESCRIPTION("QCOM MMCC MSM8998 Driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:mmcc-msm8998");
MODULE_DEVICE_TABLE() will provide the alias for module auto loading, so
drop this.
Regards,
Bjorn
next prev parent reply other threads:[~2019-05-01 3:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 2:23 [PATCH v3 0/6] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-05-01 2:23 ` Jeffrey Hugo
2019-05-01 2:24 ` [PATCH v3 1/6] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-05-01 3:34 ` Bjorn Andersson
2019-05-01 14:17 ` Jeffrey Hugo
2019-05-01 19:48 ` Rob Herring
2019-05-01 19:48 ` Rob Herring
2019-05-01 2:25 ` [PATCH v3 2/6] arm64: dts: msm8998: Add xo clock to gcc node Jeffrey Hugo
2019-05-01 3:35 ` Bjorn Andersson
2019-05-01 14:17 ` Jeffrey Hugo
2019-05-01 2:26 ` [PATCH v3 3/6] clk: qcom: smd: Add XO clock for MSM8998 Jeffrey Hugo
2019-05-01 3:26 ` Bjorn Andersson
2019-05-01 2:26 ` [PATCH v3 4/6] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-05-01 3:37 ` Bjorn Andersson
2019-05-01 2:27 ` [PATCH v3 5/6] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-05-01 3:43 ` Bjorn Andersson [this message]
2019-05-01 14:25 ` Jeffrey Hugo
2019-05-01 16:54 ` Bjorn Andersson
2019-05-01 2:27 ` [PATCH v3 6/6] arm64: dts: qcom: msm8998: Add mmcc node Jeffrey Hugo
2019-05-01 3:44 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501034314.GE2938@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.