All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Peng Li <lipeng321@huawei.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxarm@huawei.com,
	yisen.zhuang@huawei.com, salil.mehta@huawei.com
Subject: Re: [PATCH net-next 1/3] net: hns3: add support for multiple media type
Date: Wed, 1 May 2019 14:37:50 +0200	[thread overview]
Message-ID: <20190501123750.GA9844@lunn.ch> (raw)
In-Reply-To: <1556679944-100941-2-git-send-email-lipeng321@huawei.com>

On Wed, May 01, 2019 at 11:05:42AM +0800, Peng Li wrote:
> From: Jian Shen <shenjian15@huawei.com>
> 
> Previously, we can only identify copper and fiber type, the
> supported link modes of port information are always showing
> SR type. This patch adds support for multiple media types,
> include SR, LR CR, KR. Driver needs to query the media type
> from firmware periodicly, and updates the port information.
> 
> The new port information looks like this:
> Settings for eth0:
>         Supported ports: [ FIBRE ]
>         Supported link modes:   25000baseCR/Full
>                                 25000baseSR/Full
>                                 1000baseX/Full
>                                 10000baseCR/Full
>                                 10000baseSR/Full
>                                 10000baseLR/Full
>         Supported pause frame use: Symmetric
>         Supports auto-negotiation: No
>         Supported FEC modes: None BaseR
>         Advertised link modes:  25000baseCR/Full
>                                 25000baseSR/Full
>                                 1000baseX/Full
>                                 10000baseCR/Full
>                                 10000baseSR/Full
>                                 10000baseLR/Full

Hi Peng

If it does not support auto-negotiation, do these advertised link
modes make any sense? Does it really advertise, or is it all fixed
configured?

	Andrew

  reply	other threads:[~2019-05-01 12:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01  3:05 [PATCH net-next 0/3] net: hns3: enhance capabilities for fibre port Peng Li
2019-05-01  3:05 ` [PATCH net-next 1/3] net: hns3: add support for multiple media type Peng Li
2019-05-01 12:37   ` Andrew Lunn [this message]
2019-05-03  3:13     ` lipeng (Y)
2019-05-03  9:54       ` lipeng (Y)
2019-05-01  3:05 ` [PATCH net-next 2/3] net: hns3: add autoneg and change speed support for fibre port Peng Li
2019-05-01  3:05 ` [PATCH net-next 3/3] net: hns3: add support for FEC encoding control Peng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190501123750.GA9844@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=lipeng321@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.