From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: isp1760-hcd: Fix fall-through annotations From: "Gustavo A. R. Silva" Message-Id: <20190501153934.GA20025@embeddedor> Date: Wed, 1 May 2019 10:39:34 -0500 To: Greg Kroah-Hartman , Arvid Brodin Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-ID: SW4gcHJlcGFyYXRpb24gdG8gZW5hYmxpbmcgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCwgbWFyayBz d2l0Y2gKY2FzZXMgd2hlcmUgd2UgYXJlIGV4cGVjdGluZyB0byBmYWxsIHRocm91Z2guCgpUaGlz IHBhdGNoIGZpeGVzIHRoZSBmb2xsb3dpbmcgd2FybmluZzoKCmRyaXZlcnMvdXNiL2lzcDE3NjAv aXNwMTc2MC1oY2QuYzogSW4gZnVuY3Rpb24g4oCYY29sbGVjdF9xdGRz4oCZOgpkcml2ZXJzL3Vz Yi9pc3AxNzYwL2lzcDE3NjAtaGNkLmM6Nzg4OjY6IHdhcm5pbmc6IHRoaXMgc3RhdGVtZW50IG1h eSBmYWxsIHRocm91Z2ggWy1XaW1wbGljaXQtZmFsbHRocm91Z2g9XQogICAgICBtZW1fcmVhZHM4 KGhjZC0+cmVncywgcXRkLT5wYXlsb2FkX2FkZHIsCiAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn4KICAgICAgICBxdGQtPmRhdGFfYnVmZmVyLAogICAgICAgIH5+ fn5+fn5+fn5+fn5+fn5+CiAgICAgICAgcXRkLT5hY3R1YWxfbGVuZ3RoKTsKICAgICAgICB+fn5+ fn5+fn5+fn5+fn5+fn5+CmRyaXZlcnMvdXNiL2lzcDE3NjAvaXNwMTc2MC1oY2QuYzo3OTI6NTog bm90ZTogaGVyZQogICAgIGNhc2UgT1VUX1BJRDoKICAgICBefn5+CgpXYXJuaW5nIGxldmVsIDMg d2FzIHVzZWQ6IC1XaW1wbGljaXQtZmFsbHRocm91Z2g9MwoKTm90aWNlIHRoYXQsIGluIHRoaXMg cGFydGljdWxhciBjYXNlLCB0aGUgY29kZSBjb21tZW50cyBhcmUgbW9kaWZpZWQKaW4gYWNjb3Jk YW5jZSB3aXRoIHdoYXQgR0NDIGlzIGV4cGVjdGluZyB0byBmaW5kLgoKVGhpcyBwYXRjaCBpcyBw YXJ0IG9mIHRoZSBvbmdvaW5nIGVmZm9ydHMgdG8gZW5hYmxlCi1XaW1wbGljaXQtZmFsbHRocm91 Z2guCgpTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVk b3IuY29tPgotLS0KTm90aWNlIHRoYXQgdGhpcyBjb2RlIGhhcyBiZWVuIG91dCB0aGVyZSBzaW5j ZSAyMDExLCBhbmQgd2hvCmludHJvZHVjZWQgdGhlIHF1ZXN0aW9uIG1hcmsgd2FzIHRoZSBvcmln aW5hbCBkZXZlbG9wZXIuCgpJdCdkIGJlIGdvb2QgaWYgc29tZW9uZSBjYW4gY29uZmlybSB0aGF0 IHRoZSBmYWxsLXRocm91Z2gKaGFzIGJlZW4gaW50ZW50aW9uYWwgYWxsIHRoaXMgdGltZS4KCQpU aGFua3MKLS0KR3VzdGF2bwoKIGRyaXZlcnMvdXNiL2lzcDE3NjAvaXNwMTc2MC1oY2QuYyB8IDQg KystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9pc3AxNzYwL2lzcDE3NjAtaGNkLmMgYi9kcml2ZXJzL3Vz Yi9pc3AxNzYwL2lzcDE3NjAtaGNkLmMKaW5kZXggODE0MmM2YjRjNGNmLi4zMjBmYzQ3Mzk4MzUg MTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL2lzcDE3NjAvaXNwMTc2MC1oY2QuYworKysgYi9kcml2 ZXJzL3VzYi9pc3AxNzYwL2lzcDE3NjAtaGNkLmMKQEAgLTc4OCwxMSArNzg4LDExIEBAIHN0YXRp YyB2b2lkIGNvbGxlY3RfcXRkcyhzdHJ1Y3QgdXNiX2hjZCAqaGNkLCBzdHJ1Y3QgaXNwMTc2MF9x aCAqcWgsCiAJCQkJCW1lbV9yZWFkczgoaGNkLT5yZWdzLCBxdGQtPnBheWxvYWRfYWRkciwKIAkJ CQkJCQlxdGQtPmRhdGFfYnVmZmVyLAogCQkJCQkJCXF0ZC0+YWN0dWFsX2xlbmd0aCk7Ci0JCQkJ CS8qIEZhbGwgdGhyb3VnaCAoPykgKi8KKwkJCQkJLyogRmFsbCB0aHJvdWdoICovCiAJCQkJY2Fz ZSBPVVRfUElEOgogCQkJCQlxdGQtPnVyYi0+YWN0dWFsX2xlbmd0aCArPQogCQkJCQkJCXF0ZC0+ YWN0dWFsX2xlbmd0aDsKLQkJCQkJLyogRmFsbCB0aHJvdWdoIC4uLiAqLworCQkJCQkvKiBGYWxs IHRocm91Z2ggKi8KIAkJCQljYXNlIFNFVFVQX1BJRDoKIAkJCQkJYnJlYWs7CiAJCQkJfQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5448C43219 for ; Wed, 1 May 2019 16:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D09B2085A for ; Wed, 1 May 2019 16:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbfEAQBS (ORCPT ); Wed, 1 May 2019 12:01:18 -0400 Received: from gateway36.websitewelcome.com ([50.116.126.2]:26065 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726434AbfEAQBS (ORCPT ); Wed, 1 May 2019 12:01:18 -0400 X-Greylist: delayed 1300 seconds by postgrey-1.27 at vger.kernel.org; Wed, 01 May 2019 12:01:18 EDT Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id ED2ED400C9DC5 for ; Wed, 1 May 2019 09:58:24 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id LrKbhBu9r4FKpLrKbhcRBY; Wed, 01 May 2019 10:39:37 -0500 X-Authority-Reason: nr=8 Received: from [189.250.119.203] (port=32788 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1hLrKa-001Vu7-Gn; Wed, 01 May 2019 10:39:36 -0500 Date: Wed, 1 May 2019 10:39:34 -0500 From: "Gustavo A. R. Silva" To: Greg Kroah-Hartman , Arvid Brodin Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] usb: isp1760-hcd: Fix fall-through annotations Message-ID: <20190501153934.GA20025@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.119.203 X-Source-L: No X-Exim-ID: 1hLrKa-001Vu7-Gn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.119.203]:32788 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 10 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190501153934.913TTpbzSYfAg5wmO52Z9U0y5rVDd8f2wlMVyeYhaVE@z> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/usb/isp1760/isp1760-hcd.c: In function ‘collect_qtds’: drivers/usb/isp1760/isp1760-hcd.c:788:6: warning: this statement may fall through [-Wimplicit-fallthrough=] mem_reads8(hcd->regs, qtd->payload_addr, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ qtd->data_buffer, ~~~~~~~~~~~~~~~~~ qtd->actual_length); ~~~~~~~~~~~~~~~~~~~ drivers/usb/isp1760/isp1760-hcd.c:792:5: note: here case OUT_PID: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in this particular case, the code comments are modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva --- Notice that this code has been out there since 2011, and who introduced the question mark was the original developer. It'd be good if someone can confirm that the fall-through has been intentional all this time. Thanks -- Gustavo drivers/usb/isp1760/isp1760-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c index 8142c6b4c4cf..320fc4739835 100644 --- a/drivers/usb/isp1760/isp1760-hcd.c +++ b/drivers/usb/isp1760/isp1760-hcd.c @@ -788,11 +788,11 @@ static void collect_qtds(struct usb_hcd *hcd, struct isp1760_qh *qh, mem_reads8(hcd->regs, qtd->payload_addr, qtd->data_buffer, qtd->actual_length); - /* Fall through (?) */ + /* Fall through */ case OUT_PID: qtd->urb->actual_length += qtd->actual_length; - /* Fall through ... */ + /* Fall through */ case SETUP_PID: break; } -- 2.21.0