From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Date: Wed, 1 May 2019 15:22:00 -0500 Message-ID: <20190501202200.GB15495@bogus> References: <1556456002-13430-1-git-send-email-ynezz@true.cz> <1556456002-13430-3-git-send-email-ynezz@true.cz> <20190428165326.GI23059@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190428165326.GI23059@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Lunn Cc: Petr =?utf-8?Q?=C5=A0tetiar?= , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Mark Rutland , Vivien Didelot , Florian Fainelli , Yisen Zhuang , Salil Mehta , Woojung Huh , Microchip Linux Driver Support , Kunihiko Hayashi , Masahiro Yamada , Jassi Brar , Kalle Valo , Matthias Brugger , Heiner Kallweit , Frank Rowand List-Id: linux-mediatek@lists.infradead.org On Sun, Apr 28, 2019 at 06:53:26PM +0200, Andrew Lunn wrote: > On Sun, Apr 28, 2019 at 02:53:20PM +0200, Petr Štetiar wrote: > > As of_get_mac_address now supports NVMEM under the hood, we need to update > > the bindings documentation with the new nvmem-cell* properties, which would > > mean copy&pasting a lot of redundant information to every binding > > documentation currently referencing some of the MAC address properties. > > > > So I've just removed all the references to the optional MAC address > > properties and replaced them with the reference to the net/ethernet.txt > > file. While at it, I've also removed other optional Ethernet properties. > > Hi Petr > > I think each individual binding needs to give a hint if > of_get_mac_address() is used, and hence if these optional properties > are respected. The same is true for other optional properties. I don't > want to have to look at the driver to know which optional properties > are implemented, the binding should tell me. What the optional > properties mean, and which order they are used in can then be defined > in ethernet.txt. > > So i would suggests something like: > > The MAC address will be determined using the optional properties > defined in ethernet.txt. > > And leave all the other optional parameters in the bindings. Yes. Generally we need to know which properties from a common pool of properties apply to a specific binding. Also there are typically additional constraints for a specific binding. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3553C43219 for ; Wed, 1 May 2019 20:22:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B12B8205F4 for ; Wed, 1 May 2019 20:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556742128; bh=ieQcaLO4zm7IDaiolQ4F1oO1N2L0q7/pg35riCi+S20=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IMQyEKb85WJKhskPKwo7n5FEmL2Eb1kybZaA2gCVQEKYyHWuSwJscCs43+s4P/r8b iCv6eZFSWTroF+ZR8yHLg9pueL/ueHH7EVnatLfnAHIbicevZiaU7f+/Dc55ymmCgb tw+8XCf8tIkWs3jVrJBVdy+wOEG0+ePFu5BHaZjM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbfEAUWD (ORCPT ); Wed, 1 May 2019 16:22:03 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:39183 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbfEAUWC (ORCPT ); Wed, 1 May 2019 16:22:02 -0400 Received: by mail-ot1-f67.google.com with SMTP id o39so109498ota.6; Wed, 01 May 2019 13:22:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=j6+33T0eQYv+IRslxaB17BzPQR0ZaM4rayHxbAHslak=; b=RE6QiWOQgI6pN7NXiR369Zc17nr6DSuJ+8WpLwe9HKX90iyJN3ZF/LZKuGuN5WX+OT mbyQ3IY/oE9sMAKNVibyhoYcDh43raPXJjnio8waBjPMRAFp6mmftR/ELP0LMm8ZE4U2 HX3EMy9v/wYPmdA/JDgDBs81N4C0G4bET98BHO0/HrY36iLRDavO80l9UrsPRa4wbYBi 974N3+L8n8iuG4KTGffGiRvRQIMkDOWVhZFa1aPJmYzK5+ZXvTuh0JETya+9IR7AMCns i+3etzKo9Cxo3sQYHdeigUcEG7xv05ClqArwQ5eHmSVjlE7t/a4Sp312u3NresQezP8n AksA== X-Gm-Message-State: APjAAAU1ajGQxBVV1GNN8Al3jvWv9JDZ1pg/M+xqvlZGRmIO4eIIwgcO OcvIkxxVuHZfCHIjSwj71Q== X-Google-Smtp-Source: APXvYqwBsg5utWlEXRbe3QYD7lyCysBSGwYTazCLxVYMMvMP+E5wWbFBBWdUCspop11+hVf0xHJhqQ== X-Received: by 2002:a9d:3624:: with SMTP id w33mr19027211otb.284.1556742121379; Wed, 01 May 2019 13:22:01 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id c26sm2891416otl.19.2019.05.01.13.22.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 May 2019 13:22:00 -0700 (PDT) Date: Wed, 1 May 2019 15:22:00 -0500 From: Rob Herring To: Andrew Lunn Cc: Petr =?utf-8?Q?=C5=A0tetiar?= , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Mark Rutland , Vivien Didelot , Florian Fainelli , Yisen Zhuang , Salil Mehta , Woojung Huh , Microchip Linux Driver Support , Kunihiko Hayashi , Masahiro Yamada , Jassi Brar , Kalle Valo , Matthias Brugger , Heiner Kallweit , Frank Rowand , Srinivas Kandagatla , Maxime Ripard , Alban Bedel , linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Message-ID: <20190501202200.GB15495@bogus> References: <1556456002-13430-1-git-send-email-ynezz@true.cz> <1556456002-13430-3-git-send-email-ynezz@true.cz> <20190428165326.GI23059@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190428165326.GI23059@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, Apr 28, 2019 at 06:53:26PM +0200, Andrew Lunn wrote: > On Sun, Apr 28, 2019 at 02:53:20PM +0200, Petr Štetiar wrote: > > As of_get_mac_address now supports NVMEM under the hood, we need to update > > the bindings documentation with the new nvmem-cell* properties, which would > > mean copy&pasting a lot of redundant information to every binding > > documentation currently referencing some of the MAC address properties. > > > > So I've just removed all the references to the optional MAC address > > properties and replaced them with the reference to the net/ethernet.txt > > file. While at it, I've also removed other optional Ethernet properties. > > Hi Petr > > I think each individual binding needs to give a hint if > of_get_mac_address() is used, and hence if these optional properties > are respected. The same is true for other optional properties. I don't > want to have to look at the driver to know which optional properties > are implemented, the binding should tell me. What the optional > properties mean, and which order they are used in can then be defined > in ethernet.txt. > > So i would suggests something like: > > The MAC address will be determined using the optional properties > defined in ethernet.txt. > > And leave all the other optional parameters in the bindings. Yes. Generally we need to know which properties from a common pool of properties apply to a specific binding. Also there are typically additional constraints for a specific binding. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1582BC04AA8 for ; Wed, 1 May 2019 20:22:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4730208C3 for ; Wed, 1 May 2019 20:22:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CxnSSvox" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4730208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ll2DSd9+m0ee/EBF+pmCfUM3D+ErtvUNjVyipCrwoeU=; b=CxnSSvoxg+bpzM /L40EiEj7C7B3SUp73b1W+ONj/wLZyfmVLxUPfsHFalBq6bdIvqH251paX7SBAQiug5jrRI6xvk6/ kb5GpjafN4LZGcZAC3O5hrrGc4c6TrDRl7QA2tZ2mx+3qPw7EHh9DX+pzhYT5lxWf3kCUjPwcaDj3 BTmO0UjmmwViouGfiGVt2KBpqPYD03wG6azzE7EnD0f/YkL5nPDFuo/Hf7f6/6SB9n/dv602DOEMp vEQ34ZXpZFL3zM68o+lDOsEnCMjtURG05FB/wqP0/TyQc+OLT0XrUcQtMrL6CIJ48vla6YmBB7zBq 4mR5rOWaGIh++knHl1EA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLvjx-0001GE-3i; Wed, 01 May 2019 20:22:05 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLvju-0001Fp-4n; Wed, 01 May 2019 20:22:03 +0000 Received: by mail-ot1-f67.google.com with SMTP id g24so128993otq.2; Wed, 01 May 2019 13:22:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=j6+33T0eQYv+IRslxaB17BzPQR0ZaM4rayHxbAHslak=; b=sx3a5pGlCNYDQWAdNA/7YZvR25uWjfKfgylv4pNUl9YYn6y3xYsd+1RBFf+ZJHFekT Hx0ZM8UDn7PpF2ZGe0AX3jH2PzmlCPbFrmxI1wwaqcfsVQJYTG+aWxMkSnfLTkMu6Hnd Gat1y9yrsz5ucgzQwah0xwJK+fU59Z8uUqA3SSBdFW/Gb6e93FEzkuk2QMfqqCQZp1ed LC3GQtAAISYpI9TZIRcT0Wo2/fPTsVSEJ/JmKKn8U5hrdPZm5QCaMbA5XNn5mOadLCXk k/DkYVHRXs5BBPUb9MRJf7UZ1cSpCnrRUvQAJqhMiSBAU0oHYnSMFvqSNwi7VJsOxNWB upGw== X-Gm-Message-State: APjAAAWkJmPCQQPRfPmb1a7WmYPjmez93N2UlbhstTmnoJ19tr7Lp8SB +nrfDs6dxUq5h6kvIftMIQ== X-Google-Smtp-Source: APXvYqwBsg5utWlEXRbe3QYD7lyCysBSGwYTazCLxVYMMvMP+E5wWbFBBWdUCspop11+hVf0xHJhqQ== X-Received: by 2002:a9d:3624:: with SMTP id w33mr19027211otb.284.1556742121379; Wed, 01 May 2019 13:22:01 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id c26sm2891416otl.19.2019.05.01.13.22.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 May 2019 13:22:00 -0700 (PDT) Date: Wed, 1 May 2019 15:22:00 -0500 From: Rob Herring To: Andrew Lunn Subject: Re: [PATCH v2 2/4] dt-bindings: doc: Reflect new NVMEM of_get_mac_address behaviour Message-ID: <20190501202200.GB15495@bogus> References: <1556456002-13430-1-git-send-email-ynezz@true.cz> <1556456002-13430-3-git-send-email-ynezz@true.cz> <20190428165326.GI23059@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190428165326.GI23059@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190501_132202_182512_13562023 X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kunihiko Hayashi , Maxime Ripard , Masahiro Yamada , Srinivas Kandagatla , Frank Rowand , Florian Fainelli , linux-arm-kernel@lists.infradead.org, Petr =?utf-8?Q?=C5=A0tetiar?= , Yisen Zhuang , Vivien Didelot , Woojung Huh , devicetree@vger.kernel.org, Jassi Brar , linux-mediatek@lists.infradead.org, Matthias Brugger , Kalle Valo , Salil Mehta , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Microchip Linux Driver Support , Alban Bedel , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBBcHIgMjgsIDIwMTkgYXQgMDY6NTM6MjZQTSArMDIwMCwgQW5kcmV3IEx1bm4gd3Jv dGU6Cj4gT24gU3VuLCBBcHIgMjgsIDIwMTkgYXQgMDI6NTM6MjBQTSArMDIwMCwgUGV0ciDFoHRl dGlhciB3cm90ZToKPiA+IEFzIG9mX2dldF9tYWNfYWRkcmVzcyBub3cgc3VwcG9ydHMgTlZNRU0g dW5kZXIgdGhlIGhvb2QsIHdlIG5lZWQgdG8gdXBkYXRlCj4gPiB0aGUgYmluZGluZ3MgZG9jdW1l bnRhdGlvbiB3aXRoIHRoZSBuZXcgbnZtZW0tY2VsbCogcHJvcGVydGllcywgd2hpY2ggd291bGQK PiA+IG1lYW4gY29weSZwYXN0aW5nIGEgbG90IG9mIHJlZHVuZGFudCBpbmZvcm1hdGlvbiB0byBl dmVyeSBiaW5kaW5nCj4gPiBkb2N1bWVudGF0aW9uIGN1cnJlbnRseSByZWZlcmVuY2luZyBzb21l IG9mIHRoZSBNQUMgYWRkcmVzcyBwcm9wZXJ0aWVzLgo+ID4gCj4gPiBTbyBJJ3ZlIGp1c3QgcmVt b3ZlZCBhbGwgdGhlIHJlZmVyZW5jZXMgdG8gdGhlIG9wdGlvbmFsIE1BQyBhZGRyZXNzCj4gPiBw cm9wZXJ0aWVzIGFuZCByZXBsYWNlZCB0aGVtIHdpdGggdGhlIHJlZmVyZW5jZSB0byB0aGUgbmV0 L2V0aGVybmV0LnR4dAo+ID4gZmlsZS4gIFdoaWxlIGF0IGl0LCBJJ3ZlIGFsc28gcmVtb3ZlZCBv dGhlciBvcHRpb25hbCBFdGhlcm5ldCBwcm9wZXJ0aWVzLgo+IAo+IEhpIFBldHIKPiAKPiBJIHRo aW5rIGVhY2ggaW5kaXZpZHVhbCBiaW5kaW5nIG5lZWRzIHRvIGdpdmUgYSBoaW50IGlmCj4gb2Zf Z2V0X21hY19hZGRyZXNzKCkgaXMgdXNlZCwgYW5kIGhlbmNlIGlmIHRoZXNlIG9wdGlvbmFsIHBy b3BlcnRpZXMKPiBhcmUgcmVzcGVjdGVkLiBUaGUgc2FtZSBpcyB0cnVlIGZvciBvdGhlciBvcHRp b25hbCBwcm9wZXJ0aWVzLiBJIGRvbid0Cj4gd2FudCB0byBoYXZlIHRvIGxvb2sgYXQgdGhlIGRy aXZlciB0byBrbm93IHdoaWNoIG9wdGlvbmFsIHByb3BlcnRpZXMKPiBhcmUgaW1wbGVtZW50ZWQs IHRoZSBiaW5kaW5nIHNob3VsZCB0ZWxsIG1lLiBXaGF0IHRoZSBvcHRpb25hbAo+IHByb3BlcnRp ZXMgbWVhbiwgYW5kIHdoaWNoIG9yZGVyIHRoZXkgYXJlIHVzZWQgaW4gY2FuIHRoZW4gYmUgZGVm aW5lZAo+IGluIGV0aGVybmV0LnR4dC4KPiAKPiBTbyBpIHdvdWxkIHN1Z2dlc3RzIHNvbWV0aGlu ZyBsaWtlOgo+IAo+IFRoZSBNQUMgYWRkcmVzcyB3aWxsIGJlIGRldGVybWluZWQgdXNpbmcgdGhl IG9wdGlvbmFsIHByb3BlcnRpZXMKPiBkZWZpbmVkIGluIGV0aGVybmV0LnR4dC4KPiAKPiBBbmQg bGVhdmUgYWxsIHRoZSBvdGhlciBvcHRpb25hbCBwYXJhbWV0ZXJzIGluIHRoZSBiaW5kaW5ncy4K Clllcy4gR2VuZXJhbGx5IHdlIG5lZWQgdG8ga25vdyB3aGljaCBwcm9wZXJ0aWVzIGZyb20gYSBj b21tb24gcG9vbCBvZiAKcHJvcGVydGllcyBhcHBseSB0byBhIHNwZWNpZmljIGJpbmRpbmcuIEFs c28gdGhlcmUgYXJlIHR5cGljYWxseSAKYWRkaXRpb25hbCBjb25zdHJhaW50cyBmb3IgYSBzcGVj aWZpYyBiaW5kaW5nLgoKUm9iCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==