From: Dan Carpenter <dan.carpenter@oracle.com>
To: siva8118@gmail.com
Cc: linux-wireless@vger.kernel.org
Subject: [bug report] rsi: add firmware loading for 9116 device
Date: Thu, 2 May 2019 09:51:25 +0300 [thread overview]
Message-ID: <20190502065125.GA9844@mwanda> (raw)
Hello Siva Rebbagondla,
The patch e5a1ecc97e5f: "rsi: add firmware loading for 9116 device"
from Apr 3, 2019, leads to the following static checker warning:
drivers/net/wireless/rsi/rsi_91x_sdio.c:940 rsi_sdio_ta_reset()
error: uninitialized symbol 'data'.
drivers/net/wireless/rsi/rsi_91x_sdio.c
926 static int rsi_sdio_ta_reset(struct rsi_hw *adapter)
927 {
928 int status;
929 u32 addr;
930 u8 *data;
^^^^^^^^
931
932 status = rsi_sdio_master_access_msword(adapter, TA_BASE_ADDR);
933 if (status < 0) {
934 rsi_dbg(ERR_ZONE,
935 "Unable to set ms word to common reg\n");
936 return status;
937 }
938
939 rsi_dbg(INIT_ZONE, "%s: Bring TA out of reset\n", __func__);
940 put_unaligned_le32(TA_HOLD_THREAD_VALUE, data);
^^^^
Not initialized.
941 addr = TA_HOLD_THREAD_REG | RSI_SD_REQUEST_MASTER;
942 status = rsi_sdio_write_register_multiple(adapter, addr,
943 (u8 *)&data,
^^^^^^^^^^^
It's really hard to test reset functions of course... :(
944 RSI_9116_REG_SIZE);
945 if (status < 0) {
946 rsi_dbg(ERR_ZONE, "Unable to hold TA threads\n");
947 return status;
948 }
949
950 put_unaligned_le32(TA_SOFT_RST_CLR, data);
951 addr = TA_SOFT_RESET_REG | RSI_SD_REQUEST_MASTER;
952 status = rsi_sdio_write_register_multiple(adapter, addr,
953 (u8 *)&data,
954 RSI_9116_REG_SIZE);
955 if (status < 0) {
956 rsi_dbg(ERR_ZONE, "Unable to get TA out of reset\n");
957 return status;
958 }
regards,
dan carpenter
reply other threads:[~2019-05-02 6:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502065125.GA9844@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
--cc=siva8118@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.