From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Behun Date: Thu, 2 May 2019 11:39:12 +0200 Subject: [U-Boot] [PATCH u-boot-marvell v2 14/15] arm: mvebu: turris_omnia: add RESET button handling In-Reply-To: References: <20190430014825.30553-1-marek.behun@nic.cz> <20190430014825.30553-15-marek.behun@nic.cz> Message-ID: <20190502113912.57405d2a@nic.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2 May 2019 08:10:36 +0200 Stefan Roese wrote: > I fail to see a real reason to introduce these Kconfig options. Is > TURRIS_OMNIA_RSTBTN_OVERWRITE_BOOTCMD enabled for your board? If not > it just adds dead code, as no other board will ever enable it. So do > you plan to add 2 Omnia build targets, one with and one w/o this > option enabled? Or what is your plan here? > > Thanks, > Stefan My idea was that the users should be able to disable this functionality, if they are compiling u-boot themselves, but we are going to ship Omnias with this config enabled. I can of course remove the Kconfig options and enable this reset button handling all times. Marek