From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table Date: Fri, 3 May 2019 08:49:27 +0300 Message-ID: <20190503054927.GC3728@linux.intel.com> References: <20190227202658.197113-1-matthewgarrett@google.com> <20190227202658.197113-3-matthewgarrett@google.com> <20190502083240.GJ14532@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Matthew Garrett Cc: Bartosz Szczepanek , linux-integrity , Peter Huewe , Jason Gunthorpe , Roberto Sassu , linux-efi , LSM List , Linux Kernel Mailing List , =?iso-8859-1?Q?Thi=E9baud?= Weksteen List-Id: linux-efi@vger.kernel.org On Thu, May 02, 2019 at 11:03:08AM -0700, Matthew Garrett wrote: > On Thu, May 2, 2019 at 1:32 AM Jarkko Sakkinen > wrote: > > > > On Tue, Apr 30, 2019 at 03:07:09PM +0200, Bartosz Szczepanek wrote: > > > I may be a little late with this comment, but I've just tested these > > > patches on aarch64 platform (from the top of jjs/master) and got > > > kernel panic ("Unable to handle kernel read", full log at the end of > > > mail). I think there's problem with below call to > > > tpm2_calc_event_log_size(), where physical address of efi.tpm_log is > > > passed as (void *) and never remapped: > > > > Not late. This is not part of any PR yet. Thank you for the > > feedback! > > > > Matthew, can you send an updated version of the whole patch set > > with fixes to this issue and also reordering of the includes? > > Yes, I'll resend and let's do this again for 5.3. Agreed, better not rush but get it right once. /Jarkko