From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: io_edgeport: fix up switch fall-through comments From: Johan Hovold Message-Id: <20190503060908.GY26546@localhost> Date: Fri, 3 May 2019 08:09:08 +0200 To: Greg Kroah-Hartman Cc: Johan Hovold , linux-usb@vger.kernel.org, "Gustavo A. R. Silva" List-ID: T24gVGh1LCBNYXkgMDIsIDIwMTkgYXQgMDc6MzU6MTVQTSArMDIwMCwgR3JlZyBLcm9haC1IYXJ0 bWFuIHdyb3RlOgo+IEd1c3Rhdm8gaGFzIGJlZW4gd29ya2luZyB0byBmaXggdXAgYWxsIG9mIHRo ZSBzd2l0Y2ggc3RhdGVtZW50cyB0aGF0Cj4gImZhbGwgdGhyb3VnaCIgc3VjaCB0aGF0IHdlIGNh biBldmVudHVhbGx5IHR1cm4gb24KPiAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoLiAgQXMgcGFydCBv ZiB0aGF0LCB0aGUgaW9fZWRnZXBvcnQuYyBkcml2ZXIgaXMgYQo+IGJpdCAibWVzc3kiIHdpdGgg dGhlIHBhcnNpbmcgbG9naWMgb2YgYSBkYXRhIHBhY2tldC4gIENsZWFuIHRoYXQgbG9naWMKPiB1 cCBhIGJpdCBieSB1bmluZGVudGluZyBvbmUgbGV2ZWwgb2YgdGhlIGxvZ2ljLCBhbmQgcHJvcGVy bHkgbGFiZWwKPiAvKiBGYWxsIHRocm91Z2ggKi8gdG8gbWFrZSBnY2MgaGFwcHkuCj4gCj4gUmVw b3J0ZWQtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9AZW1iZWRkZWRvci5jb20+Cj4g U2lnbmVkLW9mZi1ieTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9u Lm9yZz4KCk5vdyBhcHBsaWVkLCB0aGFua3MuCgpHdXN0YXZvLCBob3cgbWFueSBvZiB0aGVzZSB3 YXJuaW5ncyBhcmUgdGhlcmUgbGVmdCBpbiB0aGUga2VybmVsIG5vdwp0aGF0IHRoZSBsYXN0IG9u ZSBpbiBVU0IgaXMgZ29uZT8gOikKCkpvaGFuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC91AC43219 for ; Fri, 3 May 2019 06:09:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 733972081C for ; Fri, 3 May 2019 06:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556863740; bh=lfvc+v3NLBLUbou6SyNDF+BOPGWk41/ZvclUyXqw3lA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Tn9GznS/qC/0zRIZVN46aQ2BYd/6tjT7QJhcZ129dp31c7+hOpLujtRL6JXxpCKuM r9qw/6j0LKpNvtFBzomXJJEGLL4tcD2s84gN0McTXKA0l7NB5KdfHsaTyMSkpU/z1F ksINxQ/RIsvdu18hQX7S+1/OyqiaHXupkxeKnhhQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726244AbfECGI7 (ORCPT ); Fri, 3 May 2019 02:08:59 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:45830 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfECGI7 (ORCPT ); Fri, 3 May 2019 02:08:59 -0400 Received: by mail-lf1-f66.google.com with SMTP id t11so3562388lfl.12 for ; Thu, 02 May 2019 23:08:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PbLj7/MYB4ffyjWBFDcrh5vX+uBxm5QKj5D+y/GQtpM=; b=OE+cNj1WLQraNM3wYMeo3t6Is511oElziB1hVbllEopzMfDEIJ3W/qSJkE4nBx8oUA mL6iaTfvakOpTAjFvjOOIIVI0gk7CeTN/Bpx5nMiScsSkE9Nw+OGT0UlDvPDgL5lVeHv ojdtC4gy3sFOVAXEC6z+696rwlpWxtkZAo0nFupANpZgDowvxfr/3OGN88ak3KTcIqKX 2OQlJPUJ8meMJCDqTP1pAz0o8DKw+dfE3XyADeMvzREo9kFpqWHXJ49x+wZvCPA/mm47 6C6ujYCsfS5Bzi5XDurQ+Bn+x6QXB7Nouc2J6ixWwfr2NfaKXi9VjMDwtIXh4+SVB2Pe D6gA== X-Gm-Message-State: APjAAAWwzgA1hA7iWt0xT/soaRwZc6BbQeUXB3PHvWWR8WHLEfc0O0p9 XjvSlvAdUNvgb1vZd/qJX4xhwlL6 X-Google-Smtp-Source: APXvYqxWSvDj7/Oy3/9I3kBbMSnJAwcc5c9yeOtVsC8YZDtx6gsPl9+k2XeOxMBckhlgiDe8XZLSjg== X-Received: by 2002:ac2:51da:: with SMTP id u26mr4069062lfm.32.1556863737618; Thu, 02 May 2019 23:08:57 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id p19sm236464lfc.48.2019.05.02.23.08.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2019 23:08:56 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1hMRNc-0001iA-Qx; Fri, 03 May 2019 08:09:08 +0200 Date: Fri, 3 May 2019 08:09:08 +0200 From: Johan Hovold To: Greg Kroah-Hartman Cc: Johan Hovold , linux-usb@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH] USB: serial: io_edgeport: fix up switch fall-through comments Message-ID: <20190503060908.GY26546@localhost> References: <20190502173515.GA13801@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190502173515.GA13801@kroah.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190503060908.gL3yEle7NV9gzeriCAHGob-WUny6v3qlVWGzVmMAWcQ@z> On Thu, May 02, 2019 at 07:35:15PM +0200, Greg Kroah-Hartman wrote: > Gustavo has been working to fix up all of the switch statements that > "fall through" such that we can eventually turn on > -Wimplicit-fallthrough. As part of that, the io_edgeport.c driver is a > bit "messy" with the parsing logic of a data packet. Clean that logic > up a bit by unindenting one level of the logic, and properly label > /* Fall through */ to make gcc happy. > > Reported-by: Gustavo A. R. Silva > Signed-off-by: Greg Kroah-Hartman Now applied, thanks. Gustavo, how many of these warnings are there left in the kernel now that the last one in USB is gone? :) Johan