From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5955C43219 for ; Fri, 3 May 2019 08:11:42 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AC142075C for ; Fri, 3 May 2019 08:11:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qwuzjya+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AC142075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44wPwq5z2vzDqKw for ; Fri, 3 May 2019 18:11:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Qwuzjya+"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44wPQH02JyzDr1Q for ; Fri, 3 May 2019 17:48:38 +1000 (AEST) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00F1F205F4; Fri, 3 May 2019 07:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556869716; bh=HNdiThygh/WXsUKAjnlXN4y71aTiNppah2fty/UkA2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qwuzjya+tCbxUYHXP7cevwNxW24wM3tlVgItz3ZhijQzrUjMybEeaC/HJhFClVrYt X3WgDRi/h9WoRT0ccUXZ6CBZAfbHQ7HjpQhROSYkxQBpAqoJ1We6Bc1NO57kEon4aY pXKk8hDUfDqrCDvmhRfa/r3jh53toXYhLkHEJq9A= Date: Fri, 3 May 2019 09:48:34 +0200 From: Greg KH To: Andrew Donnellan Subject: Re: [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root Message-ID: <20190503074834.GA27088@kroah.com> References: <20190503074405.20708-1-ajd@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190503074405.20708-1-ajd@linux.ibm.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org, Stewart Smith , Jordan Niethe Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 03, 2019 at 05:44:05PM +1000, Andrew Donnellan wrote: > Currently the OPAL symbol map is globally readable, which seems bad as it > contains physical addresses. > > Restrict it to root. > > Suggested-by: Michael Ellerman > Cc: Jordan Niethe > Cc: Stewart Smith > Fixes: c8742f85125d ("powerpc/powernv: Expose OPAL firmware symbol map") > Cc: stable@vger.kernel.org > Signed-off-by: Andrew Donnellan > --- > arch/powerpc/platforms/powernv/opal.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c > index 2b0eca104f86..505460a72052 100644 > --- a/arch/powerpc/platforms/powernv/opal.c > +++ b/arch/powerpc/platforms/powernv/opal.c > @@ -681,7 +681,10 @@ static ssize_t symbol_map_read(struct file *fp, struct kobject *kobj, > bin_attr->size); > } > > -static BIN_ATTR_RO(symbol_map, 0); > +static struct bin_attribute symbol_map_attr = { > + .attr = {.name = "symbol_map", .mode = 0400}, > + .read = symbol_map_read > +}; > > static void opal_export_symmap(void) > { > @@ -698,10 +701,10 @@ static void opal_export_symmap(void) > return; > > /* Setup attributes */ > - bin_attr_symbol_map.private = __va(be64_to_cpu(syms[0])); > - bin_attr_symbol_map.size = be64_to_cpu(syms[1]); > + symbol_map_attr.private = __va(be64_to_cpu(syms[0])); no tab? checkpatch.pl is your friend :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48EFBC43219 for ; Fri, 3 May 2019 07:48:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D8C72089E for ; Fri, 3 May 2019 07:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556869718; bh=HNdiThygh/WXsUKAjnlXN4y71aTiNppah2fty/UkA2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bpI40cD/iqXXPg69CQSQ5Vmd/iK0GEIPnrsi4coQlyYdUHPU/TkbaaXtHeRqtlJdl XUwcdAFWLR6jTIClnLQgi6DYy9KhCP3o1MP97C93JRY9UJOrxb+ANijoSenPrUgzKQ Epd1P7g8absIaMa51poVp8N8usrsS8Jk+bpx3qPU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726560AbfECHsh (ORCPT ); Fri, 3 May 2019 03:48:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:55246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbfECHsh (ORCPT ); Fri, 3 May 2019 03:48:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00F1F205F4; Fri, 3 May 2019 07:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556869716; bh=HNdiThygh/WXsUKAjnlXN4y71aTiNppah2fty/UkA2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qwuzjya+tCbxUYHXP7cevwNxW24wM3tlVgItz3ZhijQzrUjMybEeaC/HJhFClVrYt X3WgDRi/h9WoRT0ccUXZ6CBZAfbHQ7HjpQhROSYkxQBpAqoJ1We6Bc1NO57kEon4aY pXKk8hDUfDqrCDvmhRfa/r3jh53toXYhLkHEJq9A= Date: Fri, 3 May 2019 09:48:34 +0200 From: Greg KH To: Andrew Donnellan Cc: linuxppc-dev@lists.ozlabs.org, Michael Ellerman , Jordan Niethe , Stewart Smith , stable@vger.kernel.org Subject: Re: [PATCH] powerpc/powernv: Restrict OPAL symbol map to only be readable by root Message-ID: <20190503074834.GA27088@kroah.com> References: <20190503074405.20708-1-ajd@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190503074405.20708-1-ajd@linux.ibm.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, May 03, 2019 at 05:44:05PM +1000, Andrew Donnellan wrote: > Currently the OPAL symbol map is globally readable, which seems bad as it > contains physical addresses. > > Restrict it to root. > > Suggested-by: Michael Ellerman > Cc: Jordan Niethe > Cc: Stewart Smith > Fixes: c8742f85125d ("powerpc/powernv: Expose OPAL firmware symbol map") > Cc: stable@vger.kernel.org > Signed-off-by: Andrew Donnellan > --- > arch/powerpc/platforms/powernv/opal.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c > index 2b0eca104f86..505460a72052 100644 > --- a/arch/powerpc/platforms/powernv/opal.c > +++ b/arch/powerpc/platforms/powernv/opal.c > @@ -681,7 +681,10 @@ static ssize_t symbol_map_read(struct file *fp, struct kobject *kobj, > bin_attr->size); > } > > -static BIN_ATTR_RO(symbol_map, 0); > +static struct bin_attribute symbol_map_attr = { > + .attr = {.name = "symbol_map", .mode = 0400}, > + .read = symbol_map_read > +}; > > static void opal_export_symmap(void) > { > @@ -698,10 +701,10 @@ static void opal_export_symmap(void) > return; > > /* Setup attributes */ > - bin_attr_symbol_map.private = __va(be64_to_cpu(syms[0])); > - bin_attr_symbol_map.size = be64_to_cpu(syms[1]); > + symbol_map_attr.private = __va(be64_to_cpu(syms[0])); no tab? checkpatch.pl is your friend :)