From: Wolfram Sang <wsa@the-dreams.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, Peter Rosin <peda@axentia.se>,
linux-renesas-soc@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2 1/2] i2c: core: ratelimit 'transfer when suspended' errors
Date: Fri, 3 May 2019 16:45:01 +0200 [thread overview]
Message-ID: <20190503144501.GC24385@kunai> (raw)
In-Reply-To: <20190425141948.29255-2-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Thu, Apr 25, 2019 at 04:19:47PM +0200, Wolfram Sang wrote:
> There are two problems with WARN_ON() here. One: It is not ratelimited.
> Two: We don't see which adapter was used when trying to transfer
> something when already suspended. Implement a custom ratelimit once per
> adapter and use dev_WARN there. This fixes both issues. Drawback is that
> we don't see if multiple drivers are trying to transfer with the same
> adapter while suspended. They need to be discovered one after the other
> now. This is better than a high CPU load because a really broken driver
> might try to resend endlessly.
>
> Fixes: 9ac6cb5fbb17 ("i2c: add suspended flag and accessors for i2c adapters")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-next, with stable tag for 5.1.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-03 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 14:19 [PATCH v2 0/2] i2c: core: improve reporting of a suspended adapter Wolfram Sang
2019-04-25 14:19 ` [PATCH v2 1/2] i2c: core: ratelimit 'transfer when suspended' errors Wolfram Sang
2019-04-26 9:44 ` Simon Horman
2019-05-03 14:45 ` Wolfram Sang [this message]
2019-04-25 14:19 ` [PATCH v2 2/2] i2c: core: apply 'is_suspended' check for SMBus, too Wolfram Sang
2019-04-26 9:44 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503144501.GC24385@kunai \
--to=wsa@the-dreams.de \
--cc=hdegoede@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.