From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [RFC PATCH 3/7] ABI: testing: Add description of soundwire master sysfs files Date: Sat, 4 May 2019 08:53:52 +0200 Message-ID: <20190504065352.GB9770@kroah.com> References: <20190504010030.29233-1-pierre-louis.bossart@linux.intel.com> <20190504010030.29233-4-pierre-louis.bossart@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190504010030.29233-4-pierre-louis.bossart@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org, liam.r.girdwood@linux.intel.com, jank@cadence.com, joe@perches.com, srinivas.kandagatla@linaro.org, Sanyog Kale List-Id: alsa-devel@alsa-project.org On Fri, May 03, 2019 at 08:00:26PM -0500, Pierre-Louis Bossart wrote: > The description is directly derived from the MIPI DisCo specification. > > Credits: this patch is based on an earlier internal contribution by > Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. > > Signed-off-by: Pierre-Louis Bossart > --- > .../ABI/testing/sysfs-bus-soundwire-master | 21 +++++++++++++++++++ > drivers/soundwire/sysfs.c | 1 + > 2 files changed, 22 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-soundwire-master > > diff --git a/Documentation/ABI/testing/sysfs-bus-soundwire-master b/Documentation/ABI/testing/sysfs-bus-soundwire-master > new file mode 100644 > index 000000000000..69cadf31049d > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-soundwire-master > @@ -0,0 +1,21 @@ > +What: /sys/bus/soundwire/devices/sdw-master-N/revision > + /sys/bus/soundwire/devices/sdw-master-N/clk_stop_modes > + /sys/bus/soundwire/devices/sdw-master-N/clk_freq > + /sys/bus/soundwire/devices/sdw-master-N/clk_gears > + /sys/bus/soundwire/devices/sdw-master-N/default_col > + /sys/bus/soundwire/devices/sdw-master-N/default_frame_rate > + /sys/bus/soundwire/devices/sdw-master-N/default_row > + /sys/bus/soundwire/devices/sdw-master-N/dynamic_shape > + /sys/bus/soundwire/devices/sdw-master-N/err_threshold > + /sys/bus/soundwire/devices/sdw-master-N/max_clk_freq > + > +Date: May 2019 > + > +Contact: Pierre-Louis Bossart > + > +Description: SoundWire Master-N DisCo properties. > + These properties are defined by MIPI DisCo Specification > + for SoundWire. They define various properties of the Master > + and are used by the bus to configure the Master. clk_stop_modes > + is a bitmask for simplifications and combines the > + clock-stop-mode0 and clock-stop-mode1 properties. > diff --git a/drivers/soundwire/sysfs.c b/drivers/soundwire/sysfs.c > index 734e2c8bc5cd..c2e5b7ad42fb 100644 > --- a/drivers/soundwire/sysfs.c > +++ b/drivers/soundwire/sysfs.c > @@ -31,6 +31,7 @@ struct sdw_master_sysfs { > * |---- clk_gears > * |---- default_row > * |---- default_col > + * |---- default_frame_shape > * |---- dynamic_shape > * |---- err_threshold > */ This last chunk should go in patch 1 of this series, right? thanks, greg k-h