From: Wei Yang <richardw.yang@linux.intel.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Stephen Checkoway" <stephen.checkoway@oberlin.edu>,
qemu-block@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org,
"Wei Yang" <richardw.yang@linux.intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] hw/block/pflash_cfi02: Add the DeviceReset() handler
Date: Mon, 6 May 2019 09:05:57 +0800 [thread overview]
Message-ID: <20190506010557.GB6343@richard> (raw)
In-Reply-To: <20190505200602.12412-6-philmd@redhat.com>
On Sun, May 05, 2019 at 10:06:02PM +0200, Philippe Mathieu-Daudé wrote:
>The pflash device is a child of TYPE_DEVICE, so it can implement
>the DeviceReset handler. Actually it has to implement it, else
>on machine reset it might stay in an incoherent state, as it has
>been reported in the buglink listed below.
>
>Add the DeviceReset handler and remove its call from the realize()
>function.
>
>Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1678713
>Reported-by: Laszlo Ersek <lersek@redhat.com>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Wei Yang <richardw.yang@linux.intel.com>
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-05-06 1:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 20:05 [Qemu-devel] [PATCH 0/5] hw/block/pflash: Add DeviceReset() handlers Philippe Mathieu-Daudé
2019-05-05 20:05 ` Philippe Mathieu-Daudé
2019-05-05 20:05 ` [Qemu-devel] [PATCH 1/5] hw/block/pflash_cfi01: Removed an unused timer Philippe Mathieu-Daudé
2019-05-05 20:05 ` Philippe Mathieu-Daudé
2019-05-06 0:50 ` Wei Yang
2019-05-06 14:39 ` Laszlo Ersek
2019-05-06 15:00 ` Philippe Mathieu-Daudé
2019-05-05 20:05 ` [Qemu-devel] [PATCH 2/5] hw/block/pflash_cfi01: Extract the pflash_reset() code Philippe Mathieu-Daudé
2019-05-05 20:05 ` Philippe Mathieu-Daudé
2019-05-06 0:54 ` Wei Yang
2019-05-06 14:49 ` Laszlo Ersek
2019-05-06 14:51 ` Laszlo Ersek
2019-05-05 20:06 ` [Qemu-devel] [PATCH 3/5] hw/block/pflash_cfi01: Add the DeviceReset() handler Philippe Mathieu-Daudé
2019-05-05 20:06 ` Philippe Mathieu-Daudé
2019-05-06 1:00 ` Wei Yang
2019-05-06 14:54 ` Laszlo Ersek
2019-05-05 20:06 ` [Qemu-devel] [PATCH 4/5] hw/block/pflash_cfi02: Extract the pflash_reset() code Philippe Mathieu-Daudé
2019-05-05 20:06 ` Philippe Mathieu-Daudé
2019-05-06 1:05 ` Wei Yang
2019-05-06 14:57 ` Laszlo Ersek
2019-05-06 15:03 ` Philippe Mathieu-Daudé
2019-05-05 20:06 ` [Qemu-devel] [PATCH 5/5] hw/block/pflash_cfi02: Add the DeviceReset() handler Philippe Mathieu-Daudé
2019-05-05 20:06 ` Philippe Mathieu-Daudé
2019-05-06 1:05 ` Wei Yang [this message]
2019-05-06 15:17 ` Laszlo Ersek
2019-05-06 18:32 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506010557.GB6343@richard \
--to=richardw.yang@linux.intel.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stephen.checkoway@oberlin.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.