From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: stable@vger.kernel.org, Erik Schmauss <erik.schmauss@intel.com>
Subject: Re: Possible mis-backport of 4abb951b in 4.19.35 ("ACPICA: AML interpreter: add region addresses...")
Date: Mon, 6 May 2019 10:41:45 +0200 [thread overview]
Message-ID: <20190506084145.GA23991@kroah.com> (raw)
In-Reply-To: <20190505194448.GA2649@windriver.com>
On Sun, May 05, 2019 at 03:44:48PM -0400, Paul Gortmaker wrote:
> I noticed 4.19.35 got a backport of mainline 4abb951b, but it appears to
> be a duplicate backport that landed in the wrong function. We can see
> this in the stable-queue repo:
>
> stable-queue$ find . -name '*acpica-aml-interpreter-add-region-addr*' |grep 4.19
> ./releases/4.19.6/acpica-aml-interpreter-add-region-addresses-in-global-list-during-initialization.patch
> ./releases/4.19.3/revert-acpica-aml-interpreter-add-region-addresses-in.patch
> ./releases/4.19.35/acpica-aml-interpreter-add-region-addresses-in-global-list-during-initialization.patch
> ./releases/4.19.2/acpica-aml-interpreter-add-region-addresses-in-global-list-during-initialization.patch
>
> So it was added to 4.19.2, reverted in .3, re-added in .6, and then
> finally patched into a similar looking but wrong function in .35
>
> If we diff the .6 and .35 versions, we see the function difference:
>
> -@@ -417,6 +417,10 @@ acpi_ds_eval_region_operands(struct acpi
> +@@ -523,6 +523,10 @@ acpi_ds_eval_table_region_operands(struc
>
> I don't know what the history is/was around the 2/3/6 churn, but the
> re-addition in 4.19.35 to a different function sure looks wrong.
>
> The commit adds a call "status = acpi_ut_add_address_range(..." and if
> we check mainline, there is only one in that file, but in 4.19.35+ there
> now are two calls - since the two functions had similar context and
> comments, it isn't hard to see how patch could/would apply it a 2nd time
> in the wrong place.
>
> I didn't check if any of the other currently maintained linux-stable
> versions also had this possible issue.
>
Ugh, Rafael, did I mess this up again? Can you check to see if I need
to fix this somehow?
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-06 8:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 19:44 Possible mis-backport of 4abb951b in 4.19.35 ("ACPICA: AML interpreter: add region addresses...") Paul Gortmaker
2019-05-06 8:41 ` Greg Kroah-Hartman [this message]
2019-05-15 1:17 ` Schmauss, Erik
2019-05-15 4:57 ` Greg Kroah-Hartman
2019-05-15 20:56 ` Rafael J. Wysocki
2019-05-16 0:45 ` Schmauss, Erik
2019-05-16 15:36 ` Rafael J. Wysocki
2019-05-16 17:21 ` Schmauss, Erik
2019-05-17 0:52 ` Sasha Levin
2019-05-17 21:15 ` Schmauss, Erik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506084145.GA23991@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=erik.schmauss@intel.com \
--cc=paul.gortmaker@windriver.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.