From: Stephen Hemminger <stephen@networkplumber.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, jiri@mellanox.com, mlxsw@mellanox.com,
Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH iproute2-master] devlink: Fix monitor command
Date: Mon, 6 May 2019 08:43:11 -0700 [thread overview]
Message-ID: <20190506084311.152bdcef@hermes.lan> (raw)
In-Reply-To: <20190505141243.9768-1-idosch@idosch.org>
On Sun, 5 May 2019 17:12:43 +0300
Ido Schimmel <idosch@idosch.org> wrote:
> From: Ido Schimmel <idosch@mellanox.com>
>
> The command is supposed to allow users to filter events related to
> certain objects, but returns an error when an object is specified:
>
> # devlink mon dev
> Command "dev" not found
>
> Fix this by allowing the command to process the specified objects.
>
> Example:
>
> # devlink/devlink mon dev &
> # echo "10 1" > /sys/bus/netdevsim/new_device
> [dev,new] netdevsim/netdevsim10
>
> # devlink/devlink mon port &
> # echo "11 1" > /sys/bus/netdevsim/new_device
> [port,new] netdevsim/netdevsim11/0: type notset flavour physical
> [port,new] netdevsim/netdevsim11/0: type eth netdev eth1 flavour physical
>
> # devlink/devlink mon &
> # echo "12 1" > /sys/bus/netdevsim/new_device
> [dev,new] netdevsim/netdevsim12
> [port,new] netdevsim/netdevsim12/0: type notset flavour physical
> [port,new] netdevsim/netdevsim12/0: type eth netdev eth2 flavour physical
>
> Fixes: a3c4b484a1ed ("add devlink tool")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Applied, thanks.
prev parent reply other threads:[~2019-05-06 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 14:12 [PATCH iproute2-master] devlink: Fix monitor command Ido Schimmel
2019-05-05 16:19 ` Jiri Pirko
2019-05-06 15:43 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506084311.152bdcef@hermes.lan \
--to=stephen@networkplumber.org \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.