From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Masney Subject: Re: [PATCH RFC 0/6] ARM: qcom: initial Nexus 5 display support Date: Mon, 6 May 2019 04:46:48 -0400 Message-ID: <20190506084648.GA270@basecamp> References: <20190505130413.32253-1-masneyb@onstation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Linus Walleij Cc: Sean Paul , Dave Airlie , MSM , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "open list:DRM PANEL DRIVERS" , Rob Clark , Daniel Vetter , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gTW9uLCBNYXkgMDYsIDIwMTkgYXQgMDg6NDI6MzZBTSArMDIwMCwgTGludXMgV2FsbGVpaiB3 cm90ZToKPiBPbiBTdW4sIE1heSA1LCAyMDE5IGF0IDM6MDQgUE0gQnJpYW4gTWFzbmV5IDxtYXNu ZXliQG9uc3RhdGlvbi5vcmc+IHdyb3RlOgo+IAo+ID4gbWRwNV9nZXRfc2Nhbm91dHBvcygpIGFu ZCBtZHA1X2dldF92YmxhbmtfY291bnRlcigpIGJvdGggcmV0dXJuIDAsIHdoaWNoCj4gPiBpcyBj YXVzaW5nIHRoaXMgc3RhY2sgdHJhY2UgdG8gYmUgZHVtcGVkIGludG8gdGhlIHN5c3RlbSBsb2cg c2V2ZXJhbAo+ID4gdGltZXM6Cj4gPgo+ID4gICAgIFdBUk5JTkc6IENQVTogMCBQSUQ6IDUgYXQg ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmM6MTQzMCBkcm1fYXRvbWljX2hlbHBl cl93YWl0X2Zvcl92YmxhbmtzLnBhcnQuMSsweDI4OC8weDI5MAo+ID4gICAgIFtDUlRDOjQ5OmNy dGMtMF0gdmJsYW5rIHdhaXQgdGltZWQgb3V0Cj4gPiAgICAgTW9kdWxlcyBsaW5rZWQgaW46Cj4g PiAgICAgQ1BVOiAwIFBJRDogNSBDb21tOiBrd29ya2VyLzA6MCBOb3QgdGFpbnRlZCA1LjEuMC1y YzYtbmV4dC0yMDE5MDQyNi0wMDAwNi1nMzVjMGQzMmE5NmUxLWRpcnR5ICMxOTEKPiA+ICAgICBI YXJkd2FyZSBuYW1lOiBHZW5lcmljIERUIGJhc2VkIHN5c3RlbQo+ID4gICAgIFdvcmtxdWV1ZTog ZXZlbnRzIGRlZmVycmVkX3Byb2JlX3dvcmtfZnVuYwo+ID4gICAgIFs8YzAzMTIyOWM+XSAodW53 aW5kX2JhY2t0cmFjZSkgZnJvbSBbPGMwMzBkNWFjPl0gKHNob3dfc3RhY2srMHgxMC8weDE0KQo+ ID4gICAgIFs8YzAzMGQ1YWM+XSAoc2hvd19zdGFjaykgZnJvbSBbPGMwYWMxMzRjPl0gKGR1bXBf c3RhY2srMHg3OC8weDhjKQo+ID4gICAgIFs8YzBhYzEzNGM+XSAoZHVtcF9zdGFjaykgZnJvbSBb PGMwMzIxNjYwPl0gKF9fd2Fybi5wYXJ0LjMrMHhiOC8weGQ0KQo+ID4gICAgIFs8YzAzMjE2NjA+ XSAoX193YXJuLnBhcnQuMykgZnJvbSBbPGMwMzIxNmUwPl0gKHdhcm5fc2xvd3BhdGhfZm10KzB4 NjQvMHg4OCkKPiA+ICAgICBbPGMwMzIxNmUwPl0gKHdhcm5fc2xvd3BhdGhfZm10KSBmcm9tIFs8 YzA3NjFhMGM+XSAoZHJtX2F0b21pY19oZWxwZXJfd2FpdF9mb3JfdmJsYW5rcy5wYXJ0LjErMHgy ODgvMHgyOTApCj4gPiAgICAgWzxjMDc2MWEwYz5dIChkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zv cl92YmxhbmtzLnBhcnQuMSkgZnJvbSBbPGMwN2IwYTk4Pl0gKG1kcDVfY29tcGxldGVfY29tbWl0 KzB4MTQvMHg0MCkKPiA+ICAgICBbPGMwN2IwYTk4Pl0gKG1kcDVfY29tcGxldGVfY29tbWl0KSBm cm9tIFs8YzA3ZGRiODA+XSAobXNtX2F0b21pY19jb21taXRfdGFpbCsweGE4LzB4MTQwKQo+ID4g ICAgIFs8YzA3ZGRiODA+XSAobXNtX2F0b21pY19jb21taXRfdGFpbCkgZnJvbSBbPGMwNzYzMzA0 Pl0gKGNvbW1pdF90YWlsKzB4NDAvMHg2YykKPiA+ICAgICBbPGMwNzYzM2Y0Pl0gKGRybV9hdG9t aWNfaGVscGVyX2NvbW1pdCkgZnJvbSBbPGMwNzY2N2YwPl0gKHJlc3RvcmVfZmJkZXZfbW9kZV9h dG9taWMrMHgxNjgvMHgxZDQpCj4gCj4gSSByZWNlbnRseSBtZXJnZWQgdGhpcyBwYXRjaDoKPiBo dHRwczovL2NnaXQuZnJlZWRlc2t0b3Aub3JnL2RybS9kcm0tbWlzYy9jb21taXQvP2lkPWIzMTk4 YzM4ZjAyZDU0YTVlOTY0MjU4YTIxODBkNTAyYWJlNmVhZjAKPiAKPiBJIG5vdGljZWQgdGhhdCBE U0kgaXMgc29tZXRpbWVzIHdheSBzbG93ZXIgdGhhbiBhIG1vbml0b3IsIGV2ZW4gIGluIEhTIG1v ZGUuCj4gT24gdGhlIE1DREUgdGhpcyBoYXBwZW5lZCBvbiB0aGUgZmlyc3Qgc2NyZWVuIHVwZGF0 ZSwgd2hpY2ggd2FzIHNsb3dlcgo+IHRoYW4gNTBtcy4KPiAKPiBDaGVjayBpZiB5b3VyIHZibGFu a3MgYXJlIHNpbXBseSBzbG93LCB0cnkgYnVtcGluZyB0aGlzIHRpbWVvdXQgZXZlbiBoaWdoZXIs Cj4gSSBzcGVudCB3ZWVrcyBmaW5kaW5nIHRoaXMgaXNzdWUgd2hpY2ggYm9pbHMgZG93biB0byBh biBhc3N1bXB0aW9uIHRoYXQKPiB0aGUgdmJsYW5rIHdpbGwgYmUgZmlyZWQgZnJvbSBzb21ldGhp bmcgbGlrZSBhIG1vbml0b3IgYXQgNTAgb3IgNjAgSFoKPiB+MjAgbXMgc28gNTBtcyBzZWVtZWQg bGlrZSBhIGdvb2QgdGltZW91dCBhdCB0aGUgdGltZS4KPiAKPiBPbiBhIERTSSBkaXNwbGF5IHRo aXMgaXMgZHViaW91cywgYWJzb2x1dGVseSBpbiBMUCBtb2RlLCBhbmQgZXZlbgo+IGluIEhTIG1v ZGUuCgpUaGF0IGRpZCBub3QgZml4IHRoZSBpc3N1ZSBmb3IgbWUsIGFuZCBJIHdlbnQgYXMgaGln aCBhcyA1IHNlY29uZHMuClRoYXQncyBnb29kIHRvIGtub3cgdGhvdWdoIHNpbmNlIEkgd291bGQg aGF2ZSBsaWtlbHkgcmFuIGludG8gdGhhdCBzYW1lCmlzc3VlIGRvd24gdGhlIGxpbmUuCgpCcmlh bgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJl bm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F33E6C04AAA for ; Mon, 6 May 2019 08:46:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C149F205C9 for ; Mon, 6 May 2019 08:46:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="MbrvW8fl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725883AbfEFIqu (ORCPT ); Mon, 6 May 2019 04:46:50 -0400 Received: from onstation.org ([52.200.56.107]:48060 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbfEFIqu (ORCPT ); Mon, 6 May 2019 04:46:50 -0400 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id ADD7F3E941; Mon, 6 May 2019 08:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1557132409; bh=xI56e4hzg4jsRuD6zEwMlE664g9qNhVDQ6VNP1rTbBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MbrvW8flOyL19oI0XQSJXHxCE4aknvmEvXhDIrAnh2i+7wuAD1LOHt7sh+PzCSKsZ 6w54mSq6UnjAv9pT7IriI5tFztg2ea6akIdw++qmqmwJAItsPw4o6CkTgYry+K6eqJ bI0/YPJ1okYTxaDvcGPjj3HqDlx8j3eEeBrTA90U= Date: Mon, 6 May 2019 04:46:48 -0400 From: Brian Masney To: Linus Walleij Cc: Rob Clark , Sean Paul , "open list:DRM PANEL DRIVERS" , MSM , freedreno@lists.freedesktop.org, Dave Airlie , Daniel Vetter , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RFC 0/6] ARM: qcom: initial Nexus 5 display support Message-ID: <20190506084648.GA270@basecamp> References: <20190505130413.32253-1-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Message-ID: <20190506084648.TIs4M1bNY4eZzXaxB29LNI_9dIx3L_zIh-OOJGWfG4M@z> On Mon, May 06, 2019 at 08:42:36AM +0200, Linus Walleij wrote: > On Sun, May 5, 2019 at 3:04 PM Brian Masney wrote: > > > mdp5_get_scanoutpos() and mdp5_get_vblank_counter() both return 0, which > > is causing this stack trace to be dumped into the system log several > > times: > > > > WARNING: CPU: 0 PID: 5 at drivers/gpu/drm/drm_atomic_helper.c:1430 drm_atomic_helper_wait_for_vblanks.part.1+0x288/0x290 > > [CRTC:49:crtc-0] vblank wait timed out > > Modules linked in: > > CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 5.1.0-rc6-next-20190426-00006-g35c0d32a96e1-dirty #191 > > Hardware name: Generic DT based system > > Workqueue: events deferred_probe_work_func > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > [] (show_stack) from [] (dump_stack+0x78/0x8c) > > [] (dump_stack) from [] (__warn.part.3+0xb8/0xd4) > > [] (__warn.part.3) from [] (warn_slowpath_fmt+0x64/0x88) > > [] (warn_slowpath_fmt) from [] (drm_atomic_helper_wait_for_vblanks.part.1+0x288/0x290) > > [] (drm_atomic_helper_wait_for_vblanks.part.1) from [] (mdp5_complete_commit+0x14/0x40) > > [] (mdp5_complete_commit) from [] (msm_atomic_commit_tail+0xa8/0x140) > > [] (msm_atomic_commit_tail) from [] (commit_tail+0x40/0x6c) > > [] (drm_atomic_helper_commit) from [] (restore_fbdev_mode_atomic+0x168/0x1d4) > > I recently merged this patch: > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=b3198c38f02d54a5e964258a2180d502abe6eaf0 > > I noticed that DSI is sometimes way slower than a monitor, even in HS mode. > On the MCDE this happened on the first screen update, which was slower > than 50ms. > > Check if your vblanks are simply slow, try bumping this timeout even higher, > I spent weeks finding this issue which boils down to an assumption that > the vblank will be fired from something like a monitor at 50 or 60 HZ > ~20 ms so 50ms seemed like a good timeout at the time. > > On a DSI display this is dubious, absolutely in LP mode, and even > in HS mode. That did not fix the issue for me, and I went as high as 5 seconds. That's good to know though since I would have likely ran into that same issue down the line. Brian