Re: [Qemu-devel] [PATCH] hw/rdma: Add support for GID state changes for non-qmp frameworks

[Yuval Shaia <yuval.shaia@oracle.com>]

On Mon, May 06, 2019 at 10:09:29AM -0500, Eric Blake wrote:
> On 5/5/19 5:55 AM, Yuval Shaia wrote:
> > Any GID change in guest must be propogate to host. This is already done
> 
> s/propogate to/propagated to the/
> 
> > by firing QMP event to managment system such as libvirt which in turn
> 
> s/managment/management/
> 
> > will update the host with the relevant change.
> > 
> > When qemu is executed on non-qmp framework (ex from command-line) we
> > need to update the host instead.
> > Fix it by adding support to update the RoCE device's Ethernet function
> > IP list from qemu via netlink.
> > 
> > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> > ---
> >  configure              |  6 ++++
> >  hw/rdma/rdma_backend.c | 74 +++++++++++++++++++++++++++++++++++++++++-
> >  2 files changed, 79 insertions(+), 1 deletion(-)
> > 
> 
> > @@ -1123,7 +1183,13 @@ int rdma_backend_add_gid(RdmaBackendDev *backend_dev, const char *ifname,
> >                                              gid->global.subnet_prefix,
> >                                              gid->global.interface_id);
> >  
> > -    return ret;
> > +    /*
> > +     * We ignore return value since operation might completed sucessfully
> 
> s/completed sucessfully/have completed successfully/
> 
> > +     * by the QMP consumer
> > +     */
> > +    netlink_route_update(ifname, gid, RTM_NEWADDR);
> > +
> > +    return 0;
> >  }
> >  
> >  int rdma_backend_del_gid(RdmaBackendDev *backend_dev, const char *ifname,
> > @@ -1149,6 +1215,12 @@ int rdma_backend_del_gid(RdmaBackendDev *backend_dev, const char *ifname,
> >                                              gid->global.subnet_prefix,
> >                                              gid->global.interface_id);
> >  
> > +    /*
> > +     * We ignore return value since operation might completed sucessfully
> 
> and again

Thanks for the spelling mistake corrections.
Will fix and respin.

> 
> > +     * by the QMP consumer
> > +     */
> > +    netlink_route_update(ifname, gid, RTM_DELADDR);
> > +
> >      return 0;
> >  }
> >  
> > 
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>