From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 02/15] board/qemu/ppc*: disable Werror while building ppc kernel with gcc >= 9.1
Date: Mon, 6 May 2019 22:01:55 +0200 [thread overview]
Message-ID: <20190506200155.GC6887@scaer> (raw)
In-Reply-To: <7a5d0c4c-abe5-b7e4-4ea1-160fc2be3a5f@gmail.com>
Romain, All,
On 2019-05-06 21:57 +0200, Romain Naour spake thusly:
> Le 06/05/2019 ? 21:49, Yann E. MORIN a ?crit?:
> > On 2019-05-06 20:29 +0200, Romain Naour spake thusly:
> >> From patch [1] included in kernel >= 5.0:
> >> "The upcoming GCC 9 release extends the -Wmissing-attributes warnings
> >> (enabled by -Wall) to C and aliases: it warns when particular function
> >> attributes are missing in the aliases but not in their target.
[--SNIP--]
> >> Add CONFIG_PPC_DISABLE_WERROR only for qemu ppc{64} defconfig
> >> since they are used for CI with toolchain-builder's gitlab [3].
> >
> > When you introduce gcc-9 later in the series, itis not the default
> > compiler, so it will not be selected for these defconfigs.
> >
> > So, I don't think we need this change (yet).
> >
> > If we decide to update these defconfigs to use the latest gcc-9, later,
> > then that would be the moment to include the fix.
>
> This fix is required for toolchain-builder that use a bleeding-edge toolchain.
> Since we test the new toolchain by building a small rootfs + a kernel Linux for
> Qemu, we really need this fix before introducing gcc 9.1.
Then it should be that toolchain-builder that is responsible to provide
the fragment, no?
The defconfigs as they are in Buildroot do not need it, so I fail to
understand why we, in Buildroot, would need that.
Regards,
Yann E. MORIN.
> Best regards,
> Romain
>
> >
> > Regards,
> > Yann E. MORIN.
> >
> >> Fixes:
> >> https://gitlab.com/kubu93/toolchains-builder/-/jobs/205435741
> >>
> >> [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=a6e60d84989fa0e91db7f236eda40453b0e44afa
> >> [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=ba55bd74360ea4b8b95e73ed79474d37ff482b36
> >> [3] https://gitlab.com/bootlin/toolchains-builder
> >>
> >> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> >> ---
> >> Note: It can be usefull to select CONFIG_PPC_DISABLE_WERROR for
> >> other ppc board defconfig.
> >>
> >> v2: add a shared fragment in board/fragments/linux and update
> >> qemu ppc* defconfigs. (Arnout)
> >> ---
> >> board/fragments/linux/linux-ppc-disable-werror.fragment | 1 +
> >> configs/qemu_ppc64_e5500_defconfig | 2 +-
> >> configs/qemu_ppc64_pseries_defconfig | 1 +
> >> configs/qemu_ppc64le_pseries_defconfig | 1 +
> >> configs/qemu_ppc_g3beige_defconfig | 1 +
> >> configs/qemu_ppc_mpc8544ds_defconfig | 1 +
> >> configs/qemu_ppc_virtex_ml507_defconfig | 1 +
> >> 7 files changed, 7 insertions(+), 1 deletion(-)
> >> create mode 100644 board/fragments/linux/linux-ppc-disable-werror.fragment
> >>
> >> diff --git a/board/fragments/linux/linux-ppc-disable-werror.fragment b/board/fragments/linux/linux-ppc-disable-werror.fragment
> >> new file mode 100644
> >> index 0000000000..6ea12a1243
> >> --- /dev/null
> >> +++ b/board/fragments/linux/linux-ppc-disable-werror.fragment
> >> @@ -0,0 +1 @@
> >> +CONFIG_PPC_DISABLE_WERROR=y
> >> diff --git a/configs/qemu_ppc64_e5500_defconfig b/configs/qemu_ppc64_e5500_defconfig
> >> index 59b8636918..624155316c 100644
> >> --- a/configs/qemu_ppc64_e5500_defconfig
> >> +++ b/configs/qemu_ppc64_e5500_defconfig
> >> @@ -13,7 +13,7 @@ BR2_LINUX_KERNEL=y
> >> BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> >> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
> >> BR2_LINUX_KERNEL_DEFCONFIG="corenet64_smp"
> >> -BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/ppc64-e5500/linux.fragment"
> >> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/qemu/ppc64-e5500/linux.fragment board/fragments/linux/linux-ppc-disable-werror.fragment"
> >> BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> >>
> >> # Filesystem
> >> diff --git a/configs/qemu_ppc64_pseries_defconfig b/configs/qemu_ppc64_pseries_defconfig
> >> index 5f55b246f7..277d08989a 100644
> >> --- a/configs/qemu_ppc64_pseries_defconfig
> >> +++ b/configs/qemu_ppc64_pseries_defconfig
> >> @@ -19,3 +19,4 @@ BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> >> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
> >> BR2_LINUX_KERNEL_DEFCONFIG="pseries"
> >> BR2_LINUX_KERNEL_VMLINUX=y
> >> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/fragments/linux/linux-ppc-disable-werror.fragment"
> >> diff --git a/configs/qemu_ppc64le_pseries_defconfig b/configs/qemu_ppc64le_pseries_defconfig
> >> index 8356e4e250..1848667abf 100644
> >> --- a/configs/qemu_ppc64le_pseries_defconfig
> >> +++ b/configs/qemu_ppc64le_pseries_defconfig
> >> @@ -19,3 +19,4 @@ BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> >> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
> >> BR2_LINUX_KERNEL_DEFCONFIG="pseries_le"
> >> BR2_LINUX_KERNEL_VMLINUX=y
> >> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/fragments/linux/linux-ppc-disable-werror.fragment"
> >> diff --git a/configs/qemu_ppc_g3beige_defconfig b/configs/qemu_ppc_g3beige_defconfig
> >> index 4b2f3ed2fe..c8bbd74ada 100644
> >> --- a/configs/qemu_ppc_g3beige_defconfig
> >> +++ b/configs/qemu_ppc_g3beige_defconfig
> >> @@ -18,6 +18,7 @@ BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> >> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
> >> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> >> BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/ppc-g3beige/linux.config"
> >> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/fragments/linux/linux-ppc-disable-werror.fragment"
> >> BR2_LINUX_KERNEL_VMLINUX=y
> >>
> >> # Serial port config
> >> diff --git a/configs/qemu_ppc_mpc8544ds_defconfig b/configs/qemu_ppc_mpc8544ds_defconfig
> >> index 98985b7b76..68a9e80e93 100644
> >> --- a/configs/qemu_ppc_mpc8544ds_defconfig
> >> +++ b/configs/qemu_ppc_mpc8544ds_defconfig
> >> @@ -18,6 +18,7 @@ BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> >> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
> >> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> >> BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/ppc-mpc8544ds/linux.config"
> >> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/fragments/linux/linux-ppc-disable-werror.fragment"
> >> BR2_LINUX_KERNEL_VMLINUX=y
> >>
> >> # Serial port config
> >> diff --git a/configs/qemu_ppc_virtex_ml507_defconfig b/configs/qemu_ppc_virtex_ml507_defconfig
> >> index eddaf3558a..2a127ed70d 100644
> >> --- a/configs/qemu_ppc_virtex_ml507_defconfig
> >> +++ b/configs/qemu_ppc_virtex_ml507_defconfig
> >> @@ -18,6 +18,7 @@ BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> >> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
> >> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> >> BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/ppc-virtex-ml507/linux.config"
> >> +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/fragments/linux/linux-ppc-disable-werror.fragment"
> >> BR2_LINUX_KERNEL_VMLINUX=y
> >> BR2_LINUX_KERNEL_DTS_SUPPORT=y
> >> BR2_LINUX_KERNEL_INTREE_DTS_NAME="virtex440-ml507"
> >> --
> >> 2.14.5
> >>
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot at busybox.net
> >> http://lists.busybox.net/mailman/listinfo/buildroot
> >
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-05-06 20:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 18:29 [Buildroot] [PATCH 00/15] Add gcc 9.1 Romain Naour
2019-05-06 18:29 ` [Buildroot] [PATCH 01/15] package/glibc/arc: fix build issue with gcc-9.1 Romain Naour
2019-05-06 19:40 ` Yann E. MORIN
2019-05-08 11:12 ` Alexey Brodkin
2019-05-08 13:27 ` Romain Naour
2019-05-08 14:05 ` Alexey Brodkin
2019-05-06 18:29 ` [Buildroot] [PATCH 02/15] board/qemu/ppc*: disable Werror while building ppc kernel with gcc >= 9.1 Romain Naour
2019-05-06 19:49 ` Yann E. MORIN
2019-05-06 19:57 ` Romain Naour
2019-05-06 20:01 ` Yann E. MORIN [this message]
2019-05-07 8:26 ` Romain Naour
2019-05-08 12:01 ` Yann E. MORIN
2019-05-08 13:29 ` Romain Naour
2019-05-06 18:29 ` [Buildroot] [PATCH 03/15] [RFC] package/uclibc: remove asm constraint Romain Naour
2019-05-06 18:30 ` [Buildroot] [PATCH 04/15] arch: add BR2_ARCH_NEEDS_GCC_AT_LEAST_9 Romain Naour
2019-05-06 20:07 ` Yann E. MORIN
2019-05-06 18:30 ` [Buildroot] [PATCH 05/15] toolchain: add gcc 9 entry Romain Naour
2019-05-06 18:30 ` [Buildroot] [PATCH 06/15] package/gcc: add support for gcc 9.1 Romain Naour
2019-05-06 20:09 ` Yann E. MORIN
2019-05-06 18:30 ` [Buildroot] [PATCH 07/15] toolchain-external: add gcc 9 entry Romain Naour
2019-05-06 18:30 ` [Buildroot] [PATCH 08/15] package/gcc: switch to gcc 8.x as the default Romain Naour
2019-05-06 20:15 ` Yann E. MORIN
2019-05-06 18:30 ` [Buildroot] [PATCH 09/15] arch/arm: move dependency on 64-bit down to individual cores Romain Naour
2019-05-06 18:30 ` [Buildroot] [PATCH 10/15] arch/arm: some cores have a different name with gcc-9 Romain Naour
2019-05-06 18:30 ` [Buildroot] [PATCH 11/15] arch/arm: saphira is in fact an armv8.4a Romain Naour
2019-05-06 18:30 ` [Buildroot] [PATCH 12/15] arch/arm: add two new 64-bit-only armv8a cores Romain Naour
2019-05-06 18:30 ` [Buildroot] [PATCH 13/15] arch/arm: add two new cortex-based armv8.2a cores Romain Naour
2019-05-06 18:30 ` [Buildroot] [PATCH 14/15] arch/arm: add two new non-cortex-based " Romain Naour
2019-05-06 18:30 ` [Buildroot] [PATCH 15/15] package/gcc: enable gcc 9.1 for ork1 (openrisc) Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506200155.GC6887@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.