From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64025C004C9 for ; Tue, 7 May 2019 06:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BC9020989 for ; Tue, 7 May 2019 06:20:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726357AbfEGGUg (ORCPT ); Tue, 7 May 2019 02:20:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:43328 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726253AbfEGGUg (ORCPT ); Tue, 7 May 2019 02:20:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 70BC7AD2C; Tue, 7 May 2019 06:20:35 +0000 (UTC) Date: Tue, 7 May 2019 08:20:34 +0200 From: Johannes Thumshirn To: Minwoo Im Cc: Chaitanya Kulkarni , Omar Sandoval , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" Subject: Re: [PATCH 1/3] nvme: 002: fix nvmet pass data with loop Message-ID: <20190507062034.GA3748@x250> References: <20190505150611.15776-1-minwoo.im.dev@gmail.com> <20190505150611.15776-2-minwoo.im.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, May 07, 2019 at 01:54:09AM +0900, Minwoo Im wrote: > If Johannes who wrote these tests agrees to not check output result from > nvme-cli, I'll get rid of them. Yes agreed. In the beginning I though of validating the nvme-cli output but this would grow more and more filters, which makes it impractical. -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 From mboxrd@z Thu Jan 1 00:00:00 1970 From: jthumshirn@suse.de (Johannes Thumshirn) Date: Tue, 7 May 2019 08:20:34 +0200 Subject: [PATCH 1/3] nvme: 002: fix nvmet pass data with loop In-Reply-To: References: <20190505150611.15776-1-minwoo.im.dev@gmail.com> <20190505150611.15776-2-minwoo.im.dev@gmail.com> Message-ID: <20190507062034.GA3748@x250> On Tue, May 07, 2019@01:54:09AM +0900, Minwoo Im wrote: > If Johannes who wrote these tests agrees to not check output result from > nvme-cli, I'll get rid of them. Yes agreed. In the beginning I though of validating the nvme-cli output but this would grow more and more filters, which makes it impractical. -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn at suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Mary Higgins, Sri Rasiah HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850