All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4] cmd: gpt: fix and tidy up help message
Date: Tue, 7 May 2019 09:01:25 +0200	[thread overview]
Message-ID: <20190507090125.25b24b26@jawa> (raw)
In-Reply-To: <20190502122706.27592-4-erosca@de.adit-jv.com>

On Thu, 2 May 2019 14:27:05 +0200
Eugeniu Rosca <erosca@de.adit-jv.com> wrote:

> Apply the following changes:
>  - Guard the 'gpt read' command by 'ifdef CONFIG_CMD_GPT_RENAME',
>    since 'gpt read' is not available on CMD_GPT_RENAME=n
>  - Prefix the {read,swap,rename} commands with one space for
> consistency
>  - Prefix the 'guid' commands with 'gpt' for consistency
> 
> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> --
> v2:
>  - Added Reviewed-by: Heinrich Schuchardt
> v1:
>  - https://patchwork.ozlabs.org/patch/1092944/
> ---
>  cmd/gpt.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/cmd/gpt.c b/cmd/gpt.c
> index 638870352f40..33cda513969f 100644
> --- a/cmd/gpt.c
> +++ b/cmd/gpt.c
> @@ -876,21 +876,21 @@ U_BOOT_CMD(gpt, CONFIG_SYS_MAXARGS, 1, do_gpt,
>  	" Example usage:\n"
>  	" gpt write mmc 0 $partitions\n"
>  	" gpt verify mmc 0 $partitions\n"
> -	" read <interface> <dev>\n"
> -	"    - read GPT into a data structure for manipulation\n"
> -	" guid <interface> <dev>\n"
> +	" gpt guid <interface> <dev>\n"
>  	"    - print disk GUID\n"
> -	" guid <interface> <dev> <varname>\n"
> +	" gpt guid <interface> <dev> <varname>\n"
>  	"    - set environment variable to disk GUID\n"
>  	" Example usage:\n"
>  	" gpt guid mmc 0\n"
>  	" gpt guid mmc 0 varname\n"
>  #ifdef CONFIG_CMD_GPT_RENAME
>  	"gpt partition renaming commands:\n"
> -	"gpt swap <interface> <dev> <name1> <name2>\n"
> +	" gpt read <interface> <dev>\n"
> +	"    - read GPT into a data structure for manipulation\n"
> +	" gpt swap <interface> <dev> <name1> <name2>\n"
>  	"    - change all partitions named name1 to name2\n"
>  	"      and vice-versa\n"
> -	"gpt rename <interface> <dev> <part> <name>\n"
> +	" gpt rename <interface> <dev> <part> <name>\n"
>  	"    - rename the specified partition\n"
>  	" Example usage:\n"
>  	" gpt swap mmc 0 foo bar\n"

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190507/d4531ba8/attachment.sig>

  reply	other threads:[~2019-05-07  7:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02 12:27 [U-Boot] [PATCH v2 0/4] Misc EFI/GPT/UUID fixes Eugeniu Rosca
2019-05-02 12:27 ` [U-Boot] [PATCH v2 1/4] disk: efi: Fix memory leak on 'gpt guid' Eugeniu Rosca
2019-05-07  7:03   ` Lukasz Majewski
2019-05-07  7:10     ` Eugeniu Rosca
2019-05-07  8:11       ` Lukasz Majewski
2019-05-07 12:08         ` Eugeniu Rosca
2019-05-02 12:27 ` [U-Boot] [PATCH v2 2/4] disk: efi: Fix memory leak on 'gpt verify' Eugeniu Rosca
2019-05-07  7:02   ` Lukasz Majewski
2019-05-02 12:27 ` [U-Boot] [PATCH v2 3/4] cmd: gpt: fix and tidy up help message Eugeniu Rosca
2019-05-07  7:01   ` Lukasz Majewski [this message]
2019-05-02 12:27 ` [U-Boot] [PATCH v2 4/4] lib: uuid: Fix unseeded PRNG on RANDOM_UUID=y Eugeniu Rosca
2019-05-02 16:19   ` Heinrich Schuchardt
2019-05-07  7:04   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190507090125.25b24b26@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.