From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
peter_hong@fintek.com.tw, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V9 4/4] USB: serial: f81232: implement break control
Date: Tue, 7 May 2019 11:16:36 +0200 [thread overview]
Message-ID: <20190507091636.GE4333@localhost> (raw)
In-Reply-To: <84cff579-79bd-9456-aa85-cb4510d916ed@gmail.com>
On Mon, May 06, 2019 at 10:52:27AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> > You forgot to update shadow_lcr here so the line settings would be
> > corrupted (e.g set to 5 bit words) whenever a break is signalled.
> >
> > Did you not test this version of the patch?
> >
> > I added the missing update, but please test the code that's in my
> > usb-next branch in a minute and confirm everything works as expected.
> >
>
> Thanks for mention and patch the lost parts. I had only tested the
> break signal and forgot to test full LCR. I'll add it to my test items
> and it tested well on new usb-next branch after your fix.
Thanks for confirming!
> BTW, Should I disable break control when port close ?
Yes, that would be good even if many tty drivers currently fail to do
so.
Johan
next prev parent reply other threads:[~2019-05-07 9:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 1:22 [V9,1/4] USB: serial: f81232: fix interrupt worker not stop Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [PATCH V9 1/4] " Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [V9,4/4] USB: serial: f81232: implement break control Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [PATCH V9 4/4] " Ji-Ze Hong (Peter Hong)
2019-05-03 6:59 ` [V9,4/4] " Johan Hovold
2019-05-03 6:59 ` [PATCH V9 4/4] " Johan Hovold
2019-05-06 2:52 ` [V9,4/4] " Ji-Ze Hong (Peter Hong)
2019-05-06 2:52 ` [PATCH V9 4/4] " Ji-Ze Hong (Peter Hong)
2019-05-07 9:16 ` Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-30 1:22 [V9,2/4] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [PATCH V9 2/4] " Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 [V9,3/4] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2019-04-30 1:22 ` [PATCH V9 3/4] " Ji-Ze Hong (Peter Hong)
2019-05-03 6:53 [V9,1/4] USB: serial: f81232: fix interrupt worker not stop Johan Hovold
2019-05-03 6:53 ` [PATCH V9 1/4] " Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507091636.GE4333@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.