From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Ruslan Babayev <ruslan@babayev.com>
Cc: linux@armlinux.org.uk, andrew@lunn.ch, f.fainelli@gmail.com,
hkallweit1@gmail.com, wsa@the-dreams.de, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
xe-linux-external@cisco.com
Subject: Re: [PATCH net-next 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems
Date: Tue, 7 May 2019 12:29:46 +0300 [thread overview]
Message-ID: <20190507092946.GS2895@lahna.fi.intel.com> (raw)
In-Reply-To: <871s1bv4aw.fsf@babayev.com>
On Mon, May 06, 2019 at 11:14:15AM -0700, Ruslan Babayev wrote:
>
> Mika Westerberg writes:
>
> > On Sun, May 05, 2019 at 03:05:23PM -0700, Ruslan Babayev wrote:
> >> Lookup I2C adapter using the "i2c-bus" device property on ACPI based
> >> systems similar to how it's done with DT.
> >>
> >> An example DSD describing an SFP on an ACPI based system:
> >>
> >> Device (SFP0)
> >> {
> >> Name (_HID, "PRP0001")
> >> Name (_DSD, Package ()
> >> {
> >> ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> >> Package () {
> >> Package () { "compatible", "sff,sfp" },
> >> Package () { "i2c-bus", \_SB.PCI0.RP01.I2C.MUX.CH0 },
> >
> > Hmm, ACPI has I2cSerialBusV2() resource for this purpose. Why you are not
> > using that?
>
> I am not an ACPI expert, but my understanding is I2cSerialBusV2() is
> used for slave connections. I am trying to reference an I2C controller
> here.
Ah, the device itself is not sitting on an I2C bus? In that case I
agree, I2CSerialBusV2() is not correct here.
next prev parent reply other threads:[~2019-05-07 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 22:05 [PATCH net-next 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems Ruslan Babayev
2019-05-06 4:59 ` Mika Westerberg
2019-05-06 18:14 ` Ruslan Babayev
2019-05-07 9:29 ` Mika Westerberg [this message]
2019-05-07 10:40 ` Russell King - ARM Linux admin
2019-05-06 19:40 ` Andrew Lunn
2019-05-07 9:34 ` Mika Westerberg
2019-05-06 12:55 ` Andrew Lunn
2019-05-06 19:06 ` Ruslan Babayev
2019-05-06 19:33 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507092946.GS2895@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=ruslan@babayev.com \
--cc=wsa@the-dreams.de \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.