From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbusch@kernel.org (Keith Busch) Date: Tue, 7 May 2019 08:21:17 -0600 Subject: [PATCH] nvme-pci: mark expected switch fall-through In-Reply-To: <20190507142300.GA25717@embeddedor> References: <20190507142300.GA25717@embeddedor> Message-ID: <20190507142117.GE2219@localhost.localdomain> On Tue, May 07, 2019@09:23:00AM -0500, Gustavo A. R. Silva wrote: > @@ -1296,6 +1296,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved) > switch (dev->ctrl.state) { > case NVME_CTRL_DELETING: > shutdown = true; > + /* fall through */ > case NVME_CTRL_CONNECTING: > case NVME_CTRL_RESETTING: > dev_warn_ratelimited(dev->ctrl.device, Thanks, Looks good. Reviewed-by: Keith Busch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817DCC004C9 for ; Tue, 7 May 2019 14:26:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EECD20989 for ; Tue, 7 May 2019 14:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557239214; bh=jvW/RogS5UCoRbdKhxoGxh1J+GRr7o3WjwzEAYCw46o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Fhi8vrss1nNMdZM4UQcB03b2xCEionYSGYEtiJOSaE4E//I8sTkh9AjSAbnnuqtWu ge+fF3PDg+njqU+RbnHLvSbLPKthK5xqDr4ioNhRPhxwtXWP6yZkP7qjl+34kNj3oU R7yHQdl1TABlte6NccaSzeRjOm2LSVXKMR13ZkNw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbfEGO0x (ORCPT ); Tue, 7 May 2019 10:26:53 -0400 Received: from mga07.intel.com ([134.134.136.100]:16286 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbfEGO0w (ORCPT ); Tue, 7 May 2019 10:26:52 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2019 07:26:52 -0700 X-ExtLoop1: 1 Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by FMSMGA003.fm.intel.com with ESMTP; 07 May 2019 07:26:51 -0700 Date: Tue, 7 May 2019 08:21:17 -0600 From: Keith Busch To: "Gustavo A. R. Silva" Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH] nvme-pci: mark expected switch fall-through Message-ID: <20190507142117.GE2219@localhost.localdomain> References: <20190507142300.GA25717@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190507142300.GA25717@embeddedor> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 07, 2019 at 09:23:00AM -0500, Gustavo A. R. Silva wrote: > @@ -1296,6 +1296,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved) > switch (dev->ctrl.state) { > case NVME_CTRL_DELETING: > shutdown = true; > + /* fall through */ > case NVME_CTRL_CONNECTING: > case NVME_CTRL_RESETTING: > dev_warn_ratelimited(dev->ctrl.device, Thanks, Looks good. Reviewed-by: Keith Busch