From: Andrew Lunn <andrew@lunn.ch>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, peter@korsgaard.com,
palmer@sifive.com, paul.walmsley@sifive.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 v2 1/3] dt-bindings: i2c: extend existing opencore bindings.
Date: Tue, 7 May 2019 17:24:41 +0200 [thread overview]
Message-ID: <20190507152441.GC25013@lunn.ch> (raw)
In-Reply-To: <1557242108-13580-2-git-send-email-sagar.kadam@sifive.com>
> +or
> + /*
> + An Opencore based I2C node in FU540-C000 chip from SiFive
> + This chip has a hardware erratum for broken IRQ
> + so it's recommended not to define interrupt in the device node
> + */
> + i2c@10030000 {
> + compatible = "sifive,i2c0","sifive,fu540-c000-i2c";
The most specific compatible comes first.
You also need to be forward thinking. The next revision of the silicon
could have the bug fixed. You can then use plain "sifive,i2c0" to
indicate just polling is needed, not bug workaround. But for that to
work, you need "sifive,fu540-c000-i2c" first.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
peter@korsgaard.com, palmer@sifive.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-i2c@vger.kernel.org, paul.walmsley@sifive.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 v2 1/3] dt-bindings: i2c: extend existing opencore bindings.
Date: Tue, 7 May 2019 17:24:41 +0200 [thread overview]
Message-ID: <20190507152441.GC25013@lunn.ch> (raw)
In-Reply-To: <1557242108-13580-2-git-send-email-sagar.kadam@sifive.com>
> +or
> + /*
> + An Opencore based I2C node in FU540-C000 chip from SiFive
> + This chip has a hardware erratum for broken IRQ
> + so it's recommended not to define interrupt in the device node
> + */
> + i2c@10030000 {
> + compatible = "sifive,i2c0","sifive,fu540-c000-i2c";
The most specific compatible comes first.
You also need to be forward thinking. The next revision of the silicon
could have the bug fixed. You can then use plain "sifive,i2c0" to
indicate just polling is needed, not bug workaround. But for that to
work, you need "sifive,fu540-c000-i2c" first.
Andrew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-05-07 15:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 15:15 [PATCH v2 v2 0/3] Extend dt bindings to support I2C on sifive devices and a fix broken IRQ in polling mode Sagar Shrikant Kadam
2019-05-07 15:15 ` Sagar Shrikant Kadam
2019-05-07 15:15 ` [PATCH v2 v2 1/3] dt-bindings: i2c: extend existing opencore bindings Sagar Shrikant Kadam
2019-05-07 15:15 ` Sagar Shrikant Kadam
2019-05-07 15:24 ` Andrew Lunn [this message]
2019-05-07 15:24 ` Andrew Lunn
2019-05-13 20:56 ` Rob Herring
2019-05-13 20:56 ` Rob Herring
2019-05-14 12:50 ` Sagar Kadam
2019-05-14 12:50 ` Sagar Kadam
2019-05-14 13:01 ` Andrew Lunn
2019-05-14 13:01 ` Andrew Lunn
2019-05-14 16:05 ` Rob Herring
2019-05-14 16:05 ` Rob Herring
2019-05-07 15:15 ` [PATCH v2 v2 2/3] i2c-ocore: sifive: add support for i2c device on FU540-c000 SoC Sagar Shrikant Kadam
2019-05-07 15:15 ` Sagar Shrikant Kadam
2019-05-07 15:26 ` Andrew Lunn
2019-05-07 15:26 ` Andrew Lunn
2019-05-07 15:15 ` [PATCH v2 v2 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC Sagar Shrikant Kadam
2019-05-07 15:15 ` Sagar Shrikant Kadam
2019-05-07 15:27 ` [PATCH v2 v2 0/3] Extend dt bindings to support I2C on sifive devices and a fix broken IRQ in polling mode Andrew Lunn
2019-05-07 15:27 ` Andrew Lunn
2019-05-07 16:00 ` Sagar Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507152441.GC25013@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=peter@korsgaard.com \
--cc=robh+dt@kernel.org \
--cc=sagar.kadam@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.